Re: [Hamlib-developer] Re: Patches for FreeBSD, part I

[Michael S. <jam...@ea...>]

On Mon, 2 Sep 2002 00:20:01 +0200
Stephane Fillod <f8...@fr...> wrote:

> Sorry to be a bit picky, your patches are fine for *BSD, but they could
> be even better for non BSD system that are *BSD like. Besides, this is
> the whole philosophy behind autoconf. Do not test for a system, but
> rather for the existence (or lack thereof) of a feature.

Be picky :) I don' get in a twist that easily. The format for the patches was based on more traditional *BSD methods; I'll come at it more generally. 

> In other words, I would like to get rid of "#if !defined(BSD)".
> For event.c.patch, it looks trivial since it can be done by detecting 
> presence of F_SETSIG.

Basing it off F_SETSIG is fine as well; BSD does not support F_SETSIG. I'll re-do it based on that.

> Does *BSD have both TERMIOS and TERMIO?

Yes. See below:

> May be the right fix would be:
> 
> 	#ifdef HAVE_TERMIOS_H
> 	#include <termios.h> /* POSIX terminal control definitions */
> 	#else
> 	#ifdef HAVE_TERMIO_H
> 	#include <termio.h>
> 	#else  /* sgtty */
> 	#include <sgtty.h>
> 	#endif
> 	#endif

This has the same effect, so by all means please change it. It fixes the issue. And you are correct, it is more general.

 
> NB: added 'else' statement after HAVE_TERMIOS_H
> 
> > I am still working on patches for rpcrig and rpcrot, and will post them as soon as they are ready.
> 
> They'll be very welcome.
> Be careful, for rpcrig and rpcrot, some files are auto-generated.

Or, in the case of the bug I'm looking at, not auto-generated at all. Seeing the recent mail from Joop, this may have gone away anyway.

73s

mike