Re: [Hamlib-developer] Kenwood TH-D7A(G) patch

[Stephane F. <f4...@fr...>]

On Mon, Dec 31, 2001, Francois Retief wrote:
> I borrowed a Kenwood TH-D7A(G) to test with Hamlib. Here is a
> patch with that works with that radio.  It seems the TH-D7
> is not using the same protocol as other radios, 
> ie. FQ<CR> compared to FA; for other radios.

Great! I love patches! And yours is now commited to cvs.
You're right, the TH-D7 is using a protocol similar to the Kenwood table
top rigs, but with some changes. It turns out I own a TH-F7E, and even
though I don't have the protocol specs, it looks like the commands are the
same as the TH-D7, hence the kenwood/th.c file.

> It seems that some duplication can be avoided if the
> kenwood_transaction is responsible for adding the terminating
> character (either, ';' for older radios and <CR> for TH) 
> based on the radio being used.

sure! Actualy, I don't like at all kenwood_transaction().
So feel free to crush it and rewrite it correctly, in the light of the
different Kenwood protocol variants. If not sure how to do it, we can
discuss about it. That'd be neat if kenwood_transaction could handle
rigs error codes without having to pass an ack_buf. Thus when no response
is expected, ack_buf = NULL would be better than ack_len = 0.

> Also, it seems that the *data_len parameter is not returning
> any value.  I always get zero length, but the buffer contain 
> the correct string.

okay, time to take a closer look.


Thank you very much for the patch and the help

Cheers,
Stephane