Re: [Hamlib-developer] API outstanding issues

[Frank S. <vk...@ix...>]

Stephane Fillod wrote:
> 
> Frank Singleton wrote:

<snip >

> > int rig_set_vfo_params(RIG *rig, vfo_t vfo, rmode_t mode, fresp_t fresp)
> > ??
> > int rig_get_vfo_params(RIG *rig, vfo_t vfo, rmode_t *mode, fresp_t
> > *fresp) ??
> >
> >
> > Also, the pbwidth_t is a subset of a general freq response type
> >
> > struct freqresp {
> >       filter_path_t fpt;  /* filter location */
> >       filter_mode_t fmt;  /* filter mode, eg: NORMAL,WIDE etc or CUSTOM */
> >                             /* CUSTOM must provide flower,fupper,fcenter
> > etc */
> >                             /* depending on CUSTOM type */
> > };
> >
> > typedef freqresp fresp_t;
> >
> [...]
> 
>   Your proposal looks comprehensive, however, I don't have such features
>   on my rig, and since I'm not very knowledged in this field, well I
>   cannot say much.
>   In an effort to try to map the Hamlib API to the way rigs work,
>   I would rather argue for two set of functions.
> 
> > >  int rig_set_mode(RIG *rig, vfo_t vfo, rmode_t mode, pbwidth_t width);
> > >  int rig_get_mode(RIG *rig, vfo_t vfo, rmode_t *mode, pbwidth_t *width);
> 
>   This would cover basic VFO support, ie. probably more than 80% of the
>   rigs out there, which don't have filters.
> 
>   And then, another set of functions, yet to specify, to fine tune
>   the filters of the mode:
> 
>         int rig_set_filter(RIG *rig, vfo_t vfo, fresp_t fresp)
>         int rig_get_filter(RIG *rig, vfo_t vfo, fresp_t, *fresp)
> 
>   Let me know what you think of the rig_set_mode/rig_get_mode approach
>   at least, if we have time to implement it before the forthcoming 1.1.0
>   release.

Ok, at least both approaches should cover everyone's requirements.

If you patch the frontend, I will update ft747 and ft847 to
accept the new API. Then we RELEASE !!

Cheers / Frank..