[Hamlib-commits] Hamlib -- Ham radio control libraries branch master updated. fb026f7fafe5cda6f4dd9e8ac44591fe831e41c8

[Michael B. <mdb...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Hamlib -- Ham radio control libraries".

The branch, master has been updated
       via  fb026f7fafe5cda6f4dd9e8ac44591fe831e41c8 (commit)
       via  c7a5ae3e347df4d5e1b9648854d6b1327784d0c8 (commit)
       via  c3ac828cdb5c98e13a64a1d9c8a0af38badb1a8a (commit)
      from  59df7ccc23ce36b735fd118cf61b87a296028e20 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fb026f7fafe5cda6f4dd9e8ac44591fe831e41c8
Author: Michael Black W9MDB <mdb...@ya...>
Date:   Fri Jan 15 12:27:04 2021 -0600

    Remove BS from newcat_cmd_set_validate as there is no read capability
    https://github.com/Hamlib/Hamlib/issues/505

diff --git a/rigs/yaesu/newcat.c b/rigs/yaesu/newcat.c
index 95ee5b5e..16d6f433 100644
--- a/rigs/yaesu/newcat.c
+++ b/rigs/yaesu/newcat.c
@@ -9411,10 +9411,6 @@ int newcat_set_cmd_validate(RIG *rig)
     {
         strcpy(valcmd,"FT;");
     }
-    else if ((strncmp(priv->cmd_str,"BS",2)==0) && (strlen(priv->cmd_str)>3))
-    {
-        strcpy(valcmd,"BS;");
-    }
     else if ((strncmp(priv->cmd_str,"AI",2)==0) && (strlen(priv->cmd_str)>3))
     {
         strcpy(valcmd,"AI;");

commit c7a5ae3e347df4d5e1b9648854d6b1327784d0c8
Author: Michael Black W9MDB <mdb...@ya...>
Date:   Fri Jan 15 12:02:58 2021 -0600

    Fix boo boo
    https://github.com/Hamlib/Hamlib/issues/505

diff --git a/rigs/yaesu/newcat.c b/rigs/yaesu/newcat.c
index 7ae231fc..95ee5b5e 100644
--- a/rigs/yaesu/newcat.c
+++ b/rigs/yaesu/newcat.c
@@ -9429,7 +9429,7 @@ int newcat_set_cmd_validate(RIG *rig)
         int bytes;
         char cmd[256]; // big enough
         rig_flush(&state->rigport);  /* discard any unsolicited data */
-        snprintf(cmd,sizeof(cmd),"%s%s",priv->cmd_str,priv->valcmd);
+        snprintf(cmd,sizeof(cmd),"%s%s",priv->cmd_str,valcmd);
         rc = write_block(&state->rigport, cmd, strlen(cmd));
         if (rc != RIG_OK) return -RIG_EIO;
         bytes = read_string(&state->rigport, priv->ret_data, sizeof(priv->ret_data),

commit c3ac828cdb5c98e13a64a1d9c8a0af38badb1a8a
Author: Michael Black W9MDB <mdb...@ya...>
Date:   Fri Jan 15 12:01:06 2021 -0600

    Combine writes in newcat_set_cmd_validate to speed up timing
    https://github.com/Hamlib/Hamlib/issues/505

diff --git a/rigs/yaesu/newcat.c b/rigs/yaesu/newcat.c
index d1f95695..7ae231fc 100644
--- a/rigs/yaesu/newcat.c
+++ b/rigs/yaesu/newcat.c
@@ -9427,10 +9427,10 @@ int newcat_set_cmd_validate(RIG *rig)
     while (rc != RIG_OK && retry++ < retries)
     {
         int bytes;
+        char cmd[256]; // big enough
         rig_flush(&state->rigport);  /* discard any unsolicited data */
-        rc = write_block(&state->rigport, priv->cmd_str, strlen(priv->cmd_str));
-        if (rc != RIG_OK) return -RIG_EIO;
-        rc = write_block(&state->rigport, valcmd, strlen(valcmd));
+        snprintf(cmd,sizeof(cmd),"%s%s",priv->cmd_str,priv->valcmd);
+        rc = write_block(&state->rigport, cmd, strlen(cmd));
         if (rc != RIG_OK) return -RIG_EIO;
         bytes = read_string(&state->rigport, priv->ret_data, sizeof(priv->ret_data),
                               &cat_term, sizeof(cat_term));

-----------------------------------------------------------------------

Summary of changes:
 rigs/yaesu/newcat.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Hamlib -- Ham radio control libraries