Thread: [Hamlib-developer] [Hamlib/Hamlib] ecadc4: Fix IC756 warnings for MacOS
Library to control radio transceivers and receivers
Brought to you by:
n0nb
Menu
▾
▴
hamlib-developer
|
From: Michael B. <no...@gi...> - 2024-09-10 22:57:40
|
Branch: refs/heads/master Home: https://github.com/Hamlib/Hamlib Commit: ecadc46ca26dcac51ab0f3e50aa9acef9a824a1e https://github.com/Hamlib/Hamlib/commit/ecadc46ca26dcac51ab0f3e50aa9acef9a824a1e Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic756.c Log Message: ----------- Fix IC756 warnings for MacOS Commit: be9f3e7a62ca74e175e0185641fa16adc25ac958 https://github.com/Hamlib/Hamlib/commit/be9f3e7a62ca74e175e0185641fa16adc25ac958 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/icr75.c M rigs/icom/level_gran_icom.h Log Message: ----------- Fix warnings in icr75.c for MacOS Commit: f2811b739406af6a20715ade6b26f8ca72705cff https://github.com/Hamlib/Hamlib/commit/f2811b739406af6a20715ade6b26f8ca72705cff Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic7800.c Log Message: ----------- Fix compile warning in ic7800.c for MacOS Commit: d0da604d502235318a3ca9c1fa6073e81b5a31e2 https://github.com/Hamlib/Hamlib/commit/d0da604d502235318a3ca9c1fa6073e81b5a31e2 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic7100.c Log Message: ----------- Fix compile warnings for ic7100.c for MacOS Commit: ef4d932ffd2ce196b250ceb5fc3b3736b784c285 https://github.com/Hamlib/Hamlib/commit/ef4d932ffd2ce196b250ceb5fc3b3736b784c285 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic7000.c Log Message: ----------- Fix compile warnings for ic7000.c for MacOS Commit: ba1424ff7d93b2f9960999eb96310a4066547519 https://github.com/Hamlib/Hamlib/commit/ba1424ff7d93b2f9960999eb96310a4066547519 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic7200.c Log Message: ----------- Fix compile warnings for ic7200.c for MacOS Commit: 1dd12f0ef071048aa9ae0cba7cdc680cf580c3d7 https://github.com/Hamlib/Hamlib/commit/1dd12f0ef071048aa9ae0cba7cdc680cf580c3d7 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic7300.c M rigs/icom/level_gran_icom.h Log Message: ----------- Fix compile warnings for ic7300.c for MacOS Commit: f3f3cb9977ef3f4ec6a047e33dddb358a1e41e96 https://github.com/Hamlib/Hamlib/commit/f3f3cb9977ef3f4ec6a047e33dddb358a1e41e96 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic7600.c M rigs/icom/level_gran_icom.h Log Message: ----------- Fix compile warnings in ic7600.c for MacOS Commit: 86f6339f5ebef581437323edd3be1f61be6bcb40 https://github.com/Hamlib/Hamlib/commit/86f6339f5ebef581437323edd3be1f61be6bcb40 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/icom/ic7700.c Log Message: ----------- Fix compile warnings in ic7700.c for MacOS Commit: fe909084b923ba21317a15c2efb8bbaadf8666ac https://github.com/Hamlib/Hamlib/commit/fe909084b923ba21317a15c2efb8bbaadf8666ac Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/kenwood/level_gran_kenwood.h M rigs/kenwood/ts850.c Log Message: ----------- Fix compile warnings in ts850.c for MacOS Commit: 82c03a80fcfd7b82c16fa236370cae59a3349621 https://github.com/Hamlib/Hamlib/commit/82c03a80fcfd7b82c16fa236370cae59a3349621 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/kenwood/ts870s.c Log Message: ----------- Fix compile warnings in ts870s.c for MacOS Commit: ed7b65d58c7269ea87cbc0f3d66df3202216a321 https://github.com/Hamlib/Hamlib/commit/ed7b65d58c7269ea87cbc0f3d66df3202216a321 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/kenwood/level_gran_kenwood.h M rigs/kenwood/ts2000.c Log Message: ----------- Fix compile warnings in ts2000.c for MacOS Commit: 3f40c7b70da224093cb27a17ee81d8e1eaf272bf https://github.com/Hamlib/Hamlib/commit/3f40c7b70da224093cb27a17ee81d8e1eaf272bf Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/kenwood/ts480.c Log Message: ----------- Fix compile warnings in ts480.c for MacOS Commit: 52deeeeebf13c6e10b19f71f19b32f174a349407 https://github.com/Hamlib/Hamlib/commit/52deeeeebf13c6e10b19f71f19b32f174a349407 Author: Mike Black W9MDB <mdb...@ya...> Date: 2024-09-10 (Tue, 10 Sep 2024) Changed paths: M rigs/kenwood/ts930.c Log Message: ----------- Fix compile warnings in ts930.c for MacOS Compare: https://github.com/Hamlib/Hamlib/compare/853a0a282255...52deeeeebf13 To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications |
|
From: George B. <geo...@gm...> - 2024-09-11 01:45:02
|
Sheesh! What a waste of time and effort for all concerned. On 9/10/24 6:57 PM, Michael Black via Hamlib-developer wrote: > Branch: refs/heads/master > Home: https://github.com/Hamlib/Hamlib > Commit: ecadc46ca26dcac51ab0f3e50aa9acef9a824a1e > https://github.com/Hamlib/Hamlib/commit/ecadc46ca26dcac51ab0f3e50aa9acef9a824a1e > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic756.c > > Log Message: > ----------- > Fix IC756 warnings for MacOS > > > Commit: be9f3e7a62ca74e175e0185641fa16adc25ac958 > https://github.com/Hamlib/Hamlib/commit/be9f3e7a62ca74e175e0185641fa16adc25ac958 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/icr75.c > M rigs/icom/level_gran_icom.h > > Log Message: > ----------- > Fix warnings in icr75.c for MacOS > > > Commit: f2811b739406af6a20715ade6b26f8ca72705cff > https://github.com/Hamlib/Hamlib/commit/f2811b739406af6a20715ade6b26f8ca72705cff > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7800.c > > Log Message: > ----------- > Fix compile warning in ic7800.c for MacOS > > > Commit: d0da604d502235318a3ca9c1fa6073e81b5a31e2 > https://github.com/Hamlib/Hamlib/commit/d0da604d502235318a3ca9c1fa6073e81b5a31e2 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7100.c > > Log Message: > ----------- > Fix compile warnings for ic7100.c for MacOS > > > Commit: ef4d932ffd2ce196b250ceb5fc3b3736b784c285 > https://github.com/Hamlib/Hamlib/commit/ef4d932ffd2ce196b250ceb5fc3b3736b784c285 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7000.c > > Log Message: > ----------- > Fix compile warnings for ic7000.c for MacOS > > > Commit: ba1424ff7d93b2f9960999eb96310a4066547519 > https://github.com/Hamlib/Hamlib/commit/ba1424ff7d93b2f9960999eb96310a4066547519 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7200.c > > Log Message: > ----------- > Fix compile warnings for ic7200.c for MacOS > > > Commit: 1dd12f0ef071048aa9ae0cba7cdc680cf580c3d7 > https://github.com/Hamlib/Hamlib/commit/1dd12f0ef071048aa9ae0cba7cdc680cf580c3d7 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7300.c > M rigs/icom/level_gran_icom.h > > Log Message: > ----------- > Fix compile warnings for ic7300.c for MacOS > > > Commit: f3f3cb9977ef3f4ec6a047e33dddb358a1e41e96 > https://github.com/Hamlib/Hamlib/commit/f3f3cb9977ef3f4ec6a047e33dddb358a1e41e96 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7600.c > M rigs/icom/level_gran_icom.h > > Log Message: > ----------- > Fix compile warnings in ic7600.c for MacOS > > > Commit: 86f6339f5ebef581437323edd3be1f61be6bcb40 > https://github.com/Hamlib/Hamlib/commit/86f6339f5ebef581437323edd3be1f61be6bcb40 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7700.c > > Log Message: > ----------- > Fix compile warnings in ic7700.c for MacOS > > > Commit: fe909084b923ba21317a15c2efb8bbaadf8666ac > https://github.com/Hamlib/Hamlib/commit/fe909084b923ba21317a15c2efb8bbaadf8666ac > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/level_gran_kenwood.h > M rigs/kenwood/ts850.c > > Log Message: > ----------- > Fix compile warnings in ts850.c for MacOS > > > Commit: 82c03a80fcfd7b82c16fa236370cae59a3349621 > https://github.com/Hamlib/Hamlib/commit/82c03a80fcfd7b82c16fa236370cae59a3349621 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/ts870s.c > > Log Message: > ----------- > Fix compile warnings in ts870s.c for MacOS > > > Commit: ed7b65d58c7269ea87cbc0f3d66df3202216a321 > https://github.com/Hamlib/Hamlib/commit/ed7b65d58c7269ea87cbc0f3d66df3202216a321 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/level_gran_kenwood.h > M rigs/kenwood/ts2000.c > > Log Message: > ----------- > Fix compile warnings in ts2000.c for MacOS > > > Commit: 3f40c7b70da224093cb27a17ee81d8e1eaf272bf > https://github.com/Hamlib/Hamlib/commit/3f40c7b70da224093cb27a17ee81d8e1eaf272bf > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/ts480.c > > Log Message: > ----------- > Fix compile warnings in ts480.c for MacOS > > > Commit: 52deeeeebf13c6e10b19f71f19b32f174a349407 > https://github.com/Hamlib/Hamlib/commit/52deeeeebf13c6e10b19f71f19b32f174a349407 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/ts930.c > > Log Message: > ----------- > Fix compile warnings in ts930.c for MacOS > > > Compare: https://github.com/Hamlib/Hamlib/compare/853a0a282255...52deeeeebf13 > > To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications > > > _______________________________________________ > Hamlib-developer mailing list > Ham...@li... > https://lists.sourceforge.net/lists/listinfo/hamlib-developer |
|
From: Black M. <mdb...@ya...> - 2024-09-11 03:13:56
|
Sorry you think it's a waste of time to clear up compiler warnings. I disagree. On Tuesday, September 10, 2024 at 08:46:21 PM CDT, George Baltz <geo...@gm...> wrote: Sheesh! What a waste of time and effort for all concerned. On 9/10/24 6:57 PM, Michael Black via Hamlib-developer wrote: > Branch: refs/heads/master > Home: https://github.com/Hamlib/Hamlib > Commit: ecadc46ca26dcac51ab0f3e50aa9acef9a824a1e > https://github.com/Hamlib/Hamlib/commit/ecadc46ca26dcac51ab0f3e50aa9acef9a824a1e > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic756.c > > Log Message: > ----------- > Fix IC756 warnings for MacOS > > > Commit: be9f3e7a62ca74e175e0185641fa16adc25ac958 > https://github.com/Hamlib/Hamlib/commit/be9f3e7a62ca74e175e0185641fa16adc25ac958 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/icr75.c > M rigs/icom/level_gran_icom.h > > Log Message: > ----------- > Fix warnings in icr75.c for MacOS > > > Commit: f2811b739406af6a20715ade6b26f8ca72705cff > https://github.com/Hamlib/Hamlib/commit/f2811b739406af6a20715ade6b26f8ca72705cff > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7800.c > > Log Message: > ----------- > Fix compile warning in ic7800.c for MacOS > > > Commit: d0da604d502235318a3ca9c1fa6073e81b5a31e2 > https://github.com/Hamlib/Hamlib/commit/d0da604d502235318a3ca9c1fa6073e81b5a31e2 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7100.c > > Log Message: > ----------- > Fix compile warnings for ic7100.c for MacOS > > > Commit: ef4d932ffd2ce196b250ceb5fc3b3736b784c285 > https://github.com/Hamlib/Hamlib/commit/ef4d932ffd2ce196b250ceb5fc3b3736b784c285 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7000.c > > Log Message: > ----------- > Fix compile warnings for ic7000.c for MacOS > > > Commit: ba1424ff7d93b2f9960999eb96310a4066547519 > https://github.com/Hamlib/Hamlib/commit/ba1424ff7d93b2f9960999eb96310a4066547519 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7200.c > > Log Message: > ----------- > Fix compile warnings for ic7200.c for MacOS > > > Commit: 1dd12f0ef071048aa9ae0cba7cdc680cf580c3d7 > https://github.com/Hamlib/Hamlib/commit/1dd12f0ef071048aa9ae0cba7cdc680cf580c3d7 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7300.c > M rigs/icom/level_gran_icom.h > > Log Message: > ----------- > Fix compile warnings for ic7300.c for MacOS > > > Commit: f3f3cb9977ef3f4ec6a047e33dddb358a1e41e96 > https://github.com/Hamlib/Hamlib/commit/f3f3cb9977ef3f4ec6a047e33dddb358a1e41e96 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7600.c > M rigs/icom/level_gran_icom.h > > Log Message: > ----------- > Fix compile warnings in ic7600.c for MacOS > > > Commit: 86f6339f5ebef581437323edd3be1f61be6bcb40 > https://github.com/Hamlib/Hamlib/commit/86f6339f5ebef581437323edd3be1f61be6bcb40 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/icom/ic7700.c > > Log Message: > ----------- > Fix compile warnings in ic7700.c for MacOS > > > Commit: fe909084b923ba21317a15c2efb8bbaadf8666ac > https://github.com/Hamlib/Hamlib/commit/fe909084b923ba21317a15c2efb8bbaadf8666ac > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/level_gran_kenwood.h > M rigs/kenwood/ts850.c > > Log Message: > ----------- > Fix compile warnings in ts850.c for MacOS > > > Commit: 82c03a80fcfd7b82c16fa236370cae59a3349621 > https://github.com/Hamlib/Hamlib/commit/82c03a80fcfd7b82c16fa236370cae59a3349621 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/ts870s.c > > Log Message: > ----------- > Fix compile warnings in ts870s.c for MacOS > > > Commit: ed7b65d58c7269ea87cbc0f3d66df3202216a321 > https://github.com/Hamlib/Hamlib/commit/ed7b65d58c7269ea87cbc0f3d66df3202216a321 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/level_gran_kenwood.h > M rigs/kenwood/ts2000.c > > Log Message: > ----------- > Fix compile warnings in ts2000.c for MacOS > > > Commit: 3f40c7b70da224093cb27a17ee81d8e1eaf272bf > https://github.com/Hamlib/Hamlib/commit/3f40c7b70da224093cb27a17ee81d8e1eaf272bf > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/ts480.c > > Log Message: > ----------- > Fix compile warnings in ts480.c for MacOS > > > Commit: 52deeeeebf13c6e10b19f71f19b32f174a349407 > https://github.com/Hamlib/Hamlib/commit/52deeeeebf13c6e10b19f71f19b32f174a349407 > Author: Mike Black W9MDB <mdb...@ya...> > Date: 2024-09-10 (Tue, 10 Sep 2024) > > Changed paths: > M rigs/kenwood/ts930.c > > Log Message: > ----------- > Fix compile warnings in ts930.c for MacOS > > > Compare: https://github.com/Hamlib/Hamlib/compare/853a0a282255...52deeeeebf13 > > To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications > > > _______________________________________________ > Hamlib-developer mailing list > Ham...@li... > https://lists.sourceforge.net/lists/listinfo/hamlib-developer _______________________________________________ Hamlib-developer mailing list Ham...@li... https://lists.sourceforge.net/lists/listinfo/hamlib-developer |
|
From: George B. <geo...@gm...> - 2024-09-13 14:43:12
|
On 9/10/24 11:13 PM, Black Michael wrote: > Sorry you think it's a waste of time to clear up compiler warnings. I disagree. > I have no problem clearing up compiler warnings if - They address real problems - They make my life simpler, as programmer or maintainer - They reduce the probability of future problems These changes don't seem to help any of those. 1) The warning is bogus. Setting a baseline or default for any value and then overriding that in specific or localized instances is a pretty fundamental way we build, configure or execute programs. Do you get a warning for adding a CLI option to override a program default? Or when a .rc file changes a default to what >you< want? Do you have to rebuild a program, removing the default before adding your own choice? I don't think so. Stigmatizing that hierarchy of settings doesn't seem like a good idea to me. 2) So far it's taken about 400 lines of code(LoC). That's 400 more to maintain. And it changes simple one-liners into changes in multiple places, possibly multiple files. Simplify, simplify. 3) It makes the code much more fragile; instead of making a data change in one place, you need to sync three. And there's no default to fall back on, just by removing the override. Again, multiple actions instead of one. Sorry, but this doesn't look like progress to me. YMMV. 73 n3gb |
|
From: Black M. <mdb...@ya...> - 2024-09-13 15:03:43
|
The real problem it addresses is reviewing the Mac build for real warnings and errors. All the bogus ones get in the way of viewing the output. That's why we clear up all warnings on all platforms. On Friday, September 13, 2024 at 09:43:06 AM CDT, George Baltz <geo...@gm...> wrote: On 9/10/24 11:13 PM, Black Michael wrote: > Sorry you think it's a waste of time to clear up compiler warnings. I disagree. > I have no problem clearing up compiler warnings if - They address real problems - They make my life simpler, as programmer or maintainer - They reduce the probability of future problems These changes don't seem to help any of those. 1) The warning is bogus. Setting a baseline or default for any value and then overriding that in specific or localized instances is a pretty fundamental way we build, configure or execute programs. Do you get a warning for adding a CLI option to override a program default? Or when a .rc file changes a default to what >you< want? Do you have to rebuild a program, removing the default before adding your own choice? I don't think so. Stigmatizing that hierarchy of settings doesn't seem like a good idea to me. 2) So far it's taken about 400 lines of code(LoC). That's 400 more to maintain. And it changes simple one-liners into changes in multiple places, possibly multiple files. Simplify, simplify. 3) It makes the code much more fragile; instead of making a data change in one place, you need to sync three. And there's no default to fall back on, just by removing the override. Again, multiple actions instead of one. Sorry, but this doesn't look like progress to me. YMMV. 73 n3gb |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X