hamlib-developer

[Hamlib-developer] Proper caps in NET driver

[Piotr S. <sq...@wp...>]

Hello group!
This is my first post on this group. My name is Piotr SQ9FK.
I will try to update and full test Backend for IC-7100.
But first thing I try to solve is proper parsing of remote caps in NET
driver.

Reason of this is grig. It uses them to configure the gui for user.

As I noticed NET driver has declared static:

RIG_FUNC_NONE,
RIG_LEVEL_NONE,
RIG_PARM_NONE,
Attenuator is empty etc.

After that  .rig_open = netrigctl_open,
update all rig->state.things from remotly executed \dump_state.
Problem is that after this caps are not updated.
And \dump_caps uses caps-> declaration not the rig->state.*

How is correct way to solve this ?
Should I in f. netrigctl_open() after every rig->state.* update copy the
value to correspond caps->* ?

Thanks for reply,
Piotr SQ(FK

Re: [Hamlib-developer] Proper caps in NET driver

[Bill S. <g4...@cl...>]

On 11/12/2015 15:36, Piotr SQ9FK wrote:
> How is correct way to solve this ?
> Should I in f. netrigctl_open() after every rig->state.* update copy the
> value to correspond caps->* ?
Hi Piotr,

rig->caps is a pointer to a struct that is supposed to be immutable. I 
don't think that the const struct rig_caps (netrigctl_caps) should be 
modified as it could be shared by more than one opened rig - the const 
is there for a reason!

If it does make sense to "clone" the caps struct of a network accessed 
rig then netrigctl could build a new rig_caps struct on the heap and set 
rig->caps to point at it. In that case allocating a rig_caps struct on 
the heap and starting with a copy of netrigctl_caps in it might make sense.

73
Bill
G4WJS.