On Wed, Jan 09, 2002, Joop Stakenborg wrote:
> Attached is a patch against CVS which adds kenwood_set_func.
> Works fine on my ts870. I did not want to do 'case RIG_FUNC_FAGC',
> as I can't test it.
Not a problem. Right now, I think, I really test myself less than 10% of
what I write in Hamlib. Thanks to you guys and your efforts, Hamlib will
have less than 9 chances out of 10 to crash :-)
> Stephane, feel free to edit to your needs.
Don't worry, it's excellent, and commited by the way.
May be this will be extended when testing set_func on TH-D7/TH-F7E.
> One thing to think about: some of these functions are not available
> in all modes. For example, if I want to turn the speech processor
> on when the rig is in CW, '?;' is returned. Same for beat cancel
> and notch. Right now, hamlib will silently ignore it.
You're right, Hamlib should prevent this situations. However, it's too
much work for now (to modelize these limitations in capabilities,
implement in frontend, etc.)
However, one thing that can be done is for kenwood_transaction to return
something like -RIG_EINVAL instead of silently ignoring.
> I have also added a get_level for the agc level (0..255).
>
> So, on to kenwood_set_level.
Good job Joop. Thank you very much. I wish to kick out a hamlib-1.1.3 very
soon so I can give xlog more attention.
Cheers,
Stephane
|
