hamlib-developer — hamlib developers forum

Re: [Hamlib-developer] What am I missing?

[George B. <geo...@gm...>]

How about [PC|MS]-DOS? That would have almost faded away by the time 
hamlib started, but maybe it was considered as a use for retired systems.

It may be time to reconsider some other data types with this major 
version update, and some major H/W changes since it was last done.


On 7/26/25 7:09 PM, Greg Troxel wrote:
> Nate Bargmann <n0...@n0...> writes:
>
>> * On 2025 26 Jul 09:52 -0500, George Baltz wrote:
>>> I'm wondering if this is why shortfreq_t is still a long.  Signed 16 bits
>>> might be too short (repeater offset) but 32 bits would work.
>>>
>>> Would it be possible to change shortfreq_t to int32 for 5.0?
>> I think so as we're communicating with the advancement of the major
>> number that API changes are made and ABI is broken.
>>
>> Any such values that appear to be limited should probably be evaluated
>> for 5.0.
> And implicitly, if there's any concern about the actual size of the
> type, C99(?) fixed-width types like int32_t are prepared.
>
> I am surprised though about 16-bit ints.  Perhaps that's a Windows thing
> semi-recently.  Unix on the PDP-11 (V6, V7 and 2.8-2.11 BSD) had 16 bit
> ints and 32 bit longs.   I am pretty sure the Vax had 32 bit int right
> away.  And that's mid 80s with PDP-11s fading by mid 90s.
>
>
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer

Re: [Hamlib-developer] What am I missing?

[Greg T. <gd...@le...>]

Nate Bargmann <n0...@n0...> writes:

> * On 2025 26 Jul 09:52 -0500, George Baltz wrote:
>> I'm wondering if this is why shortfreq_t is still a long.  Signed 16 bits
>> might be too short (repeater offset) but 32 bits would work.
>> 
>> Would it be possible to change shortfreq_t to int32 for 5.0?
>
> I think so as we're communicating with the advancement of the major
> number that API changes are made and ABI is broken.
>
> Any such values that appear to be limited should probably be evaluated
> for 5.0.

And implicitly, if there's any concern about the actual size of the
type, C99(?) fixed-width types like int32_t are prepared.

I am surprised though about 16-bit ints.  Perhaps that's a Windows thing
semi-recently.  Unix on the PDP-11 (V6, V7 and 2.8-2.11 BSD) had 16 bit
ints and 32 bit longs.   I am pretty sure the Vax had 32 bit int right
away.  And that's mid 80s with PDP-11s fading by mid 90s.

Re: [Hamlib-developer] What am I missing?

[Nate B. <n0...@n0...>]

* On 2025 26 Jul 09:52 -0500, George Baltz wrote:
> I'm wondering if this is why shortfreq_t is still a long.  Signed 16 bits
> might be too short (repeater offset) but 32 bits would work.
> 
> Would it be possible to change shortfreq_t to int32 for 5.0?

I think so as we're communicating with the advancement of the major
number that API changes are made and ABI is broken.

Any such values that appear to be limited should probably be evaluated
for 5.0.

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

Re: [Hamlib-developer] What am I missing?

[George B. <geo...@gm...>]

I'm wondering if this is why shortfreq_t is still a long.  Signed 16 
bits might be too short (repeater offset) but 32 bits would work.

Would it be possible to change shortfreq_t to int32 for 5.0?

On 7/26/25 9:34 AM, Nate Bargmann wrote:
> Just had a short discussion off list and looking at the history,
> rig_model_t was originally an int.  I was reminded on some
> implementations that int can be 16 bits and being signed can only hold a
> positive value up to 32768.  Looked at in this way, raising the max
> model numbers to 1000 limited Hamlib to 32 backends.  Mike resolved this
> by changing rig_model_t (there's a joke in there somewhere) to uint32_t.
>
> As I noted, at this time there are plenty of available models and
> backends.  As I am updating comments in the various files to improve
> documentation, I feel comfortable removing Mike's comments of concern in
> riglist.h.
>
> 73, Nate
>
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer

Re: [Hamlib-developer] What am I missing?

[Nate B. <n0...@n0...>]

Just had a short discussion off list and looking at the history,
rig_model_t was originally an int.  I was reminded on some
implementations that int can be 16 bits and being signed can only hold a
positive value up to 32768.  Looked at in this way, raising the max
model numbers to 1000 limited Hamlib to 32 backends.  Mike resolved this
by changing rig_model_t (there's a joke in there somewhere) to uint32_t.

As I noted, at this time there are plenty of available models and
backends.  As I am updating comments in the various files to improve
documentation, I feel comfortable removing Mike's comments of concern in
riglist.h.

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

Re: [Hamlib-developer] What am I missing?

[Greg T. <gd...@le...>]

It feels like a worry about 65536 forgetting that this is 16 bits not
32.

I wonder if it's possible to clean this up to be 10 bits of model and 10
bits of backend, always using accessor/constructor functions, and for
extra points change  those numbers and run tests.  But that may not be a
useful thing to do.

73 de n1dam

[Hamlib-developer] What am I missing?

[Nate B. <n0...@n0...>]

Looking at riglist.h there is an ominous set of comments toward the
beginning of the file:

// The rig model number is designed to fit in a 32-bit int
// As of 2024-07-14 we have 39 backends defined -- need to be careful
// about generating new ones
// Perhaps combine them under a MISC entry should work
// As of 2020-02-18 we have 33 backends defined
// With a max of 1000 models per backend we get total a model number
// range of 1001-33001
// This MAX was 100 prior to 2020-02-18 and Icom was close to running
// out of the 100 range


The macros this precedes are:

#define  MAX_MODELS_PER_BACKEND 1000
#define RIG_MAKE_MODEL(a,b) (MAX_MODELS_PER_BACKEND*(a)+(b))
#define RIG_BACKEND_NUM(a) ((a)/MAX_MODELS_PER_BACKEND)

All of the model numbers are decimal values.  The 32 bit int referenced
is rig_model_t which is declared as a uint32_t which has a value range
of 0 to 4294967295.  At 1000 models per backend, my calculator shows this
leaves us *only* 4294967 backends.  How will we cope?  I'm sure we could
have 10000 models per backend and we wouldn't run out for a few
lifetimes.  By then 32 bit will likely seem as quaint as 4 bit does
today.

Both comments were added by Mike, most of it in 2020 and lines two and
three about a year ago.  I wonder if he had in mind that rig_model_t was
being used as a bit mask?  Of course I don't know.  Unless I'm reading
the macro wrong, it seems to me his was an unfounded concern.

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

[Hamlib-developer] [Hamlib/Hamlib] 6cfaf0: Add amp_state.h to Doxygen docs

[Nate B. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: 6cfaf03edd7c514c39b2620ae97763313169f14a
      https://github.com/Hamlib/Hamlib/commit/6cfaf03edd7c514c39b2620ae97763313169f14a
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M doc/Makefile.am
    M include/hamlib/amp_state.h

  Log Message:
  -----------
  Add amp_state.h to Doxygen docs


  Commit: 9ede33de4f690fd70c830aae1465d8bc9070839f
      https://github.com/Hamlib/Hamlib/commit/9ede33de4f690fd70c830aae1465d8bc9070839f
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M doc/hamlib.cfg.in

  Log Message:
  -----------
  Exclude multicast.[ch] from Doxygen docs


  Commit: 133817bf146eca08ce8267793f31b14c47f90b08
      https://github.com/Hamlib/Hamlib/commit/133817bf146eca08ce8267793f31b14c47f90b08
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M include/hamlib/multicast.h
    M src/multicast.c

  Log Message:
  -----------
  Add license header to multicast.[ch]


  Commit: c49cd2312cbdd0f859642160fb3874eab9db107d
      https://github.com/Hamlib/Hamlib/commit/c49cd2312cbdd0f859642160fb3874eab9db107d
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M doc/Makefile.am
    M doc/hamlib.cfg.in
    M doc/index.doxygen
    M include/hamlib/port.h
    M include/hamlib/rig.h

  Log Message:
  -----------
  Add Doxygen support to port.h


  Commit: 947b2da28f1b9ca0e64a59acabdc49da2eb1d9fe
      https://github.com/Hamlib/Hamlib/commit/947b2da28f1b9ca0e64a59acabdc49da2eb1d9fe
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M include/hamlib/amp_state.h

  Log Message:
  -----------
  Update Doxygen comments in amp_state.h


  Commit: 30494a4a1f03db4b9cdab6e901e6461d160d22e7
      https://github.com/Hamlib/Hamlib/commit/30494a4a1f03db4b9cdab6e901e6461d160d22e7
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M include/hamlib/amplist.h

  Log Message:
  -----------
  Update Dozygen comments for amplist.h


  Commit: 605e961dbf46498284799cda6a991f47d810e66f
      https://github.com/Hamlib/Hamlib/commit/605e961dbf46498284799cda6a991f47d810e66f
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M include/hamlib/rotlist.h

  Log Message:
  -----------
  Update Doxygen comments for rotlist.h


  Commit: 1eb645004a45bf84e1fb71dcad294081a551f83d
      https://github.com/Hamlib/Hamlib/commit/1eb645004a45bf84e1fb71dcad294081a551f83d
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M doc/hamlib.cfg.in

  Log Message:
  -----------
  Ignore additional files from Doxygen processing


  Commit: 98cc0b688e4f8cd0838d728d97a43e7a13d6c29c
      https://github.com/Hamlib/Hamlib/commit/98cc0b688e4f8cd0838d728d97a43e7a13d6c29c
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M doc/Makefile.am
    M include/hamlib/rot_state.h

  Log Message:
  -----------
  Update Doxygen comments for rot_state.h


  Commit: 82feea990e584d1648dd5567a6e3f0e2a693f6a3
      https://github.com/Hamlib/Hamlib/commit/82feea990e584d1648dd5567a6e3f0e2a693f6a3
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-23 (Wed, 23 Jul 2025)

  Changed paths:
    M doc/hamlib.cfg.in

  Log Message:
  -----------
  Add Doxygen config statements for newer versions

Newer versions of Doxygen (1.14 in Arch Linux) default HAVE_DOT and
CALL_GRAPH to NO, although older versions also default the latter to NO
as well.

Document why DISTRIBUTE_GROUP_DOC was added.  Removes a bit of
redundancy.


  Commit: 04c00330a6265680c2a78dbf88e9274eae1f02da
      https://github.com/Hamlib/Hamlib/commit/04c00330a6265680c2a78dbf88e9274eae1f02da
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-23 (Wed, 23 Jul 2025)

  Changed paths:
    M include/hamlib/rotator.h

  Log Message:
  -----------
  Clean upp Doxygen comments in rotator.h

When a comment block immediately preceeds the item, repeating the item
type such as \def or \typedef is not required.  They're only required
when the comment is not immediately preceeding or Doxygen doesn't get
the item correct.


Compare: https://github.com/Hamlib/Hamlib/compare/79f8b1cde83c...04c00330a626

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications

[Hamlib-developer] [Hamlib/Hamlib] debcc2: Clean up simft847.c

[Nate B. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: debcc2f565349a4ced8527dc9184a6d70d6a006c
      https://github.com/Hamlib/Hamlib/commit/debcc2f565349a4ced8527dc9184a6d70d6a006c
  Author: George Baltz N3GB <Geo...@gm...>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M simulators/simft847.c

  Log Message:
  -----------
  Clean up simft847.c

At least make get/set freq and mode work.


  Commit: 062f260c073707d18878f5be755800a894c04058
      https://github.com/Hamlib/Hamlib/commit/062f260c073707d18878f5be755800a894c04058
  Author: George Baltz N3GB <Geo...@gm...>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M simulators/simpstrotator.c
    M simulators/simts890.c
    M simulators/simts990.c

  Log Message:
  -----------
  Clean up some cppcheck gripes in simulators/


  Commit: 8469ee1737ba8ab1191a12b5b0788bf6c666c527
      https://github.com/Hamlib/Hamlib/commit/8469ee1737ba8ab1191a12b5b0788bf6c666c527
  Author: George Baltz N3GB <Geo...@gm...>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M rigs/dummy/dummy.c
    M rigs/rs/xk852.c

  Log Message:
  -----------
  Fix incorrect fallthroughs

Found with -Wimplicit-fallthrough, but also many false positives


  Commit: 47dae3879d95b1b68dccfba4c0e5757bdcdf38eb
      https://github.com/Hamlib/Hamlib/commit/47dae3879d95b1b68dccfba4c0e5757bdcdf38eb
  Author: George Baltz N3GB <Geo...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M lib/precise_time.c
    M rigs/barrett/barrett.c
    M rigs/dummy/dummy.c
    M rigs/dummy/flrig.c
    M rigs/dummy/netrigctl.c
    M rigs/dummy/quisk.c
    M rigs/dummy/tci1x.c
    M rigs/dummy/trxmanager.c
    M security/AESStringCrypt.c
    M src/sleep.c
    M tests/rigtestmcastrx.c

  Log Message:
  -----------
  Fix compiler errors with strict C23 standards

Fix missing/misplaced '#include "config.h"' statements. Fixes missing
  function prototypes, unknown type definitions, etc. Allows configuration
  of GCC with CFLAGS="-std=c23" instead of using default -std=gnu23.

Don't know about CLANG, MSVC, MinGW, etc, but using
gwb@stitch:~> gcc --version
gcc (SUSE Linux) 15.1.1 20250714
Copyright (C) 2025 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Hamlib can compile in strict C23 mode, or previous standard levels.


  Commit: 8bcfeda94ad7e8d0160e80b0ac67423f5b583567
      https://github.com/Hamlib/Hamlib/commit/8bcfeda94ad7e8d0160e80b0ac67423f5b583567
  Author: George Baltz N3GB <Geo...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M bindings/python/test_Hamlib_class.py

  Log Message:
  -----------
  Don't forget the noise


  Commit: 79f8b1cde83cf35b1cd30e67ab8f26fd1137b650
      https://github.com/Hamlib/Hamlib/commit/79f8b1cde83cf35b1cd30e67ab8f26fd1137b650
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M lib/precise_time.c
    M rigs/barrett/barrett.c
    M rigs/dummy/dummy.c
    M rigs/dummy/flrig.c
    M rigs/dummy/netrigctl.c
    M rigs/dummy/quisk.c
    M rigs/dummy/tci1x.c
    M rigs/dummy/trxmanager.c
    M rigs/rs/xk852.c
    M security/AESStringCrypt.c
    M simulators/simft847.c
    M simulators/simpstrotator.c
    M simulators/simts890.c
    M simulators/simts990.c
    M src/sleep.c
    M tests/rigtestmcastrx.c

  Log Message:
  -----------
  Merge HitHub PR #1811


Compare: https://github.com/Hamlib/Hamlib/compare/83ba4eb27fcd...79f8b1cde83c

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications

[Hamlib-developer] [Hamlib/Hamlib] b66d1a: Sort .gitignore

[dforsi <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: b66d1ac7c13b21ec5469be83bcc0df0b42ab35b8
      https://github.com/Hamlib/Hamlib/commit/b66d1ac7c13b21ec5469be83bcc0df0b42ab35b8
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  Sort .gitignore


  Commit: 9afdfc5de365ba6fa01b9f2816136d4c9fafbf0c
      https://github.com/Hamlib/Hamlib/commit/9afdfc5de365ba6fa01b9f2816136d4c9fafbf0c
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  Ignore more files


  Commit: d536f0ec9395ccfc6c7a0ceb7d88fd74a00f5529
      https://github.com/Hamlib/Hamlib/commit/d536f0ec9395ccfc6c7a0ceb7d88fd74a00f5529
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M configure.ac
    M include/hamlib/rig_state.h
    M tests/rigsmtr.c

  Log Message:
  -----------
  Fix typos


  Commit: f4ece0d207b73352512e81499416f02504dfd780
      https://github.com/Hamlib/Hamlib/commit/f4ece0d207b73352512e81499416f02504dfd780
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Remove unused conditionals

The conditionals that used those values were removed from
bindings/Makefile.am with commit b0408037 which replaced code
that installed the Perl bindings in different locations
depending on the OS with code that installed in all locations.


  Commit: 827138d23e8ea7cff97a2895f5560bfbef7cac13
      https://github.com/Hamlib/Hamlib/commit/827138d23e8ea7cff97a2895f5560bfbef7cac13
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M Makefile.am

  Log Message:
  -----------
  Remove duplicate subdir


  Commit: b5c8e7faba8e00b2843508a35668d90ea808e655
      https://github.com/Hamlib/Hamlib/commit/b5c8e7faba8e00b2843508a35668d90ea808e655
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M rigs/winradio/g313-posix.c
    M src/amp_reg.c
    M src/debug.c
    M src/event.c
    M src/gpio.c
    M src/iofunc.h
    M src/mem.c
    M src/parallel.c
    M src/register.c
    M src/rig.c
    M src/rot_reg.c
    M src/rot_settings.c
    M src/rotator.c
    M src/serial.c
    M src/snapshot_data.c
    M src/usb_port.c

  Log Message:
  -----------
  Remove unused #include <sys/types.h>

Found with iwyu.


  Commit: 2a3f603680f48054e43ad0f4afa20ae70eac0157
      https://github.com/Hamlib/Hamlib/commit/2a3f603680f48054e43ad0f4afa20ae70eac0157
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M rigs/flexradio/smartsdr.c
    M rigs/kit/dwt.c
    M rigs/kit/elektor507.c
    M rigs/kit/fifisdr.c
    M rigs/kit/funcube.c
    M rigs/kit/si570avrusb.c
    M src/sleep.c

  Log Message:
  -----------
  Remove unused #include <errno.h>

Found with iwyu.


  Commit: f621a961f47efc145bafa77fb184fcf58b2a42af
      https://github.com/Hamlib/Hamlib/commit/f621a961f47efc145bafa77fb184fcf58b2a42af
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M amplifiers/elecraft/kpa.h
    M amplifiers/expert/expert.h
    M amplifiers/gemini/gemini.h
    M rigs/alinco/dxsr8.c
    M rigs/commradio/frame.c

  Log Message:
  -----------
  Remove unused #include <serial.h>

Found with iwyu.


  Commit: 195ed0154378d6a0d6413036e73a5a056d9e3243
      https://github.com/Hamlib/Hamlib/commit/195ed0154378d6a0d6413036e73a5a056d9e3243
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M rigs/dummy/amp_dummy.c
    M rigs/dummy/netrigctl.c
    M rigs/dummy/quisk.c
    M rigs/tentec/paragon.c
    M rigs/tentec/tentec2.c
    M rigs/winradio/winradio.c
    M rigs/yaesu/ft2000.c
    M rigs/yaesu/ft9000.c
    M rigs/yaesu/newcat.c
    M rotators/rotorez/rotorez.c
    M rotators/ts7400/ts7400.c

  Log Message:
  -----------
  Remove unused #include "serial.h"

Found with iwyu.


  Commit: 974e619dd26db17ffb98461203e8ed67f2381d01
      https://github.com/Hamlib/Hamlib/commit/974e619dd26db17ffb98461203e8ed67f2381d01
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M rigs/alinco/dx77.c
    M rigs/aor/aor.c
    M rigs/aor/ar3000.c
    M rigs/aor/ar3030.c
    M rigs/aor/ar7030.c
    M rigs/aor/ar7030p_utils.c
    M rigs/aor/sr2200.c
    M rigs/barrett/barrett.c
    M rigs/codan/codan.c
    M rigs/commradio/commradio.c
    M rigs/dorji/dra818.c
    M rigs/dummy/aclog.c
    M rigs/dummy/flrig.c
    M rigs/dummy/sdrsharp.c
    M rigs/dummy/tci1x.c
    M rigs/dummy/trxmanager.c
    M rigs/gomspace/gs100.c
    M rigs/icmarine/icmarine.c
    M rigs/icom/frame.c
    M rigs/jrc/jrc.c
    M rigs/kachina/kachina.c
    M rigs/kenwood/elecraft.c
    M rigs/kenwood/ic10.c
    M rigs/kenwood/xg3.c
    M rigs/kit/miniVNA.c
    M rigs/mds/mds.c
    M rigs/prm80/prm80.c
    M rigs/racal/ra37xx.c
    M rigs/racal/racal.c
    M rigs/rft/rft.c
    M rigs/rs/ek89x.c
    M rigs/rs/gp2000.c
    M rigs/rs/rs.c
    M rigs/rs/xk852.c
    M rigs/skanti/skanti.c
    M rigs/tapr/tapr.c
    M rigs/tentec/omnivii.c
    M rigs/tentec/orion.c
    M rigs/tentec/rx331.c
    M rigs/tentec/rx340.c
    M rigs/tentec/tentec.c
    M rigs/tentec/tt550.c
    M rigs/uniden/uniden_digital.c
    M rigs/wj/wj.c
    M rigs/yaesu/frg100.c
    M rigs/yaesu/frg8800.c
    M rigs/yaesu/frg9600.c
    M rigs/yaesu/ft100.c
    M rigs/yaesu/ft1000d.c
    M rigs/yaesu/ft1000mp.c
    M rigs/yaesu/ft600.c
    M rigs/yaesu/ft736.c
    M rigs/yaesu/ft747.c
    M rigs/yaesu/ft757gx.c
    M rigs/yaesu/ft767gx.c
    M rigs/yaesu/ft817.c
    M rigs/yaesu/ft840.c
    M rigs/yaesu/ft847.c
    M rigs/yaesu/ft857.c
    M rigs/yaesu/ft890.c
    M rigs/yaesu/ft891.c
    M rigs/yaesu/ft897.c
    M rigs/yaesu/ft900.c
    M rigs/yaesu/ft920.c
    M rigs/yaesu/ft980.c
    M rigs/yaesu/ft990.c
    M rigs/yaesu/ft990v12.c
    M rigs/yaesu/vr5000.c
    M rigs/yaesu/vx1700.c
    M rotators/celestron/celestron.c
    M rotators/easycomm/easycomm.c
    M rotators/ether6/ether6.c
    M rotators/flir/flir.c
    M rotators/grbltrk/grbltrk.c
    M rotators/gs232a/gs232.c
    M rotators/gs232a/gs232a.c
    M rotators/heathkit/hd1780.c
    M rotators/ioptron/rot_ioptron.c
    M rotators/m2/rc2800.c
    M rotators/meade/meade.c
    M rotators/prosistel/prosistel.c
    M rotators/radant/radant.c
    M rotators/saebrtrack/saebrtrack.c
    M rotators/sartek/sartek.c
    M rotators/satel/satel.c
    M rotators/skywatcher/skywatcher.c
    M rotators/spid/spid.c
    M src/rotator.c

  Log Message:
  -----------
  Replace #include serial.h with iofunc.h

According to iwyu, to avoid unecessary rebuilds and to reduce the
chances of breakages of the build if includes are rearranged, the
code that uses serial_open() and ser_close() should include
serial.h while the code that uses read_block() write_block() and
similar should include iofunc.h, code that uses all of them should
include both files.

Found with iwyu.


  Commit: b57ad227a080cd58cb2ce3ca4c4d8797876602e9
      https://github.com/Hamlib/Hamlib/commit/b57ad227a080cd58cb2ce3ca4c4d8797876602e9
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M rigs/dummy/rot_pstrotator.c
    M rigs/flexradio/smartsdr.c
    M rotators/flir/flir.c

  Log Message:
  -----------
  Remove unused #include <math.h>

Found with iwyu.


  Commit: 7fe36ebdd6629e0ad852a95fc4d3404b4b5ddc8f
      https://github.com/Hamlib/Hamlib/commit/7fe36ebdd6629e0ad852a95fc4d3404b4b5ddc8f
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M rigs/icom/ic7800.c

  Log Message:
  -----------
  Remove unused includes


  Commit: 2fab137fc50cdb2bc78716d63daad866bf9b05c5
      https://github.com/Hamlib/Hamlib/commit/2fab137fc50cdb2bc78716d63daad866bf9b05c5
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M amplifiers/elecraft/kpa.c
    M amplifiers/elecraft/kpa.h
    M rigs/anytone/anytone.c
    M rigs/commradio/commradio.c
    M rigs/commradio/frame.c
    M rigs/gomspace/gs100.c
    M rigs/guohetec/pmr171.c
    M rigs/guohetec/q900.c
    M rigs/icom/id5100.c
    M rigs/kenwood/ts990s.c
    M rigs/kit/dwt.c
    M rigs/kit/funcube.c
    M rigs/rs/xk852.c
    M rigs/uniden/uniden_digital.c
    M rigs/winradio/g313-posix.c
    M rigs/yaesu/ft3000.c
    M rigs/yaesu/ft736.c
    M rigs/yaesu/vr5000.c
    M rotators/grbltrk/grbltrk.c
    M src/amp_conf.c
    M src/conf.c
    M src/ext.c
    M src/extamp.c
    M src/iofunc.c
    M src/misc.c
    M src/parallel.h
    M src/rig.c
    M src/rot_conf.c
    M src/usb_port.c
    M tests/ampctl_parse.c
    M tests/memload.c
    M tests/rig_tests.c
    M tests/rigctl_parse.c
    M tests/rigmem.c
    M tests/rigtestmcastrx.c
    M tests/rotctl_parse.c

  Log Message:
  -----------
  Apply fixes suggested by iwyu

Removes unused includes and adds missing includes.


  Commit: 0267068220ad26a09497b0cd8ab5258aae0fcc09
      https://github.com/Hamlib/Hamlib/commit/0267068220ad26a09497b0cd8ab5258aae0fcc09
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M amplifiers/elecraft/kpa.h
    M amplifiers/expert/expert.h
    M amplifiers/gemini/gemini.h
    M android/ltdl.c
    M extra/gnuradio/gnuradio.h
    M extra/gnuradio/gr.c
    M extra/gnuradio/graudio.c
    M extra/gnuradio/mc4020.c
    M include/bandplan.h
    M include/hamlib/ampclass.h
    M include/hamlib/amplifier.h
    M include/hamlib/multicast.h
    M include/hamlib/rig.h
    M include/hamlib/rigclass.h
    M include/hamlib/rotator.h
    M include/hamlib/rotclass.h
    M lib/asyncpipe.c
    M lib/asyncpipe.h
    M lib/getaddrinfo.c
    M lib/getopt.c
    M lib/getopt_long.c
    M lib/gettimeofday.c
    M lib/termios.c
    M lib/usleep.c
    M rigs/adat/adat.c
    M rigs/adat/adat.h
    M rigs/alinco/alinco.c
    M rigs/alinco/alinco.h
    M rigs/alinco/dx77.c
    M rigs/alinco/dxsr8.c
    M rigs/anytone/anytone.c
    M rigs/aor/aor.h
    M rigs/aor/ar2700.c
    M rigs/aor/ar3000.c
    M rigs/aor/ar5000.c
    M rigs/aor/ar7030.c
    M rigs/aor/ar7030p_utils.c
    M rigs/aor/ar8000.c
    M rigs/aor/ar8200.c
    M rigs/aor/ar8600.c
    M rigs/aor/sr2200.c
    M rigs/barrett/4050.c
    M rigs/barrett/4100.c
    M rigs/barrett/950.c
    M rigs/barrett/barrett.c
    M rigs/codan/codan.c
    M rigs/commradio/commradio.c
    M rigs/commradio/frame.c
    M rigs/drake/drake.h
    M rigs/drake/r8.c
    M rigs/drake/r8a.c
    M rigs/drake/r8b.c
    M rigs/dummy/aclog.c
    M rigs/dummy/flrig.c
    M rigs/dummy/sdrsharp.c
    M rigs/dummy/tci1x.c
    M rigs/dummy/trxmanager.c
    M rigs/elad/fdm_duo.c
    M rigs/guohetec/guohetec.c
    M rigs/guohetec/guohetec.h
    M rigs/icmarine/icm710.c
    M rigs/icmarine/icmarine.c
    M rigs/icom/delta2.c
    M rigs/icom/frame.c
    M rigs/icom/ic7000.c
    M rigs/icom/ic7100.c
    M rigs/icom/ic7200.c
    M rigs/icom/ic7300.c
    M rigs/icom/ic735.c
    M rigs/icom/ic736.c
    M rigs/icom/ic737.c
    M rigs/icom/ic738.c
    M rigs/icom/ic7410.c
    M rigs/icom/ic746.c
    M rigs/icom/ic756.c
    M rigs/icom/ic7600.c
    M rigs/icom/ic7610.c
    M rigs/icom/ic7700.c
    M rigs/icom/ic775.c
    M rigs/icom/ic7760.c
    M rigs/icom/ic7800.c
    M rigs/icom/ic785x.c
    M rigs/icom/ic820h.c
    M rigs/icom/ic821h.c
    M rigs/icom/ic910.c
    M rigs/icom/ic9100.c
    M rigs/icom/ic970.c
    M rigs/icom/icf8101.c
    M rigs/icom/icom.c
    M rigs/icom/icom.h
    M rigs/icom/icr7000.c
    M rigs/icom/icr9000.c
    M rigs/icom/icr9500.c
    M rigs/icom/omni.c
    M rigs/icom/optoscan.c
    M rigs/icom/optoscan.h
    M rigs/icom/os456.c
    M rigs/icom/os535.c
    M rigs/icom/perseus.c
    M rigs/icom/xiegu.c
    M rigs/jrc/jrc.h
    M rigs/jrc/nrd535.c
    M rigs/jrc/nrd545.c
    M rigs/kachina/505dsp.c
    M rigs/kachina/kachina.h
    M rigs/kenwood/elecraft.h
    M rigs/kenwood/flex.h
    M rigs/kenwood/flex6xxx.c
    M rigs/kenwood/k2.c
    M rigs/kenwood/k3.c
    M rigs/kenwood/pihpsdr.c
    M rigs/kenwood/r5000.c
    M rigs/kenwood/thd7.c
    M rigs/kenwood/thf6a.c
    M rigs/kenwood/thf7.c
    M rigs/kenwood/thg71.c
    M rigs/kenwood/tmv7.c
    M rigs/kenwood/transfox.c
    M rigs/kenwood/ts2000.c
    M rigs/kenwood/ts440.c
    M rigs/kenwood/ts450s.c
    M rigs/kenwood/ts480.c
    M rigs/kenwood/ts50s.c
    M rigs/kenwood/ts570.c
    M rigs/kenwood/ts690.c
    M rigs/kenwood/ts711.c
    M rigs/kenwood/ts790.c
    M rigs/kenwood/ts811.c
    M rigs/kenwood/ts850.c
    M rigs/kenwood/ts870s.c
    M rigs/kenwood/ts890s.c
    M rigs/kenwood/ts930.c
    M rigs/kenwood/ts940.c
    M rigs/kenwood/ts950.c
    M rigs/kenwood/ts990s.c
    M rigs/kenwood/tx500.c
    M rigs/kenwood/xg3.c
    M rigs/kit/dwt.c
    M rigs/kit/elektor507.c
    M rigs/kit/fifisdr.c
    M rigs/kit/funcube.c
    M rigs/kit/kit.c
    M rigs/kit/si570avrusb.c
    M rigs/kit/usrp.c
    M rigs/kit/usrp_impl.h
    M rigs/lowe/hf235.c
    M rigs/lowe/lowe.h
    M rigs/mds/mds.c
    M rigs/mds/mds.h
    M rigs/motorola/micom.c
    M rigs/motorola/motorola.c
    M rigs/pcr/pcr100.c
    M rigs/pcr/pcr1000.c
    M rigs/pcr/pcr1500.c
    M rigs/pcr/pcr2500.c
    M rigs/prm80/prm80.h
    M rigs/racal/ra3702.c
    M rigs/racal/ra6790.c
    M rigs/rft/ekd500.c
    M rigs/rft/rft.h
    M rigs/rs/eb200.c
    M rigs/rs/ek89x.h
    M rigs/rs/esmc.c
    M rigs/rs/gp2000.h
    M rigs/rs/rs.h
    M rigs/rs/xk2100.c
    M rigs/rs/xk852.h
    M rigs/skanti/skanti.c
    M rigs/skanti/skanti.h
    M rigs/skanti/trp8000.c
    M rigs/skanti/trp8255.c
    M rigs/tapr/tapr.h
    M rigs/tentec/argonaut.c
    M rigs/tentec/jupiter.c
    M rigs/tentec/omnivii.c
    M rigs/tentec/orion.c
    M rigs/tentec/pegasus.c
    M rigs/tentec/rx320.c
    M rigs/tentec/rx350.c
    M rigs/tentec/tentec.h
    M rigs/tentec/tentec2.h
    M rigs/tentec/tt550.c
    M rigs/tentec/tt550.h
    M rigs/uniden/bc245.c
    M rigs/uniden/bc250.c
    M rigs/uniden/bc780.c
    M rigs/uniden/bc895.c
    M rigs/uniden/bc898.c
    M rigs/uniden/pro2052.c
    M rigs/uniden/uniden.h
    M rigs/winradio/g303.c
    M rigs/winradio/g305.c
    M rigs/winradio/g313-posix.c
    M rigs/winradio/g313-win.c
    M rigs/winradio/winradio.h
    M rigs/winradio/wr1000.c
    M rigs/winradio/wr1500.c
    M rigs/winradio/wr1550.c
    M rigs/winradio/wr3100.c
    M rigs/winradio/wr3150.c
    M rigs/winradio/wr3500.c
    M rigs/winradio/wr3700.c
    M rigs/wj/wj.h
    M rigs/wj/wj8888.c
    M rigs/yaesu/ft757gx.c
    M rigs/yaesu/ft897.c
    M rigs/yaesu/newcat.h
    M rigs/yaesu/vx1700.h
    M rotators/amsat/if100.c
    M rotators/apex/apex.c
    M rotators/ether6/ether6.c
    M rotators/indi/indi.c
    M rotators/indi/indi_wrapper.h
    M rotators/meade/meade.c
    M rotators/ts7400/ts7400.c
    M security/security.c
    M simulators/simelecraft.c
    M simulators/simelecraftk4.c
    M simulators/simft818.c
    M simulators/simic2730.c
    M simulators/simic275.c
    M simulators/simic7000.c
    M simulators/simic705.c
    M simulators/simic7100.c
    M simulators/simic7200.c
    M simulators/simic7300.c
    M simulators/simic7600.c
    M simulators/simic7610.c
    M simulators/simic7700.c
    M simulators/simic7851.c
    M simulators/simic905.c
    M simulators/simic910.c
    M simulators/simic9100.c
    M simulators/simic9700.c
    M simulators/simicgeneric.c
    M simulators/simicr8600.c
    M simulators/simid5100.c
    M simulators/simkenwood.c
    M simulators/simpowersdr.c
    M simulators/simqrplabs.c
    M simulators/simtmd710.c
    M simulators/simtrusdx.c
    M simulators/simts450.c
    M simulators/simts590.c
    M simulators/simts890.c
    M simulators/simts950.c
    M simulators/simts990.c
    M simulators/simxiegug90.c
    M simulators/simxiegux108g.c
    M simulators/simxiegux6100.c
    M simulators/simyaesu.c
    M src/amp_conf.c
    M src/amp_conf.h
    M src/amp_reg.c
    M src/amp_settings.c
    M src/amplifier.c
    M src/cache.h
    M src/cal.c
    M src/cal.h
    M src/cm108.c
    M src/cm108.h
    M src/conf.c
    M src/debug.c
    M src/event.c
    M src/event.h
    M src/ext.c
    M src/extamp.c
    M src/fifo.c
    M src/gpio.h
    M src/idx_builtin.h
    M src/iofunc.c
    M src/iofunc.h
    M src/locator.c
    M src/mem.c
    M src/microham.c
    M src/misc.c
    M src/misc.h
    M src/network.c
    M src/network.h
    M src/parallel.c
    M src/parallel.h
    M src/register.c
    M src/register.h
    M src/rot_conf.c
    M src/rot_conf.h
    M src/rot_ext.c
    M src/rot_reg.c
    M src/rot_settings.c
    M src/rotator.c
    M src/serial.c
    M src/serial.h
    M src/settings.c
    M src/sleep.h
    M src/snapshot_data.c
    M src/sprintflst.c
    M src/sprintflst.h
    M src/token.h
    M src/tones.c
    M src/tones.h
    M src/usb_port.c
    M src/usb_port.h
    M tests/ampctl.c
    M tests/ampctl_parse.c
    M tests/ampctl_parse.h
    M tests/ampctld.c
    M tests/cachetest.c
    M tests/cachetest2.c
    M tests/dumpcaps.c
    M tests/dumpcaps.h
    M tests/dumpcaps_amp.c
    M tests/dumpcaps_rot.c
    M tests/dumpcaps_rot.h
    M tests/dumpmem.c
    M tests/dumpstate.c
    M tests/example.c
    M tests/hamlibmodels.c
    M tests/listrigs.c
    M tests/memcsv.c
    M tests/memload.c
    M tests/memsave.c
    M tests/rig_bench.c
    M tests/rig_tests.c
    M tests/rig_tests.h
    M tests/rigctl.c
    M tests/rigctl_parse.c
    M tests/rigctl_parse.h
    M tests/rigctlcom.c
    M tests/rigctld.c
    M tests/rigctlsync.c
    M tests/rigctltcp.c
    M tests/rigfreqwalk.c
    M tests/rigmatrix.c
    M tests/rigmem.c
    M tests/rigsmtr.c
    M tests/rigswr.c
    M tests/rigtestmcast.c
    M tests/rotctl.c
    M tests/rotctl_parse.c
    M tests/rotctl_parse.h
    M tests/rotctld.c
    M tests/sendraw.c
    M tests/simple.c
    M tests/testbcd.c
    M tests/testcache.c
    M tests/testcookie.c
    M tests/testfreq.c
    M tests/testgrid.c
    M tests/testloc.c
    M tests/testmW2power.c
    M tests/testrig.c
    M tests/testrigcaps.c
    M tests/testrigopen.c
    M tests/testtrn.c

  Log Message:
  -----------
  Fix ambiguity between system includes and Hamlib includes


  Commit: 276de64d9ca0e797070926c65c98a71c98d1deee
      https://github.com/Hamlib/Hamlib/commit/276de64d9ca0e797070926c65c98a71c98d1deee
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M include/hamlib/ampclass.h
    M include/hamlib/amplifier.h
    M include/hamlib/multicast.h
    M include/hamlib/rig.h
    M include/hamlib/rigclass.h
    M include/hamlib/rotator.h
    M include/hamlib/rotclass.h

  Log Message:
  -----------
  Revert changes to quotes in the include/hamlib directory

Partially reverts commit #052cbb27 ("Fix ambiguity between system
includes and Hamlib includes") since the files in include/hamlib
are part of the public API, they must use the installed includes
when building third party applications.


  Commit: 83ba4eb27fcde29a5e47fb102f805a6c24693388
      https://github.com/Hamlib/Hamlib/commit/83ba4eb27fcde29a5e47fb102f805a6c24693388
  Author: Daniele Forsi IU5HKX <iu...@gm...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M bindings/python/test_Hamlib_class.py

  Log Message:
  -----------
  Update the tests


Compare: https://github.com/Hamlib/Hamlib/compare/4da91f1a288e...83ba4eb27fcd

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications

Re: [Hamlib-developer] [Fwd: [Hamlib/Hamlib] Run failed: C/C++ CI - master (94d7f0b)]

[Daniele F. <iu...@gm...>]

Nate wrote:

> Both the CI on Ubuntu Noble and my local run on Debian 13 fail as
> follows:
>
> >           assert expected_properties == self.actual_properties
> E           AssertionError: assert ['AMP_FLAG_1'...EVEL_PF', ...] == ['AMP_FLAG_1'...EVEL_PF', ...]
> E
> E             At index 587 diff: 'RIG_MODEL_GRAUDIO' != 'RIG_MODEL_GQRX'
> E             Right contains one more item: 'hamlib_version'

yeah, it failed also for me on PR 1808 after I changed the includes
and rebased on master, so I had to run again make -C bindings
generate-pytests

RIG_MODEL_GQRX was added in PR 1807 and markjfine reverted that change
that added it to the tests, but now that PR 1807 is merged we must add
it again

It's unfortunate that enabling the tests on the CI and adding a new
rig happened at the same time, while adding a new rig is good news, it
doesn't happen often!

-- 
73 de IU5HKX Daniele

Re: [Hamlib-developer] [Fwd: [Hamlib/Hamlib] Run failed: C/C++ CI - master (94d7f0b)]

[Nate B. <n0...@n0...>]

Both the CI on Ubuntu Noble and my local run on Debian 13 fail as
follows:

>           assert expected_properties == self.actual_properties
E           AssertionError: assert ['AMP_FLAG_1'...EVEL_PF', ...] == ['AMP_FLAG_1'...EVEL_PF', ...]
E             
E             At index 587 diff: 'RIG_MODEL_GRAUDIO' != 'RIG_MODEL_GQRX'
E             Right contains one more item: 'hamlib_version'
E             Use -v to get more diff

../../../bindings/python/test_Hamlib_class.py:1279: AssertionError
========================================================= warnings summary =========================================================


===================================================== short test summary info ======================================================
FAILED ../../../bindings/python/test_Hamlib_class.py::TestClass::test_properties - AssertionError: assert ['AMP_FLAG_1'...EVEL_PF', ...] == ['AMP_FLAG_1'...EVEL_PF', ...]
============================================= 1 failed, 8 passed, 6 warnings in 0.95s ==============================================


73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

[Hamlib-developer] [Hamlib/Hamlib] 4da91f: Use alternate quoting for older Python versions

[Michael M. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: 4da91f1a288e81132482be23c298c41ff062cfe9
      https://github.com/Hamlib/Hamlib/commit/4da91f1a288e81132482be23c298c41ff062cfe9
  Author: Michael Morgan <844...@us...>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M bindings/python/generate_tests.py

  Log Message:
  -----------
  Use alternate quoting for older Python versions

Since Python 3.12, strings such as:

f"test_{object_name.replace(".", "_")}_class.py"

are allowed but older versions require single quotes around the dot and
underscore within the double quoted string.

Should quell CI error on Ubuntu Noble.



To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications

Re: [Hamlib-developer] [Fwd: [Hamlib/Hamlib] Run failed: C/C++ CI - master (94d7f0b)]

[Nate B. <n0...@n0...>]

* On 2025 22 Jul 12:49 -0500, Daniele Forsi wrote:
> Nate wrote:
> 
> >   CCLD     _Hamlib.la
> >   File "/home/nate/git/hlb/bindings/../../hamlib/bindings/python/generate_tests.py", line 62
> >     filename = f"test_{object_name.replace(".", "_")}_class.py"
> >                                             ^
> > SyntaxError: f-string: unmatched '('
> > make: *** [Makefile:1145: generate-pytests] Error 1
> > make: Leaving directory '/home/nate/git/hlb/bindings'
> >
> > This is on Debian 12, maybe the Python is too old at 3.11.2.
> 
> yes, it needs Python 3.12+ but there is no reason to use that syntax
> 
> Michael wrote a fix, but now I see that it was reverted; Nate are you
> able to cherry-pick this?
> https://github.com/Hamlib/Hamlib/pull/1800/commits/9fe9a004aef2cf448e2f6cb35b91abaa01fdbf4f

Maybe, but it would probably be easier to just do a new commit with the
older quote syntax and credit Michael.

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

Re: [Hamlib-developer] [Fwd: [Hamlib/Hamlib] Run failed: C/C++ CI - master (94d7f0b)]

[Daniele F. <iu...@gm...>]

Nate wrote:

>   CCLD     _Hamlib.la
>   File "/home/nate/git/hlb/bindings/../../hamlib/bindings/python/generate_tests.py", line 62
>     filename = f"test_{object_name.replace(".", "_")}_class.py"
>                                             ^
> SyntaxError: f-string: unmatched '('
> make: *** [Makefile:1145: generate-pytests] Error 1
> make: Leaving directory '/home/nate/git/hlb/bindings'
>
> This is on Debian 12, maybe the Python is too old at 3.11.2.

yes, it needs Python 3.12+ but there is no reason to use that syntax

Michael wrote a fix, but now I see that it was reverted; Nate are you
able to cherry-pick this?
https://github.com/Hamlib/Hamlib/pull/1800/commits/9fe9a004aef2cf448e2f6cb35b91abaa01fdbf4f

-- 
73 de IU5HKX Daniele

Re: [Hamlib-developer] [Fwd: [Hamlib/Hamlib] Run failed: C/C++ CI - master (94d7f0b)]

[Nate B. <n0...@n0...>]

* On 2025 22 Jul 00:49 -0500, Daniele Forsi wrote:
> > I'm guessing that the RIG_MODEL_GQRX #define needs to be added.
> 
> yes, by running
> make -C bindings generate-pytests

Locally I configured with python binding enabled and ran the above
command in the build directory (I prefer out of tree builds) and get
this error:

  CCLD     _Hamlib.la
  File "/home/nate/git/hlb/bindings/../../hamlib/bindings/python/generate_tests.py", line 62
    filename = f"test_{object_name.replace(".", "_")}_class.py"
                                            ^
SyntaxError: f-string: unmatched '('
make: *** [Makefile:1145: generate-pytests] Error 1
make: Leaving directory '/home/nate/git/hlb/bindings'

This is on Debian 12, maybe the Python is too old at 3.11.2.

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

Re: [Hamlib-developer] [Hamlib/Hamlib] 41baed: Update Windows build scripts for Debian 13

[Nate B. <n0...@n0...>]

* On 2025 21 Jul 21:49 -0500, Adrian Fewster wrote:
> Nate, I thank you and the hamlib team for your great and valuable work for
> amateur radio. Also in memory of Mike Black SK, missed every day for his
> allgiving help.

Thank you on behalf of all of us that contribute to this project.

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

Re: [Hamlib-developer] [Fwd: [Hamlib/Hamlib] Run failed: C/C++ CI - master (94d7f0b)]

[Nate B. <n0...@n0...>]

* On 2025 22 Jul 00:49 -0500, Daniele Forsi wrote:
> > I'm guessing that the RIG_MODEL_GQRX #define needs to be added.
> 
> yes, by running
> make -C bindings generate-pytests

Is that part of the CI script or something that needs to be run and the
result committed and pushed?

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

Re: [Hamlib-developer] Hamlib 4.6.4 release

[Nate B. <n0...@n0...>]

* On 2025 22 Jul 02:10 -0500, Phil GM3ZZA via Hamlib-developer wrote:
> Thanks Nate.
> 
> As far as I can tell it looks good. One minor quibble, you have my call wrong
> in the PR comment. 

Fixed!

I do my best to take care to get such things correct, but occasionally
my fingers play tricks on me...

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819

Re: [Hamlib-developer] Hamlib 4.6.4 release

[Phil G. <gm...@bt...>]

<html><body><div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">Thanks Nate.</div><div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;"><br></div><div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;">As far as I can tell it looks good. One minor quibble, you have my call wrong in the PR comment.&nbsp;</div><div dir="auto" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;"><br></div><div style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;" dir="auto">73 Phil GM3ZZA</div><div id="ms-outlook-mobile-body-separator-line" dir="auto"><br></div><div id="ms-outlook-mobile-signature" style="font-family: Aptos, Aptos_MSFontService, -apple-system, Roboto, Arial, Helvetica, sans-serif; font-size: 12pt;" dir="auto">Get <a href="https://aka.ms/AAb9ysg">Outlook for Android</a></div><div dir="auto" id="mail-editor-reference-message-container"><br><hr style="display: inline-block; width: 98%;"><div id="divRplyFwdMsg" style="font-size: 11pt;" dir="auto"><b>From:</b>&nbsp;Nate Bargmann &lt;n0...@n0...&gt;<br><b>Sent:</b>&nbsp;Tuesday, July 22, 2025 12:05:24 AM<br><b>To:</b>&nbsp;ham...@li... &lt;ham...@li...&gt;<br><b>Subject:</b>&nbsp;Re: [Hamlib-developer] Hamlib 4.6.4 release<br></div><br>Hi Phil.<br><br>I have incorporated your recipe into the files as PR:<br><br>https://github.com/Hamlib/Hamlib/pull/1809<br><br>In commit:<br><br>https://github.com/Hamlib/Hamlib/pull/1809/commits/cd67bf15ce8336f819c2aa589ec0a37ee58f99eb<br><br>Let me know if I missed something.<br><br>73, Nate<br><br>--<br>"The optimist proclaims that we live in the best of all<br>possible worlds.  The pessimist fears this is true."<br>Web: https://www.n0nb.us<br>Projects: https://github.com/N0NB<br>GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819<br><br><br></div></body></html>

Re: [Hamlib-developer] [Fwd: [Hamlib/Hamlib] Run failed: C/C++ CI - master (94d7f0b)]

[Daniele F. <iu...@gm...>]

> I'm guessing that the RIG_MODEL_GQRX #define needs to be added.

yes, by running
make -C bindings generate-pytests

[Hamlib-developer] [Hamlib/Hamlib] df95e9: Update issue templates

[Nate B. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: df95e939400897bb4dcb5ac50abb5abacb7ecb99
      https://github.com/Hamlib/Hamlib/commit/df95e939400897bb4dcb5ac50abb5abacb7ecb99
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    A .github/ISSUE_TEMPLATE/bug_report.md

  Log Message:
  -----------
  Update issue templates



To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications

Re: [Hamlib-developer] [Hamlib/Hamlib] 41baed: Update Windows build scripts for Debian 13

[Adrian F. <vk...@gm...>]

Nate, I thank you and the hamlib team for your great and valuable work for
amateur radio. Also in memory of Mike Black SK, missed every day for his
allgiving help.

73

Adrian Fewster
vk4tux

On Tue, 22 July 2025, 12:27 pm Nate Bargmann via Hamlib-developer, <
ham...@li...> wrote:

>   Branch: refs/heads/master
>   Home:   https://github.com/Hamlib/Hamlib
>   Commit: 41baedf9696668cae8a99b77f93606f6d89f6645
>
> https://github.com/Hamlib/Hamlib/commit/41baedf9696668cae8a99b77f93606f6d89f6645
>   Author: Nate Bargmann <n0...@n0...>
>   Date:   2025-07-21 (Mon, 21 Jul 2025)
>
>   Changed paths:
>     M scripts/build-w32.sh
>     M scripts/build-w64.sh
>
>   Log Message:
>   -----------
>   Update Windows build scripts for Debian 13
>
>
>   Commit: fb2834afe8c01c163f5bd157170cc6e061899738
>
> https://github.com/Hamlib/Hamlib/commit/fb2834afe8c01c163f5bd157170cc6e061899738
>   Author: Nate Bargmann <n0...@n0...>
>   Date:   2025-07-21 (Mon, 21 Jul 2025)
>
>   Changed paths:
>     M scripts/build-w32.sh
>     M scripts/build-w64.sh
>
>   Log Message:
>   -----------
>   Add info about the ZIP archive directory structure
>
> Rename the lib/gcc directory to lib/gcc-mingw.
> Output the dlltool generated .lib file to lib/gcc-mingw.  This on advice
> from Jonathan Yong on the MinGW-W64 forum:
>
>
> https://sourceforge.net/p/mingw-w64/discussion/723798/thread/e23dceba20/?limit=25#51dd/3df2/3708/e62b
>
>
>   Commit: cd67bf15ce8336f819c2aa589ec0a37ee58f99eb
>
> https://github.com/Hamlib/Hamlib/commit/cd67bf15ce8336f819c2aa589ec0a37ee58f99eb
>   Author: Phillip Rose, GM3ZZA <gm...@bt...>
>   Date:   2025-07-21 (Mon, 21 Jul 2025)
>
>   Changed paths:
>     M scripts/build-w32.sh
>     M scripts/build-w64.sh
>
>   Log Message:
>   -----------
>   Windows build README updates and MSVS .lib recipe
>
> Include Phil's recipe for generating a local .lib file for MS Visual
> Studio and credit him for this commit.  Phil's original message is:
>
> https://sourceforge.net/p/hamlib/mailman/message/59208589/
>
>
> Compare:
> https://github.com/Hamlib/Hamlib/compare/94d7f0b7debd...cd67bf15ce83
>
> To unsubscribe from these emails, change your notification settings at
> https://github.com/Hamlib/Hamlib/settings/notifications
>
>
> _______________________________________________
> Hamlib-developer mailing list
> Ham...@li...
> https://lists.sourceforge.net/lists/listinfo/hamlib-developer
>

[Hamlib-developer] [Hamlib/Hamlib] 41baed: Update Windows build scripts for Debian 13

[Nate B. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: 41baedf9696668cae8a99b77f93606f6d89f6645
      https://github.com/Hamlib/Hamlib/commit/41baedf9696668cae8a99b77f93606f6d89f6645
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M scripts/build-w32.sh
    M scripts/build-w64.sh

  Log Message:
  -----------
  Update Windows build scripts for Debian 13


  Commit: fb2834afe8c01c163f5bd157170cc6e061899738
      https://github.com/Hamlib/Hamlib/commit/fb2834afe8c01c163f5bd157170cc6e061899738
  Author: Nate Bargmann <n0...@n0...>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M scripts/build-w32.sh
    M scripts/build-w64.sh

  Log Message:
  -----------
  Add info about the ZIP archive directory structure

Rename the lib/gcc directory to lib/gcc-mingw.
Output the dlltool generated .lib file to lib/gcc-mingw.  This on advice
from Jonathan Yong on the MinGW-W64 forum:

https://sourceforge.net/p/mingw-w64/discussion/723798/thread/e23dceba20/?limit=25#51dd/3df2/3708/e62b


  Commit: cd67bf15ce8336f819c2aa589ec0a37ee58f99eb
      https://github.com/Hamlib/Hamlib/commit/cd67bf15ce8336f819c2aa589ec0a37ee58f99eb
  Author: Phillip Rose, GM3ZZA <gm...@bt...>
  Date:   2025-07-21 (Mon, 21 Jul 2025)

  Changed paths:
    M scripts/build-w32.sh
    M scripts/build-w64.sh

  Log Message:
  -----------
  Windows build README updates and MSVS .lib recipe

Include Phil's recipe for generating a local .lib file for MS Visual
Studio and credit him for this commit.  Phil's original message is:

https://sourceforge.net/p/hamlib/mailman/message/59208589/


Compare: https://github.com/Hamlib/Hamlib/compare/94d7f0b7debd...cd67bf15ce83

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications

Re: [Hamlib-developer] Hamlib 4.6.4 release

[Nate B. <n0...@n0...>]

Hi Phil.

I have incorporated your recipe into the files as PR:

https://github.com/Hamlib/Hamlib/pull/1809

In commit:

https://github.com/Hamlib/Hamlib/pull/1809/commits/cd67bf15ce8336f819c2aa589ec0a37ee58f99eb

Let me know if I missed something.

73, Nate

-- 
"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."
Web: https://www.n0nb.us
Projects: https://github.com/N0NB
GPG fingerprint: 82D6 4F6B 0E67 CD41 F689 BBA6 FB2C 5130 D55A 8819