Halflife Admin Mod / Patches / #28 Huge performance increase for regexp name matching.

#28 Huge performance increase for regexp name matching.

Milestone: Stable_(S-line)

Status: open

Owner: Florian Zschocke

Labels: None

Priority: 5

Updated: 2004-08-21

Created: 2004-08-20

Creator: Solf

Private: No

Achieved through caching compiled regexp patterns.
More details at:
http://www.ozforums.com/showthread.php?p=951978#post951978

Quick fix is attached, look for the word "FIX" to locate places that were fixed.

Discussion

Solf - 2004-08-20

Compiled regexp pattern caching.

Adminmod.zip

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Florian Zschocke - 2004-08-21

assigned_to: nobody --> darope
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Florian Zschocke - 2004-08-21

Logged In: YES
user_id=169860

Looks good to me. I noticed that you also use the regexes
when matching the IP address. Did you really intend to use
regular expressions when using a user's IP in the users.ini?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Solf - 2004-08-21

Logged In: YES
user_id=1107760

Our intention was to leave logic as is, only add regexp pattern matching... So are you sure that original code works differently? I'm not the one who made changes (it was my friend), so I'm not 100% sure on the contents.
Also with this patch consider 1012734 (blocking IPs from repeatedly connecting) -- it has the same purpose -- to address performance issues.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Florian Zschocke - 2004-08-21

Logged In: YES
user_id=169860

Good point.
I was looking into adding it to the next (immanent) version
but I think it would need some more testing. So it'll have
to wait until the one after the next one.
Thanks for your submission. Very nice indeed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.