[Hackndev-commit] SF.net SVN: hackndev: [1305] linux4palm/linux/trunk/arch/arm/mach-pxa/ palmz72/palmz72.c

[<z7...@us...>]

Revision: 1305
          http://hackndev.svn.sourceforge.net/hackndev/?rev=1305&view=rev
Author:   z72ka
Date:     2007-09-12 01:23:07 -0700 (Wed, 12 Sep 2007)

Log Message:
-----------
palmz72: Enhancing backlight function and correct syntax, clear code around corgi backlight

Modified Paths:
--------------
    linux4palm/linux/trunk/arch/arm/mach-pxa/palmz72/palmz72.c

Modified: linux4palm/linux/trunk/arch/arm/mach-pxa/palmz72/palmz72.c
===================================================================
--- linux4palm/linux/trunk/arch/arm/mach-pxa/palmz72/palmz72.c	2007-09-11 09:03:13 UTC (rev 1304)
+++ linux4palm/linux/trunk/arch/arm/mach-pxa/palmz72/palmz72.c	2007-09-12 08:23:07 UTC (rev 1305)
@@ -328,22 +328,38 @@
  * Backlight *
  *************/
 
-static void palmz72_bl_on(void)
+static void palmz72_bl_power(int on)
 {
 	SET_PALMZ72_GPIO(BL_POWER, 1);
 	pxa_set_cken(CKEN0_PWM0, 1);
 	pxa_set_cken(CKEN1_PWM1, 1);
-	mdelay(50);
 }
 
-static void palmz72_bl_off(void)
+static void palmz72_set_bl_intensity(int intensity)
 {
-	SET_PALMZ72_GPIO(BL_POWER, 0);
-	pxa_set_cken(CKEN0_PWM0, 0);
-	pxa_set_cken(CKEN1_PWM1, 0);
-	mdelay(50);
+	palmz72_bl_power(intensity ? 1 : 0);
+	if(intensity) {
+	    PWM_CTRL0   = 0x3f;
+	    PWM_PERVAL0 = PALMZ72_PERIOD;
+	    PWM_PWDUTY0 = intensity;
+	}
 }
 
+static struct corgibl_machinfo palmz72_bl_machinfo = {
+	.max_intensity		= PALMZ72_MAX_INTENSITY,
+	.default_intensity	= PALMZ72_MAX_INTENSITY,
+	.set_bl_intensity	= palmz72_set_bl_intensity,
+	.limit_mask		= PALMZ72_LIMIT_MASK,
+};
+
+static struct platform_device palmz72_backlight = {
+	.name		= "corgi-bl",
+	.id		= 0,
+	.dev		= {
+		    .platform_data = &palmz72_bl_machinfo,
+	},
+};
+
 /***************
  * framebuffer *
  ***************/
@@ -410,35 +426,6 @@
 };
 #endif
 
-/* LCD backlight */
-
-static void palmz72_set_bl_intensity(int intensity)
-{
-	if(intensity) {
-		palmz72_bl_on();
-		PWM_CTRL0   = 0x3f;
-		PWM_PERVAL0 = PALMZ72_PERIOD;
-		PWM_PWDUTY0 = intensity;
-	} else {
-		palmz72_bl_off();
-	}
-}
-
-static struct corgibl_machinfo palmz72_bl_machinfo = {
-	.max_intensity		= PALMZ72_MAX_INTENSITY,
-	.default_intensity	= PALMZ72_MAX_INTENSITY,
-	.set_bl_intensity	= palmz72_set_bl_intensity,
-	.limit_mask = PALMZ72_LIMIT_MASK
-};
-
-static struct platform_device palmz72_backlight = {
-	.name		= "corgi-bl",
-	.id		= 0,
-	.dev		= {
-		    .platform_data = &palmz72_bl_machinfo,
-	},
-};
-
 static struct platform_device palmz72_ci = {
 	.name		= "pxacif",
 	.id		= -1,


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.