[Hackndev-commit] SF.net SVN: hackndev: [803] linux4palm/linux/trunk/drivers/input/keyboard

[<bal...@us...>]

Revision: 803
          http://svn.sourceforge.net/hackndev/?rev=803&view=rev
Author:   balrog-kun
Date:     2007-02-12 15:45:10 -0800 (Mon, 12 Feb 2007)

Log Message:
-----------
All: Globals are bad.  At least use "static".

Modified Paths:
--------------
    linux4palm/linux/trunk/drivers/input/keyboard/palmirkbd.c
    linux4palm/linux/trunk/drivers/input/keyboard/palmwk.c

Modified: linux4palm/linux/trunk/drivers/input/keyboard/palmirkbd.c
===================================================================
--- linux4palm/linux/trunk/drivers/input/keyboard/palmirkbd.c	2007-02-10 16:27:40 UTC (rev 802)
+++ linux4palm/linux/trunk/drivers/input/keyboard/palmirkbd.c	2007-02-12 23:45:10 UTC (rev 803)
@@ -148,11 +148,11 @@
 
 };
 
-struct input_dev *palmirkbd_dev;
-int state = STATE_OUTSIDE;
-int fn_pressed = 0;
+static struct input_dev *palmirkbd_dev;
+static int state = STATE_OUTSIDE;
+static int fn_pressed = 0;
 
-void palmirkbd_process_scancode(unsigned char data)
+static void palmirkbd_process_scancode(unsigned char data)
 {
 	int code = data & MASK_CODE;
 	int keyup = data & MASK_KEYUP;
@@ -176,7 +176,7 @@
 	if(key == KEY_RIGHTMETA) fn_pressed = !keyup;
 }
 
-void palmirkbd_process_byte(unsigned char data)
+static void palmirkbd_process_byte(unsigned char data)
 {
 	/* at any stage, c1 means end of frame */
 	if(data == EOF) {

Modified: linux4palm/linux/trunk/drivers/input/keyboard/palmwk.c
===================================================================
--- linux4palm/linux/trunk/drivers/input/keyboard/palmwk.c	2007-02-10 16:27:40 UTC (rev 802)
+++ linux4palm/linux/trunk/drivers/input/keyboard/palmwk.c	2007-02-12 23:45:10 UTC (rev 803)
@@ -150,12 +150,12 @@
 
 };
 
-struct input_dev *palmwk_dev;
-int state = STATE_OUTSIDE;
-int fn_pressed = 0;
-int fn2_pressed = 0;
+static struct input_dev *palmwk_dev;
+static int state = STATE_OUTSIDE;
+static int fn_pressed = 0;
+static int fn2_pressed = 0;
 
-void palmwk_process_scancode(unsigned char data)
+static void palmwk_process_scancode(unsigned char data)
 {
 	int code = data & MASK_CODE;
 	int keyup = data & MASK_KEYUP;
@@ -176,7 +176,7 @@
 	if(key == KEY_LEFTMETA) fn2_pressed = !keyup;		/* Green Fn key */
 }
 
-void palmwk_process_byte(unsigned char data)
+static void palmwk_process_byte(unsigned char data)
 {
 	/* at any stage, c1 means end of frame */
 	if(data == EOF) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.