Hiya, thanks for your last reply on version info changes.
We're looking to actively use this toolkit now in a project and it would be good to know how things like bugs we may come across can be handled...
As a for instance, I have found a bug in the H5Dread_var.vi - the filespace input on the front panel/connector pane is currently an i32 integer, but file spaces are 64 bit. Attempting to wire a filespace to read only part of a dataset results in an error because of this.
This is a simple bug that we could fix, but ideally we would want to fix it at the package level so that we use the same fixed version amongst all our devs. Is there a process for submitting bugs like this? Is there a way to contribute by making and submitting those fixes through some kind of pull request?
I guess the alternative would be that we make our own clone, and bring that kind of thing in-house and keep our own version of the package, but that feels less helpful and not in the spirit of using an open source package!
Thanks in advance for your thoughts.
Paul
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Paul,
Very sorry I never noticed your forum posts; I had just changed jobs in May and I guess I completely lost track of my inbox.
Thanks for reporting that issue with the datatype. Probably my preference would be to raise a ticket in SF, although it's a bit clunky. Did you end up forking in-house? Would be very happy to upstream any fixes or improvements you made, although in the past there have been issues due to my ancient LV2010 edition and my preference to continue to support older LV editions, since many universities similarly run old versions.
At one point I was going to migrate entirely to github to facilitate PRs, since SF is very oldschool and git is the defacto standard these days... What are you guys working with?
Cheers,
Martijn
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Will raise a ticket in a sec. No, we didnt fork, but ended up not using/needing that function anyways.
2010 seems surpsingly old, even for universities... We went 8.6 --> 2012 -->2017 --> and now 2021...
I think a shift of repository to one of the online git platforms would be sensible for sure (we run with git on bitbucket, but I have grabbed stuff from github and gitlab before. I did manage to clone the mercurial repo but it took a while to remember how (I actually would have preferred to stick with Hg over git in the past, but the world had other ideas!).
I'd be interested in a chat at some point if possible about a couple of things around this toolkit which might be easier in a call or direct message rather than forums, is there a way we can get in touch directly?
Thanks!
Paul
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I had another go at updating the permissions - hopefully you can create a ticket now, although I will look towards migrating to github at some point soon.
Feel free to shoot me an email to arrange a chat; m-dot-jasperse-at-gmail-dot-com. My timezone is AEST which can be awkward depending on where you are, but we can probably find something that works.
Cheers,
Martijn
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hiya, thanks for your last reply on version info changes.
We're looking to actively use this toolkit now in a project and it would be good to know how things like bugs we may come across can be handled...
As a for instance, I have found a bug in the H5Dread_var.vi - the filespace input on the front panel/connector pane is currently an i32 integer, but file spaces are 64 bit. Attempting to wire a filespace to read only part of a dataset results in an error because of this.
This is a simple bug that we could fix, but ideally we would want to fix it at the package level so that we use the same fixed version amongst all our devs. Is there a process for submitting bugs like this? Is there a way to contribute by making and submitting those fixes through some kind of pull request?
I guess the alternative would be that we make our own clone, and bring that kind of thing in-house and keep our own version of the package, but that feels less helpful and not in the spirit of using an open source package!
Thanks in advance for your thoughts.
Paul
Hi Paul,
Very sorry I never noticed your forum posts; I had just changed jobs in May and I guess I completely lost track of my inbox.
Thanks for reporting that issue with the datatype. Probably my preference would be to raise a ticket in SF, although it's a bit clunky. Did you end up forking in-house? Would be very happy to upstream any fixes or improvements you made, although in the past there have been issues due to my ancient LV2010 edition and my preference to continue to support older LV editions, since many universities similarly run old versions.
At one point I was going to migrate entirely to github to facilitate PRs, since SF is very oldschool and git is the defacto standard these days... What are you guys working with?
Cheers,
Martijn
Hi Martijn,
Will raise a ticket in a sec. No, we didnt fork, but ended up not using/needing that function anyways.
2010 seems surpsingly old, even for universities... We went 8.6 --> 2012 -->2017 --> and now 2021...
I think a shift of repository to one of the online git platforms would be sensible for sure (we run with git on bitbucket, but I have grabbed stuff from github and gitlab before. I did manage to clone the mercurial repo but it took a while to remember how (I actually would have preferred to stick with Hg over git in the past, but the world had other ideas!).
I'd be interested in a chat at some point if possible about a couple of things around this toolkit which might be easier in a call or direct message rather than forums, is there a way we can get in touch directly?
Thanks!
Paul
Actually - I dont seem to be able to raise a ticket, the button is greyed out on that page...
Thanks
Paul
I had another go at updating the permissions - hopefully you can create a ticket now, although I will look towards migrating to github at some point soon.
Feel free to shoot me an email to arrange a chat; m-dot-jasperse-at-gmail-dot-com. My timezone is AEST which can be awkward depending on where you are, but we can probably find something that works.
Cheers,
Martijn