Issues with remove and add

[Babar]

I came across issues where I had to remove a panel that contains the uploader and add again it again. It appears that swfUpload.destroy() method does not remove the object element from the DOM. As the object is created on onLoad(). Each time container is added to dom tree, its called and hence a new object element is created. Same is the case with html5 label. So I had to modify it onUnload() as follows

protected void onUnload() {
    if (swfUpload != null) {
        nativeSWFUploadDestroy(swfUpload);
        ObjectElement oe = findObjectElement();
        if(oe != null){
            oe.removeFromParent();
        }
        swfUpload = null;
    }else{
        remove(button);
        remove(fileUpload);

        button = null;
        fileUpload = null;
    }
    buttonTextStyleElement = null;
    buttonTextElement = null;
    buttonImageElement = null;
}

[Shawn Quinn]

Thanks for this! Agreed that this logic should be improved. Can you attach a more complete version of the "Uploader.java" file that you're using? Looks like you've made some other changes in order to support this new onUnload() method, so I'd like to take a look at the whole thing - and then I can merge the appropriate changes into the repository so that this enhancement is included in the next release.