Re: [Gwt-openlayers-devl] [Gwt-openlayers-users] Popup CloseListener

[Edwin C. <com...@gm...>]

Hi Mårten,

Your contributions just hit the trunk :)

I also deprecate the addCloseListener method as it was fiddling with a
private method in OL.

Greetings and thanks,
Edwin

On 6 October 2010 16:16, Mårten Karlberg <mar...@di...> wrote:
> Hi Edwin!
>
> Here are the files I changed. I've tested the code in Firefox. It seems to
> work fine except for the Framed-class which does not produce a popup at all.
> No matter if I use the old constructor or the new constructor with the
> CloseListener callback. We don't use the Framed-class so I won't spend any
> more time on debugging it. I'm not sure if it worked before my changes
> either.
>
> Regards
> Mårten Karlberg, Digpro Solutions AB
>
> 2010/10/6 Edwin Commandeur <com...@gm...>
>>
>> Hi Marten,
>>
>> Good to hear you solved the popup problem. I would definitely be
>> interested in that code :). I have never really used the popups that
>> come with OpenLayers (used Ext GWT windows instead), so I never looked
>> at closely how GWT-OL wraps them.
>>
>> Greetings,
>> Edwin
>>
>> On 6 October 2010 12:07, Mårten Karlberg <mar...@di...>
>> wrote:
>> > I solved this. All Popup-classes are implemented in a strange way, not
>> > following the JavaScript-constructors of OpenLayers. What is the reason
>> > for
>> > doing it like this? Anyway, I added constructors that take the
>> > CloseListener
>> > and binds it to the closeBox at creation of the popups. That's the way
>> > OpenLayers does it and that's the way I think openlayers-gwt should do
>> > it
>> > too. I didn't remove the original openlayers-gwt constructors or the
>> > addCloseListener-function in Popup for back compatibility issues.
>> >
>> > Are you interested in this code?
>> >
>> > Regards
>> > Mårten Karlberg, Digpro Solutions AB
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > Beautiful is writing same markup. Internet Explorer 9 supports
>> > standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
>> > Spend less time writing and  rewriting code and more time creating great
>> > experiences on the web. Be a part of the beta today.
>> > http://p.sf.net/sfu/beautyoftheweb
>> > _______________________________________________
>> > Gwt-openlayers-users mailing list
>> > Gwt...@li...
>> > https://lists.sourceforge.net/lists/listinfo/gwt-openlayers-users
>> >
>> >
>
>