Re: [Gwt-openlayers-devl] modification for setting multiple WMS urls

[Curtis <je...@us...>]

Sorry for taking a while to reply.
Yes, I agree, the "Options" constructors can and should go away now
that we have your new Options getters/setters.

--
Curtis

On Sun, Mar 29, 2009 at 2:58 AM, Edwin Commandeur
<com...@gm...> wrote:
> Hi Curtis,
>
> I think your solution with the extra constructors with String[] urls is
> indeed the best solution.
>
> I saw that OpenLayers it is also arranged in the constructor: The url
> parameter (the 2nd parameter in WMS constructor) can be single url or an
> urlArray.
> http://trac.openlayers.org/wiki/OpenLayersOptimization
>
> WMS has six constructors now, but two of them with Options as argument are
> now obsolete with the changes to empower JSObject with getters/setters for
> properties. So that would leave the nice number of four constructors for the
> eventual 0.4 release I would say.
>
> Greetings,
> Edwin Commandeur
>
> P.S.
> For people that want to set custom properties on WMSLayerOptions they can
> do:
> WMSLayerOptions wmsLayerOptions = new WMSLayerOptions();
> wmsLayerOptions.getJSObject().setProperty(...); //getJSObject route will
> eventually work on any GWT-OL object :-)...
>
> Instead of passing an Options object
> Options options = new Options();
> options.setAttribute(...);
>
>
> 2009/3/29 Curtis Jensen <cu...@th...>
>>
>> Hi Edwin,
>>
>> The import was left over from some of my experimenting.  Thanks for
>> cleaning it up.  JStringArray is only used in WMS.java.  I think it
>> can be done without the JStringArray class, but it is left in there
>> because I know it works that way.
>>
>> --
>> Curtis
>>
>> On Sat, Mar 28, 2009 at 10:04 AM, Edwin Commandeur
>> <com...@gm...> wrote:
>> > Hi Curtis,
>> >
>> > Is it possible that not all changes for setting multiple WMS urls were
>> > committed. I saw a JStringArray, which is imported in WMSImpl but never
>> > used
>> > there.
>> >
>> > I cleaned up the unused import for now. Possibly some stuff failed to be
>> > committed. I was expecting a method on the WMS or in WMSOptions (I
>> > renamed
>> > WMSParams, so Options is now consistently used versus params).
>> >
>> > Greetings,
>> > Edwin
>> >
>
>