Re: [Gwt-openlayers-devl] [Patch Review Request] Make mapOptions.setAttribute methods public

[Edwin C. <com...@gm...>]

Hi Curtis,

I haven't been at my laptop that is set up for programming, but I saw from
the CVS that you did not commit the modifications to the CVS.

It is confusing in the current situation as there is an Options object and
an OptionsBase object. The latter I have introduced to hide setAttribute
methods for specific Options objects. I will think about how we can make
this less confusing and make the Options objects more powerful. The simplest
possibility is to remove OptionsBase and let Options objects extend Options.

Are you using GWT-OpenLayers with plain GWT widgets?

I am using GWT-OpenLayers with plain GWT widgets for the showcase and with
Ext-GWT for several applications but I have never experience the Z-Index
problem you are describing.

The MapWidget is very minimalistic. It only creates a div which OpenLayers
can use to put the map in. The MapWidget itself does not do anything with
z-indexes of that div, that is all OpenLayers. Possibly the problem is also
solved if you create a div within the Panel you are using and let the
MapWidget use that div. Currently this is not possible, but there is some
commented out code in MapWidget that you can uncomment to test if this works
in principle.

Greetings,
Edwin

P.S.




2009/3/23 Curtis Jensen <cur...@gm...>

> Hello,
>
> Sorry I haven't jumped in earlier.  Me and the family got sick (I
> still am).  I hate winter.
>
> I had forgotten that I did modify the source to expose the the
> setAttribute methods.
>
> Yes, it would be nice for me to have a setZIndexBase method.  I kinda
> would like the setAttribute method exposed too for the advanced needs.
>  If something comes up other than ZIndex or if ZIndex accessors are
> never added, how else would we set the properties that aren't
> explicitly in the API?
>
> Does anyone else have a problem with the OpenLayers map being hid by
> other widgets?  Or the map hiding other widgets?
> If I create a popup panel, the map will be above the popup panel and I
> can't see the popup.  This only happens in Firefox.  IE puts the popup
> on top of the map.  After looking at the zIndexes of the widgets, I
> think that the map should cover the popup panel.  Even though I want
> the popup on top, it is incorrect to render it on top.
>
> --
> Curtis
>
>
>
> On Mon, Mar 23, 2009 at 6:05 AM, Edwin Commandeur
> <com...@gm...> wrote:
> > Hi Farrukh,
> >
> > I will be adding the getter and setter for setZIndexBase().
> >
> > It does bug me a bit that the options objects don't have a setProperty
> > method for advanced users who want to set properties not yet supported by
> > the API. I will try to come up with a single method that allows setting
> > properties of multiple types. At present I am thinking of sth like:
> >
> > setProperty(String name, PropertyValue value)
> >
> > Where PropertyValue can be of different types.
> >
> > Greetings,
> > Edwin
> >
> > 2009/3/23 Farrukh Najmi <fa...@we...>
> >>
> >> Farrukh Najmi wrote:
> >>>
> >>> Edwin Commandeur wrote:
> >>>
> >>>>
> >>>> Hi Farrukh,
> >>>>
> >>>> MapOptions extends OptionsBase, which intentionally hides the
> >>>> setAttribute methods for non-children (see the Javadoc on
> OptionsBase). The
> >>>> idea behind this is that XxxOptions objects should only have setters
> for
> >>>> options that can actually be set on them. Also the setAttribute
> methods
> >>>> clutter the code suggestions by the IDE for the available setters
> (another
> >>>> option to prevent code suggestion clutter would be to have a
> IMapOptions
> >>>> interface with limited setters and let that be extended by a
> MapOptions
> >>>> class that extends Options).
> >>>>
> >>>> If it makes sense to support setting the Z-Index I would argue that
> >>>> there should be a public setZIndex method, but if others feel that it
> makes
> >>>> more sense to expose the setAttribute methods than we should consider
> making
> >>>> all classes that extend OptionsBase extend Options instead (as in
> GWT-OL
> >>>> 0.2).
> >>>>
> >>>>
> >>>
> >>> Hi Edwin,
> >>>
> >>> I agree with your rationale.
> >>>
> >>> +1 on adding setZIndex(int zIndex) and getZIndex() methods.
> >>>
> >>> I think it would be better if you could do it as you are more familiar
> >>> with code base.
> >>>
> >>> Please let me know if I can help. When its committed I will test it
> out.
> >>> Thanks.
> >>>
> >>>
> >>
> >> Actually, perhaps the methods should be get/setZIndexBase() since they
> >> wouldset the base for a set of zindexes.
> >>
> >> --
> >> Regards,
> >> Farrukh
> >>
> >> Web: http://www.wellfleetsoftware.com
> >>
> >>
> >
> >
> >
> ------------------------------------------------------------------------------
> > Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
> > powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
> > easily build your RIAs with Flex Builder, the Eclipse(TM)based
> development
> > software that enables intelligent coding and step-through debugging.
> > Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> > _______________________________________________
> > Gwt-openlayers-devl mailing list
> > Gwt...@li...
> > https://lists.sourceforge.net/lists/listinfo/gwt-openlayers-devl
> >
> >
>