Re: [Gwt-openlayers-devl] [Patch Review Request] Make mapOptions.setAttribute methods public

[Farrukh N. <fa...@we...>]

Farrukh Najmi wrote:
> Edwin Commandeur wrote:
>   
>> Hi Farrukh,
>>
>> MapOptions extends OptionsBase, which intentionally hides the 
>> setAttribute methods for non-children (see the Javadoc on 
>> OptionsBase). The idea behind this is that XxxOptions objects should 
>> only have setters for options that can actually be set on them. Also 
>> the setAttribute methods clutter the code suggestions by the IDE for 
>> the available setters (another option to prevent code suggestion 
>> clutter would be to have a IMapOptions interface with limited setters 
>> and let that be extended by a MapOptions class that extends Options).
>>
>> If it makes sense to support setting the Z-Index I would argue that 
>> there should be a public setZIndex method, but if others feel that it 
>> makes more sense to expose the setAttribute methods than we should 
>> consider making all classes that extend OptionsBase extend Options 
>> instead (as in GWT-OL 0.2).
>>
>>     
>
> Hi Edwin,
>
> I agree with your rationale.
>
> +1 on adding setZIndex(int zIndex) and getZIndex() methods.
>
> I think it would be better if you could do it as you are more familiar 
> with code base.
>
> Please let me know if I can help. When its committed I will test it out. 
> Thanks.
>
>   
Actually, perhaps the methods should be get/setZIndexBase() since they 
wouldset the base for a set of zindexes.

-- 
Regards,
Farrukh

Web: http://www.wellfleetsoftware.com