From: Elisabetta M. <man...@pc...> - 2003-03-19 00:25:28
|
Hi all, this is to let you know that I've applied the changes proposed below and also that I've added a couple more lines which this plugin will print to STDOUT (when the plugin does not exit on error). These lines start respectively with "INSERTED (non-overhead)" and "UPDATED (non-overhead)" and denote the number of inserted (resp. updated) objects, without counting the overhead ones (e.g. AlgorithmInvocation etc.). I've cvs committed the plugin. Elisabetta On Tue, 18 Mar 2003, steve fischer wrote: > folks- > > elisabetta and i have discovered a suspicious line of code in > UpdateGusFromXML: > > ##testing exitOnFailure... > $self->getDb()->setExitOnSQLFailure(0); > > this will cause the plugin to continue processing the xml file even > after one of the included transactions fails and rollsback. > > if somebody wants this behavior then this should be made into a command > line option. > > otherwise, unless somebody can provide reaons otherwise, we are going to > remove that line of code, forcing the parse of XML to die if there is a > problem so that the user of the plugin will be aware of and correct the > problem. > > steve > -- Elisabetta Manduchi Computational Biology and Informatics Laboratory Center for Bioinformatics University of Pennsylvania 1428 Blockley Hall 423 Guardian Drive Philadelphia, PA 19104-6021 phone: 215-573-4408 fax: 215 573-3111 email: man...@pc... web: http://www.cbil.upenn.edu/~manduchi --- |