Menu

#12 RandomTestCase improperly generates starting states

open
nobody
None
5
2009-12-17
2009-12-17
S Huang
No

In edu.umd.cs.guitar.testcase.plugin.RandomTestCase:
generate(): Initial event is *not* chosen from the set of initial events,
rather from the entire list of events. Pertinent code is:

List<Integer> initialEvents = getInitialEvent();
List<EventType> eventList = efg.getEvents().getEvent();

...

Integer currentStep = randomGenerator.nextInt(initialEvents.size());
LinkedList<EventType> sequence = new LinkedList<EventType>();
// Intial event
sequence.add(eventList.get(currentStep));

getNextRandomStep(): Boolean check is opposite of what it should be. Pertinent code is:

for (int i = 0; i < allEvents.size(); i++) {
if (allEvents.get(i) == GUITARConstants.NO_EDGE) {
followingEvents.add(i);
}
}

should check for the edge type to be anything *but* a NO_EDGE.

Discussion


Log in to post a comment.

MongoDB Logo MongoDB