[Guidolib-devel] Code Changes

[J. S. A. <js...@sh...>]

Hi All,

I've made a few changes to the score engine code (a followup to the
previous code reorganization messages), and I thought I would check with
everyone before committing anything.  I've fixed up the linux autotools
and added a version checking m4 macro.  To support this macro, I've
moved the version info from nview.h to GUIDOEngine.h and added two new
version checking API functions - GuidoGetVersionNums, which returns the
version number in three separate ints (the original GuidoGetVersionNum
is still available); and GuidoCheckVersionNums, which checks the engine
version number against an input (i.e. to make sure the library is of a
sufficient revision).  After looking at the remaining items in nview.h,
it seemed to make sense to take the remaining elements out of that file
and deprecate it.  I took all of the external settings variables (i.e.
gDisplaySprings, gDisplayForce, etc.) and moved them into a struct
within GUIDOEngine.h, and then provided a gGlobalSettings variable with
default values.  The same was done with the remaining font variables
(gFontScriab, gFontText, kDefaultMusicFont, kDefaultTextFont), put into
GDeviceDefs.h in a gFontDefs struct.  It seemed a little cleaner this
way, and better organized.  Also, the linux compile now ignores
naguido.h and naguido.cpp (which fixes the earlier unresolved symbol
problem).  I've tested it on both my linux and windows system here, and
everything compiles fine.

I also had a question about version numbering.  What guidelines do you
have for bumping the sub component of the version (i.e 1.2.x)?  Should I
increase it to 1.2.1 due to the above changes (assuming they are ok with
everyone)?

Finally, I'm going to firm things up with Holger, but it seems that the
suggestion to do the GGS implementation through the VGDevice mechanism
is a good one.  It would allow for the removal of the internal GGS
functions (AddGGSOutput, etc.) and maintain a consistent graphic
implementation for the score engine.  Does anyone use the currently
existing GGS routines?

Cheers,

Scott