Re: [Guidolib-devel] Problems fixed when opening some gmn

[Dominique F. <fo...@gr...>]

Hi,

Thanks a lot for pointing out the problems.  There was actually a real  
problem with ScoreSymbolMap.cpp and with the gmn file.
They have been corrected but I didn't used your patch for several  
reasons:
- first, you have to know that the guidolib developments have switched  
to svn for a couple of weeks. Use definitely the svn repository for up- 
to-date source code. The cvs repository is available only for  
historical reasons (I mean, to keep the development history).
- next and concerning the ScoreSymbolMap problem, it has been  
corrected but using a slightly more efficient solution
- finally concerning the crash bug, it cames from empty \tagBegin  
\tagEnd forms i.e. range tags without content. Your proposed solution  
didn't worked on my side. The solution was somewhere else, at AR to GR  
conversion level: now, the corresponding GR tags are not created  
(anyway it doesn't make sense for empty range tags).
All the corrections have been committed on sourceforge to svn.

Best regards,
--
Dominique




Le 25 sept. 08 à 21:43, Mathieu Labbé a écrit :

> Hello,
> I'm developping a program like the GuidoQtViewer application. I  
> found the GuidoLib very useful. It draws scoresheet very well but I  
> had some problems when opening differents gmn (some are generated  
> with MusicXML2Guido from the MusicXML librairy). I had the same bugs  
> with the original GuidoQtViewer. The application crashed each time I  
> opened almost all of my gmn files. So I found problems in the code  
> and I fixed them. I attached to this message the patch and a gmn  
> file to test with.
>
> Configuration:
> Windows XP
> Microsoft Visual Studio 2005
> Last CVS version, compiled from source using win32 projects
> GuidoQtViewer compiled using qmake and nmake
>
> Bugs information :
> **
> File : lib-score-engine-add/ScoreSymbolMap.cpp
>
> There was a crashed when iterating the 'childs' vector. When erasing  
> a child, the program crashed when "--ptr" is done.
>
> **
> File : lib-score-engine/abstract/ARPositionTag.h
>
> I don't know for what it is used, but what I know is that when a  
> correspondance tag is deleted, his parent didn't know it, so the  
> parent had a bad reference (bad pointer). I had the  
> "mParentCorrespondence" attribute. When a child referenced by  
> another tag is deleted, in his destructor it will set his reference  
> in the parent to null. The crash happened when getCorrespondence()  
> is called with the mPositionTag referenced deleted memory.
>
> Hope that could be in the next version. Thx for this great library.
>
> Mathieu Labbé
>
>
>
> < 
> BeetAnGeSample 
> .gmn 
> > 
> < 
> guidolib 
> .patch 
> > 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's  
> challenge
> Build the coolest Linux based applications with Moblin SDK & win  
> great prizes
> Grand prize is a trip for two to an Open Source event anywhere in  
> the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________
> Guidolib-devel mailing list
> Gui...@li...
> https://lists.sourceforge.net/lists/listinfo/guidolib-devel