#18 Incorrect variable in gtkspell/Makefile.am

None
closed
nobody
None
1
2013-05-13
2013-05-13
John Ralls
No

gtkspell/Makefile.am contains variable references of the form @GTK_SPELL2_LIBS@. That's wrong, it should be $(GTK_SPELL2_LIBS). @foo@ syntax is used in Makefile.in by configure to populate the values of variables declared in AC_SUBST. It should be used in Makefile.am only in the context of an action involving sed.

Attached patch fixes this plus a typo (GTK_SPELL_CFLAGS when you meant GTK_SPELL3_CFLAGS).

1 Attachments

Discussion

  • John Ralls

    John Ralls - 2013-05-13

    Sorry, bad patch. Please use this one instead.

     
  • Sandro Mani

    Sandro Mani - 2013-05-13
    • status: open --> closed
    • Group: -->
     
  • John Ralls

    John Ralls - 2013-05-13

    Sandro,

    No, that only fixes the typo. The major error is using @GTK_SPELL3_CFLAGS@ instead of $(GTK_SPELL3_CFLAGS). It might have gotten through on older versions of automake, but with automake-13 it's passed verbatim into Makefile where make doesn't know what to do with it.

    See http://www.gnu.org/software/automake/manual/html_node/Canonicalization.html#Canonicalization -- in particular, the last line.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks