#16 GTK3

None
closed
None
5
2014-08-25
2011-05-06
John Ralls
No

There's a super-simple patch to make GtkSpell work with Gtk3 which was submitted to RedHat [1] in February. Perhaps someone could commit it here and make a new tarball...

[1] https://bugzilla.redhat.com/show_bug.cgi?id=675504

Discussion

<< < 1 .. 9 10 11 12 > >> (Page 11 of 12)
  • Daniel Atallah

    Daniel Atallah - 2012-10-17

    I would be one of the potential users of a gtk2 version of gtkspell3.

    In the interest of getting this done and released finally (and because I'm not volunteering to fix it :)), I'm fine with making this branch gtk3 only and then later we still have the option of making gtk2 branch. I think such a branch wouldn't be a gtkspell2-3.0, but rather gtkspell3-gtk2 similar to what the original plan was to do with the current branch - the API would be the gtkspell3 api.

     
  • Sandro Mani

    Sandro Mani - 2012-10-17

    After playing around a while I think I've found a solution which is elegant enough (the only ugly part are some GTK_MAJOR_VERSION macro conditionals in the examples to decide whether to use gtk_box_new or gtk_{h/v}box_new). I've pushed the corresponding changes to head. From my testing, everything works correctly, though clearly it would be great if someone else could test as well :) I'd say this time we are really good to go. Daniel, to you want to tag the release and create the tarball? (I usually just run make dist-xz for that)

     
  • Sandro Mani

    Sandro Mani - 2012-10-28

    I've created the gtkspell_3_0_0 tag in the repository, and the archive I would release is here [1]. Daniel, if you find some time to quickly double check things I would appreciate it. Also, if you want the archive to have a signature, I guess you should do that, since I assume you have the respective keys?

    [1] http://n.ethz.ch/~smani/download/gtkspell3-3.0.0.tar.xz

     
  • Daniel Atallah

    Daniel Atallah - 2012-10-31

    Sorry, the SF.net update got my email filtering messed up, so I didn't notice the latest updates until I looked in my SF spam folder.

    I just updated the translations.

    I was going to tag again, and build and sign the release tarball, but I'm not able to run a distcheck or generate a dist file because of a gtk-doc issue:

    make[2]: Entering directory `/home/datallah/dev/gtkspell-code/docs'
    *** gtk-doc must be installed and enabled in order to make dist
    

    I do have gtk-doc 1.18 and have explicitly specified --enable-gtk-doc to ./configure (this is on Ubuntu 12.04), and according to the configure output gtk-doc should be enabled:

    checking for gtkdoc-check... /usr/bin/gtkdoc-check
    checking for gtkdoc-rebase... /usr/bin/gtkdoc-rebase
    checking for gtkdoc-mkpdf... /usr/bin/gtkdoc-mkpdf
    checking for GTKDOC_DEPS... yes
    checking whether to build gtk-doc documentation... yes
    

    It's possible that this is some sort of misconfiguration on my end, but I don't see anything wrong here and I haven't had issues using gtkdoc for other stuff.

     
  • Sandro Mani

    Sandro Mani - 2012-10-31

    The error would be because make distcheck does not pass --enable-gtk-doc when it runs configure, so we either should enable gtk-doc by default or add --enable-gtk-doc to DISTCHECK_CONFIGURE_FLAGS in the toplevel Makefile.am. I've pushed a commit with the latter change, and also fixed top_builddir to top_srcdir in the CPPFLAGS in example/Makefile.am. Give it a try, should work now!

     
  • Daniel Atallah

    Daniel Atallah - 2012-11-01

    There's still something not right - being able to run a dist or distcheck doesn't work out of the box - it looks like it's still trying to do stuff based on how it's configured already instead of based on the distcheck configure.

    Starting from a clean working dir (hg purge --all):

    ./autogen.sh
    make distcheck
      DOC   Introspecting gobjects
    libtool: link: cannot find the library `../gtkspell/libgtkspell3-3.la' or unhandled argument `../gtkspell/libgtkspell3-3.la'
    

    If I run a make before make distcheck the introspection succeeds, but then I get the same message about gtk-doc:

    make[2]: Entering directory `/home/datallah/dev/gtkspell-code/docs'
    *** gtk-doc must be installed and enabled in order to make dist
    

    If I configure using ./autogen.sh --enable-gtk-doc, then run make before running make distcheck it gets further and then actually runs the configure for the dist and the distcheck succeeds.

    I also see one error in the make dist output - shouldn't this cause the whole process to fail?:

    make[2]: Entering directory `/home/datallah/dev/gtkspell-code/docs'
    cp: cannot stat `./gtkspell3.pdf': No such file or directory
    make[2]: [dist-hook] Error 1 (ignored)
    
     
  • Sandro Mani

    Sandro Mani - 2012-11-01

    Uhm, so the the problem is the

    CFLAGS and LDFLAGS for compiling gtkdoc-scangobj with your library.

    Only needed if you are using gtkdoc-scangobj to dynamically query widget

    signals and properties.

    section in the docs/Makefile.am, where I pass $(top_builddir)/gtkspell/libgtkspell3-3.la to the GTKDOC_LIBS. This obviously only works if the gtkspell library is compiled before. If one wants make dist to complete without a previous make, I'm not really sure how one ought to fix this? (Except disabling gtk-scangobj?). As far as the pdf is concerned, I can't see any way I can influence that in the docs/Makefile.am...

     
  • Sandro Mani

    Sandro Mani - 2012-11-06

    I've looked at other projects to see how they handled the situation: they handle it the same way, i.e. make needs to be called before make dist / make distcheck. So I'd say it's fine if we left things as they are now, and release the tarball.

     
  • Sandro Mani

    Sandro Mani - 2012-11-14

    Great, thanks!

     
<< < 1 .. 9 10 11 12 > >> (Page 11 of 12)

Log in to post a comment.