Menu
▾
▴
#21 new sorting in coverart
I want "The Cure" to appear before "Devo" in gtkpod (just as it does on my ipod), so I added the word "the" to the list of words at
Edit|EditPreferences|Display|Misc|
AdvancedSortingOptions|IgnoreFrequentWords ,
and made sure "Artist" was checked just below. Things worked swell for the sort tabs, but the coverart ("Album Art") display was unaffected. This patch fixes that. Now gtkpod's "Album Art" order matches that in my nano3g's "Cover Flow".
Logged In: YES
user_id=646626
Originator: NO
This patch has some issues:
- the compare function is already used before both albums are in the hash -- sorting is therefore random at best.
- it's also used to locate a track that has been removed or changed. In these cases a 1:1 comaprison is necessary.
- for sorting, the comparision should be done completely identically to the sorttab sorting to avoid confusion, I believe.
Please take some time to go over your patch once more. In principle I'd like to accept it, but it's not ready yet.
Cheers,
JCS.
2nd attempt at adding fuzzy sorting to the coverart display
Logged In: YES
user_id=1712311
Originator: YES
Hopefully I'm getting closer. :-)
- I understand about entries not being in the hash; it now compares just the passed-in keys
- I didn't follow the track comparison issue, so please elaborate if the new code still has problems here
- (I think) it now works just like sorrtab in that it hits the user prefs & avoids g_ascii_strcasecmp
It's disconcerting to see "Dreams So Real" sorted before "Dream Syndicate", but after reading http://unicode.org/reports/tr10/ , it seems that's intentional. My ipod sorts the same way, so at least it's consistent.
File Added: coverart_fuzzy_sort_2.diff
Anything I can do to help get this rolled in? I've been exercising the patch for several months without any problems. (I ask because I just installed ubuntu intrepid & need to reinstall the changes locally.) Thanks! :-)