Re: [Gtkpod-devel] diff for the buttons I added on weekend

[Jorg S. <Jor...@gm...>]

Hi Marcelo,

I've finally found time to look at your patch.

I think the "Next" button should actually select and play the next
track, not just select it. The buttons should be on the right side,  not
the left. "//" cannot be used to indicate comments, use "/*...*/"
instead. The patch should address the prev/next/play buttons only, not
the cell edit feature -- I'm trying to think of something else.

If you send a revised patch I think I will submit it to CVS.

Cheers,


JCS.


Marcelo Varanda wrote:
> - The current Play Button in my patch does the same then Play cmd in 
> Context menu;
> 
> - "Next" >>, selects next track  (from latest selected row);
> 
> - "Prev"<< , selects prv. track (from latest selected row);
> 
> The << and >>buttons do not interact with playlist in progress.
> 
> If you have chance apply the patch and play with those cmds a bit.
> Cheers,
> 
> 
> */Jorg Schuler <Jor...@gm...>/* wrote:
> 
>     Marcelo Varanda wrote:
>      > "The Next/Prev buttons should actually play the next/Prev entry, I
>      > would think."
>      >
>      > I am thinking that it might be better just leave the "Play" button
>      > (remove Next/Prev as it might be confusing).
> 
>     Sorry, now I'm confused. What good should the Play button alone do? It
>     wouldn't even be clear what it would play (selected playlist, tab
>     entry,
>     track(s)? Then I'd definitely prefer the context menu.
> 
>     A quick way to listen to the selected tracks and move forward/backward
>     from within gtkpod would certainly be convenient.
> 
>     JCS.