Re: [Gtkpod-devel] lgtkpod segfaults on corrupt DeviceInfo file

[Jorg S. <Jor...@gm...>]

Hi Josef,

between the last release and the current version in CVS we have removed
ipod-device.c completely and replaced it with new code (itdb_device.c).

Since sourceforge CVS seems to be more or less down, Christophe has placed a
snapshot of his working directory at

http://cfergeau.free.fr/hack/libgpod-cvs.tar.gz

You should try if that solves the problem.

Cheers,


JCS.

On Sat, Apr 22, 2006 at 01:58:23AM -0800, Jozef Kruger wrote:
> Hi,
> 
> apparently, the DeviceInfo file on my ipod is corrupt. When I start gtkpod, 
> it tries to read it and then crashes.
> The bug is in the function ipod_device_read_sysinfo (libgpod/ipod-device.c).
> When the file is corrupt, the array field_values remains uninitialized. 
> When the function sysinfo_arr_get_dup is called, it ends up calling strdup 
> on an uninitialized string.
> 
> I added an array of booleans to keep track of which field_value has been 
> found in the DeviceInfo file and which hasn't. I then use those booleans to 
> check if the file was corrupt or not, if so I print an error.
> The thing is that after I return FALSE from that function in case of an 
> error, everything works smoothly, I can upload songs to my ipod and 
> everything.
> 
> Anyway, I'm new to libgpod/gtkpod and gnome in general, so tell me if you 
> want my patch or not.
> 
> Thanks for your time!
> Jozef Kruger (the Netherlands)