Re: [Gtkpod-devel] [gtpd-cvs] [gtkpod] Fixes some selection errors when removing tracks

[Christophe F. <te...@gn...>]

2010/9/2 phantomjinx <pha...@us...>:
> commit 5e37b60d66894b76b7fe440d4d05a6e5250d0a35
> +    if (!player->tracks || g_list_length(player->tracks) == 0)
> +        return;
> +

Both tests are equivalent, and calling g_list_length just to check it
against 0 is costly and wasteful on large collections.

>
> +    if (!player->tracks || g_list_length(player->tracks) == 0)
> +        return;
> +

Ditto


Christophe