Re: [Gtkpod-devel] iphoto Thumbs file size inconsistency

[Francesco Z. <fra...@gm...>]

On Fri, Apr 25, 2008 at 3:29 AM, Jacob Hoffman-Andrews <js...@ne...> wrote:
>  I've been working on some code to do this same cropping in libgpod
>  (NOTE: does not work yet.  Attached only in case you want to play
>  around with it).
I hope I'll have some time to play with it...

>  >  2) the icons from iTunes is somehow smaller than 56x55 size giving a nicer
>  >      border effect when listing them.
>
>  In itdb_device.c, we have:
>
>  static const Itdb_ArtworkFormat ipod_touch_1_artwork_info[] = {
>   ...
>
>       {ITDB_THUMB_PHOTO_SMALL,       56,  55, 3004,
>  THUMB_FORMAT_RGB555_LE, 8192},
>
>  This seems wrong.  Why would the width be greater than the height by
>  one pixel?  Further, dumping my existing iTunes-synced photos using
>  libgpod's "test-photos dump", all of the small icons that come from
>  the phone are exactly 55x55.  My guess is that this extra pixel of
>  width is the result of a misinterpretation of PNG's filter byte at the
>  beginning of each line
>
>  Unfortunately, changing '56' to '55' doesn't appear to make my
>  attached patch work.  Will keep hacking...
I've also played around with sizes when I was trying to get the "white borders"
and noticed that NOT all sizes are ok...


>  >  3) the icon from iTunes has a small light-blu line to frame it
>
>  I can't see this light blue line when I look closely.  I suspect it is
>  a visual artifact.
I can see it very clearly on the 75x75 thumbs (dumped via testphoto).
This probably teaches us also another lesson, i.e. the itouch photo viewer
uses the 75x75 thumb when showing photo collections.


Francesco