From: phantomjinx <p.g...@ph...> - 2010-12-12 21:51:03
|
Evening all, I would like to head towards a release of gtkpod2 by the end of the month so would people mind taking it for a spin if not already and let me know problems, gripes, annoyances and other little bugs that they would prefer to see fixed prior to this release please. In addition, anyone willing to give their time over to translations would be more than appreciated. If you do not want to compile it yourself then there are unstable rpm (fedora 13+) and deb (ubuntu maverick) builds on sourceforge: http://sourceforge.net/projects/gtkpod/files/gtkpod/gtkpod-2.0.0-unstable/20101211/ Latest things included: - Converting videos to ipod spec mp4s, using ffmpeg, so in theory most videe types should work - Sorting playlists Once again, if people would like to get involved with the coding side then please do get in touch, regardless of experience. It would be good to have a fresh injection of flair and ideas into the project rather than just me flagging on .... Thanks and Regards phantomjinx |
From: <luc...@gm...> - 2010-12-14 02:13:36
|
On Ubuntu 10.10 I get the following when trying to upgrade with gtkpod_2.0.0.bb471c2-1_i386.deb: ---- An unhandlable error occurred There seems to be a programming error in aptdaemon, the software that allows you to install/remove software and to perform other package management related tasks. Please report this error at http://launchpad.net/aptdaemon/+filebug and retry. --- I realise that this isn't a GTKPod bug, but it would impact being able to test it... Gary On Sun, Dec 12, 2010 at 1:50 PM, phantomjinx < p.g...@ph...> wrote: > Evening all, > > I would like to head towards a release of gtkpod2 by the end of the month > so would people mind taking it for a spin if not already and let me know > problems, gripes, annoyances and other little bugs that they would prefer to > see fixed prior to this release please. In addition, anyone willing to give > their time over to translations would be more than appreciated. > > If you do not want to compile it yourself then there are unstable rpm > (fedora 13+) and deb (ubuntu maverick) builds on sourceforge: > > http://sourceforge.net/projects/gtkpod/files/gtkpod/gtkpod-2.0.0-unstable/20101211/ > > Latest things included: > - Converting videos to ipod spec mp4s, using ffmpeg, so in theory most > videe types should work > - Sorting playlists > > Once again, if people would like to get involved with the coding side then > please do get in touch, regardless of experience. It would be good to have a > fresh injection of flair and ideas into the project rather than just me > flagging on .... > > Thanks and Regards > > phantomjinx > > > ------------------------------------------------------------------------------ > Oracle to DB2 Conversion Guide: Learn learn about native support for > PL/SQL, > new data types, scalar functions, improved concurrency, built-in packages, > OCI, SQL*Plus, data movement tools, best practices and more. > http://p.sf.net/sfu/oracle-sfdev2dev > _______________________________________________ > Gtkpod-devel mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtkpod-devel > > |
From: Daniele F. <df...@gm...> - 2010-12-20 14:50:54
|
2010/12/16 P.G. Richardson: > Translations have been sorely neglected, especially as the app is > programmed in English and I speak English, ie. I never look at the app in > any other language. Need to rely on the translators out there: > a) to identify strings that should be translated > b) to add the translations most strings where ok, I was fooled by the fact that some old translations like "_Edit" are now fuzzy I'm fixing some strings, I'll push the changes to git after we've looked at the following The following strings start with 2 spaces, they are used in the View menu but they aren't aligned with the other strings, may I remove the leading spaces? _(" Edit Track Details") _(" Cover Browser") _(" Repository Information") _(" Track Filter") _(" Playlist Tracks") _(" iPod Photo Editor") _(" Media Player") _(" Edit iPod Repositories") _(" Cover Artwork") _(" iPod Repositories") The following strings are action names without a space _("CorePrefs") _("DetailsEditor") _("PhotoEditor") _("RepositoryEditor") but other action names have a space _("Cover Display") _("Playlist Display") what are right? In the plugin list the m4a and mp4 plugins have the same description, is it intended? plugins/filetype_m4a.plugin:Description=Support for the m4a / m4p file type plugins/filetype_mp4/filetype_mp4.plugin:Description=Support for the m4a / m4p file type plugins/filetype_mp4.plugin:Description=Support for the m4a / m4p file type plugins/filetype_m4a/filetype_m4a.plugin:Description=Support for the m4a / m4p file type >> in the Edit menu the word "menu" is really needed for the "New >> Playlist Menu" item? Also shouldn't it be move unde the Music menu >> since this creates a new playlist? > Fixed. only now I see that each and every item in that submenu has the same Ctrl+N shortcut, because all have GTK_STOCK_NEW, I will leave it only for "empty playlist", ok? The View / Toolbar menu should be removed? ./src/anjuta-app.c:453: /* No toolbar to be used in gtkpod */ -- Daniele Forsi |
From: phantomjinx <p.g...@ph...> - 2010-12-20 16:42:42
|
On 20/12/10 14:50, Daniele Forsi wrote: > 2010/12/16 P.G. Richardson: > > >> Translations have been sorely neglected, especially as the app is >> programmed in English and I speak English, ie. I never look at the app in >> any other language. Need to rely on the translators out there: >> a) to identify strings that should be translated >> b) to add the translations >> > most strings where ok, I was fooled by the fact that some old > translations like "_Edit" are now fuzzy > > I'm fixing some strings, I'll push the changes to git after we've > looked at the following > > The following strings start with 2 spaces, they are used in the View > menu but they aren't aligned with the other strings, may I remove the > leading spaces? > > _(" Edit Track Details") > _(" Cover Browser") > _(" Repository Information") > _(" Track Filter") > _(" Playlist Tracks") > _(" iPod Photo Editor") > _(" Media Player") > _(" Edit iPod Repositories") > _(" Cover Artwork") > _(" iPod Repositories") > > I inserted the spaces since the titles seemed too far over to the left of the views. > The following strings are action names without a space > _("CorePrefs") > _("DetailsEditor") > _("PhotoEditor") > _("RepositoryEditor") > but other action names have a space > _("Cover Display") > _("Playlist Display") > what are right? > > Anjuta seems to have proper names for these so space-separated. Fixed. > In the plugin list the m4a and mp4 plugins have the same description, > is it intended? > plugins/filetype_m4a.plugin:Description=Support for the m4a / m4p file type > plugins/filetype_mp4/filetype_mp4.plugin:Description=Support for the > m4a / m4p file type > plugins/filetype_mp4.plugin:Description=Support for the m4a / m4p file type > plugins/filetype_m4a/filetype_m4a.plugin:Description=Support for the > m4a / m4p file type > > Good spot. Fixed. >>> in the Edit menu the word "menu" is really needed for the "New >>> Playlist Menu" item? Also shouldn't it be move unde the Music menu >>> since this creates a new playlist? >>> > >> Fixed. >> > only now I see that each and every item in that submenu has the same > Ctrl+N shortcut, because all have GTK_STOCK_NEW, I will leave it only > for "empty playlist", ok? > Ah ... wondered why that was the case. No problem. > The View / Toolbar menu should be removed? > ./src/anjuta-app.c:453: /* No toolbar to be used in gtkpod */ > > Yes, I shall remove that code since a toolbar takes up far too much space. Cheers PGR |
From: Daniele F. <df...@gm...> - 2010-12-21 16:21:15
Attachments:
newplaylist2.glade
|
2010/12/20 phantomjinx: >> The following strings start with 2 spaces, they are used in the View >> menu but they aren't aligned with the other strings, may I remove the >> leading spaces? >> >> _(" Edit Track Details") >> _(" Cover Browser") >> _(" Repository Information") >> _(" Track Filter") >> _(" Playlist Tracks") >> _(" iPod Photo Editor") >> _(" Media Player") >> _(" Edit iPod Repositories") >> _(" Cover Artwork") >> _(" iPod Repositories") >> >> > > I inserted the spaces since the titles seemed too far over to the left of > the views. you are right, but this indents the labels in the menu. Some dialogs need small fixes, I think you can fix them faster than me ;-) "New Playlist" accepts an empty string as playlist name and it allows to create playlists with duplicated names; at least the empty name should be forbidden. "Initialize iPod" accepts any string as mountpoint, even an empty string, and it doesn't check if it exists but creates it if it has permissions (if you give "foo" as mountpoint it creates a foo directory with iPod_Control and so on inside it); it should fail if the given mountpoint doesn't exist. Also in this Initialize dialog I see 3 empty submenus at the bottom of the list of iPod models, inside them I see iPhone 16GB xC603, iPod Touch xC540, 8 GB Nano xC525 and so on, is it a problem with my version of libgpod? If it's in libgpod, can gtkpod replace the empty string with something generic? Like "Other devices 1", "Other devices 2", ... And now for some menu shuffling... since Create iPod's Directories doesn't deal with tracks, it could be moved from Music to Tools and maybe some text added to the dialog to explain what happens to existing directories. I have played with glade for a possible replacement of the "New Playlist" function activated with Ctrl+N (see the attached file), the various combinations of manual/auto would call the code for empty playlist, smart playlists, the other playlists (for which a new dialog would be needed) and possibly setting the checkboxes in the Playlist properties dock. What do you think? -- Daniele Forsi |
From: phantomjinx <p.g...@ph...> - 2010-12-22 13:46:53
|
On 21/12/10 16:21, Daniele Forsi wrote: > 2010/12/20 phantomjinx: > > >>> The following strings start with 2 spaces, they are used in the View >>> menu but they aren't aligned with the other strings, may I remove the >>> leading spaces? >>> >>> _(" Edit Track Details") >>> _(" Cover Browser") >>> _(" Repository Information") >>> _(" Track Filter") >>> _(" Playlist Tracks") >>> _(" iPod Photo Editor") >>> _(" Media Player") >>> _(" Edit iPod Repositories") >>> _(" Cover Artwork") >>> _(" iPod Repositories") >>> >>> >>> >> I inserted the spaces since the titles seemed too far over to the left of >> the views. >> > you are right, but this indents the labels in the menu. > > Some dialogs need small fixes, I think you can fix them faster than me ;-) > > "New Playlist" accepts an empty string as playlist name and it allows > to create playlists with duplicated names; at least the empty name > should be forbidden. > > Fixed. > "Initialize iPod" accepts any string as mountpoint, even an empty > string, and it doesn't check if it exists but creates it if it has > permissions (if you give "foo" as mountpoint it creates a foo > directory with iPod_Control and so on inside it); it should fail if > the given mountpoint doesn't exist. > > Thinking on the lines of a libgpod function that can be called separately. > Also in this Initialize dialog I see 3 empty submenus at the bottom of > the list of iPod models, inside them I see iPhone 16GB xC603, iPod > Touch xC540, 8 GB Nano xC525 and so on, is it a problem with my > version of libgpod? If it's in libgpod, can gtkpod replace the empty > string with something generic? Like "Other devices 1", "Other devices > 2", ... > > Can up libgpod to 8. Although, that is too high for a lot of the current distros. > And now for some menu shuffling... since Create iPod's Directories > doesn't deal with tracks, it could be moved from Music to Tools and > maybe some text added to the dialog to explain what happens to > existing directories. > Fixed. > I have played with glade for a possible replacement of the "New > Playlist" function activated with Ctrl+N (see the attached file), the > various combinations of manual/auto would call the code for empty > playlist, smart playlists, the other playlists (for which a new dialog > would be needed) and possibly setting the checkboxes in the Playlist > properties dock. What do you think? > > Not quite sure whether the auto/manual buttons are obvious enough for the user to understand. Also, additional dialogs popping up after one another imply a wizard so maybe that would be the preferred way to go? PGR |
From: Daniele F. <df...@gm...> - 2010-12-22 23:20:50
|
2010/12/22 phantomjinx: >> I have played with glade for a possible replacement of the "New >> Playlist" function activated with Ctrl+N (see the attached file), the >> various combinations of manual/auto would call the code for empty >> playlist, smart playlists, the other playlists (for which a new dialog >> would be needed) and possibly setting the checkboxes in the Playlist >> properties dock. What do you think? >> >> > > Not quite sure whether the auto/manual buttons are obvious enough for the > user to understand. Also, additional dialogs popping up after one another > imply a wizard so maybe that would be the preferred way to go? yes, a wizard would be a cleaner solution than what I was thinking, but in fact empty and smart imply only 1 step so they are ok attached to a menu, maybe a single dialog to explain or group the other playlist types would be enough I have looked again at translations and found that something is missing. It seems that some changes are needed to translate plugin descriptions and names, see http://library.gnome.org/devel/libanjuta/stable/plugin-description-file.html Grepping the sources I can't find some strings like "Only show user activatable plugins", "Load", "Available Plugins", I guess they come from libanjuta but I see them translated in Anjuta and not translated in gtkpod. Here are some defects in that I'm not able to fix: 1. in Preferences / Track Display when adding to the displayed columns list, the Add Column dialog opens in the middle of the screen and doesn't stay on top of the preferences window even if it apparently uses the right code plugins/track_display/track_display_preferences.c:280: gtk_window_set_transient_for (GTK_WINDOW (dlg), notebook_get_parent_window()); (I checked that notebook_get_parent_window() doesn't return NULL) 2. again in Preferences / Track Display the dialog to add a word to the ignore list uses the main window as parent (it may get hidden by the preferences window and stays in front of the main window) 3. all dialogs opened from the preferences window can be opened only once, the second time they fail (you can press ESC to close the small window), I think they correctly call gtk_widget_destroy() so I don't know what to check -- Daniele Forsi |
From: Daniele F. <df...@gm...> - 2010-12-29 22:39:19
|
More remarks: 1. the "Info View" and "Repository Information" menu items toggle visibility of the same dock, but I would expect only the checkbox menu item for it, like all other docks. To reproduce, when first running gtkpod open the view menu, those two items aren't visible; go to Preferences / Plugins, the Info Display Plugin is disabled, enable it; open the View menu and see that an "Info View" item with an icon has appeared, select it; reopen the View menu and see that a "Repository Information" item with a checkbox has appeared; 2. the View Toolbar menu item isn't needed but I can't find how to remove it; also the callback isn't needed: anjuta-app.c: At top level: anjuta-app.c:115: warning: ‘on_toolbar_style_changed’ defined but not used 3. in Preferences/Settings under "On the fly conversion" heading you can choose between MP3 and AAC while in the dialog opened with the "Conversion settings" button you can choose between OGG and FLAC; I don't understand if they are related 4. in Preferences/Plugins every time a plugin is enabled or disabled another Display Playlist icon appears 5. in some dialogs there is a "Browse" GtkButton plus a GtkEntry (Initialize iPod, Create Repository), while in others there is a GtkFileChooserButton (Conversion preferences, mserv settings) 6. the encoding preferences dialog can be opened from 2 places Preferences/Settings/Encoding and Preferences/Metadata/Encoding -- Daniele Forsi |
From: phantomjinx <p.g...@ph...> - 2011-01-02 09:23:13
|
Hi Daniel, Have been working through your remarks ... thanks for those. I noticed a build problem. When you compile, do you have the webkit library present in order to build coverweb? It seems your commit 381c70 re-organises the translation files etc... but in so doing has removed references to coverweb's files. I presume it is because this plugin is not built on your system. Can you confirm? I will readd the entries back as it has broken the ubuntu auto-build. Cheers for you help PGR |
From: phantomjinx <p.g...@ph...> - 2011-01-03 00:29:14
|
> I confirm that isn't built, but that commit only removed coverweb.c > from POTFILES.in because there weren't string marked as translatable: > > +plugins/coverweb/coverweb.glade > +plugins/coverweb/coverweb_preferences.c > +plugins/coverweb/plugin.c > > -plugins/coverweb/coverweb.c > -plugins/coverweb/plugin.c > -plugins/coverweb/coverweb_preferences.c > -plugins/coverweb/coverweb.glade > > (now I added coverweb.c back because there were 2 strings to be > translated and installed libwebkit-dev to test it) > > >> I will readd the entries back as it has broken the ubuntu auto-build. >> > Seemed that data/coverweb.glade got removed and never re-added, which was the only error in the auto-build so fixed. > sure, but please don't make update-po until the last moment before you > will ask people to work on translations because it makes git history > unnecessarily bigger (diff are usually big if line numbers are changed > and there's no need for updated .po/.mo files with untranslated > strings because there is no user visible difference) ideally there > would be only 2 commits of .po files, one to prepare the files on > which translators will work and one to integrate their work > > *** > Too late ... sorry! Will not in future. Although I am trying to keep them up to date with the ones on transifex. That said no one has done any translations for them yet ... > cover web segfaults > on a regular image a popup menu with 3 or 4 items is shown and > everything is ok, but in Google images when you hover a picture and > the bigger picture is shown, the popup menu has 7 items and chosing > "Copy image" results in a segfault: > > #0 0xb39cfd07 in ?? () from /usr/lib/libwebkit-1.0.so.2 > #1 0xb351de12 in ?? () from /usr/lib/libwebkit-1.0.so.2 > #2 0xb368db65 in ?? () from /usr/lib/libwebkit-1.0.so.2 > #3 0xb39c6a38 in ?? () from /usr/lib/libwebkit-1.0.so.2 > #4 0x00d2c93c in g_cclosure_marshal_VOID__VOID () from > /usr/lib/libgobject-2.0.so.0 > #5 0x00d1d412 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 > #6 0x00d33595 in ?? () from /usr/lib/libgobject-2.0.so.0 > #7 0x00d349bc in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 > #8 0x00d34e62 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 > #9 0x008d3945 in gtk_widget_activate () from /usr/lib/libgtk-x11-2.0.so.0 > #10 0x007b13a0 in gtk_menu_shell_activate_item () from > /usr/lib/libgtk-x11-2.0.so.0 > #11 0x007b2d3f in ?? () from /usr/lib/libgtk-x11-2.0.so.0 > #12 0x007a7a54 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 > #13 0x007a1284 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 > #14 0x00d1ba87 in ?? () from /usr/lib/libgobject-2.0.so.0 > #15 0x00d1d412 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 > #16 0x00d331e6 in ?? () from /usr/lib/libgobject-2.0.so.0 > #17 0x00d3483b in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 > #18 0x00d34e62 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 > #19 0x008cfb96 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 > #20 0x0079985d in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0 > #21 0x0079ac17 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 > #22 0x0026f36a in ?? () from /usr/lib/libgdk-x11-2.0.so.0 > #23 0x00e9d855 in g_main_context_dispatch () from /lib/libglib-2.0.so.0 > #24 0x00ea1668 in ?? () from /lib/libglib-2.0.so.0 > #25 0x00ea1ba7 in g_main_loop_run () from /lib/libglib-2.0.so.0 > #26 0x0079b1d9 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 > #27 0x08053813 in main (argc=1, argv=0xbfbae094) at main.c:63 > > *** > > gtkpod freezes: > right click on a track and choose edit track details, do not apply but > close the track details dock, then right click on a track, the popup > menu never shows and gtkpod freezes > attaching gdb, this is the interesting part of the backtrace: > #0 0x00575416 in __kernel_vsyscall () > #1 0x006b6169 in __lll_lock_wait () at > ../nptl/sysdeps/unix/sysv/linux/i386/i686/../i486/lowlevellock.S:142 > #2 0x006b15cb in _L_lock_748 () from /lib/libpthread.so.0 > #3 0x006b13f1 in __pthread_mutex_lock (mutex=0x8f32220) at > pthread_mutex_lock.c:61 > #4 0x002e96d6 in ?? () from /usr/lib/libgdk-x11-2.0.so.0 > #5 0x002e9660 in gdk_threads_enter () from /usr/lib/libgdk-x11-2.0.so.0 > #6 0x01152685 in details_set_tracks (tracks=0x947fed0) at details.c:1292 > #7 0x00590ef8 in g_cclosure_marshal_VOID__POINTER () from > /usr/lib/libgobject-2.0.so.0 > #8 0x00582412 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 > #9 0x00598595 in ?? () from /usr/lib/libgobject-2.0.so.0 > #10 0x005999bc in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 > #11 0x00599e62 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 > #12 0x00894f59 in gtkpod_set_selected_tracks (tracks=0x947fed0) at > gtkpod_app_iface.c:379 > #13 0x065e64a1 in tm_context_menu_init () at track_display_context_menu.c:157 > #14 0x065e9559 in tm_button_press_event (w=0x910cc80, e=0x9376808, > data=0x0) at display_tracks.c:1966 > > it also freezes if you have Playlist Tracks and Track Details open at > the same time, start editing the details and right click on a track in > Playlist Tracks > > *** > > Right clicking on an item in Track Display selects the line and open > the popup menu, while on Filter Tabs only selects it, you need to > right click a second time to open the popup menu. > > Copying tracks from this popup menu is the same as exporting from the > Tools menu? If so the menu labels should be more similar, while we > have > (popup menu) Copy / Copy Tracks to Filesystem > (Tools menu) Export Tracks / Export Tracks To Filesystem > > (Tools menu) Export Tracks / Export Tracks To Playlist File > (popup menu) Create Playlist / Create Playlist File > > *** > > While editing track details does it make sense to modify Filesize? > No. Should be read-only. > *** > > There is a bunch of strings that might need translations, since you > know the code you may be able to tell if it's true faster than me, and > it seems strange that two files are identical except one included > file, see: > diff -u ./plugins/cover_display/fetchcover.c > ./plugins/details_editor/fetchcover.c > Yeah. Its because the fetchcover service is used in the two separate plugins, ie. cover_display and details editor. The fetchcover service operates by dragging n dropping an image onto the relevant canvas, which them downloads and copies the image. In both plugins, it is possible to do this thus both plugins need the service. However, I didnt want it in the core library since it is an optional service. Unfortunately, it is impossible for plugins to depend on each other so I am left with replicating it since both plugins are completely independant on one another. > I hand picked them running grep "g_strdup" . -rn | grep '"' | grep -v > '_(' | grep -v ngettext | less > > ./plugins/details_editor/details.c:1202: = g_strdup_printf("%d / %d", > g_list_index(details_view->tracks, details_view->track) + 1, > g_list_length(details_view->tracks)); > > ./plugins/filetype_wav/wavfile.c:164: track->filetype = g_strdup("WAV > audio file"); > > ./plugins/filetype_video/videofile.c:47: track->filetype = > g_strdup("Generic video file"); > > ./plugins/filetype_flac/flacfile.c:157: track->description = > g_strdup("FLAC audio file"); > > ./plugins/filetype_ogg/oggfile.c:80: track->description = > g_strdup("OGG audio file"); > > ./plugins/filetype_mp3/mp3file.c:1195: gchar *tmp = > g_strdup_printf("(%d)", index); > ./plugins/filetype_mp3/mp3file.c:1626: string1 = > g_strdup_printf("%d/%d", track->track_nr, track->tracks); > ./plugins/filetype_mp3/mp3file.c:1633: string1 = > g_strdup_printf("%d/%d", track->cd_nr, track->cds); > ./plugins/filetype_mp3/mp3file.c:2784: track->filetype = > g_strdup("MPEG audio file"); > > ./plugins/filetype_mp4/mp4file.c:693: track->filetype = g_strdup("AAC > audio file"); > ./plugins/filetype_mp4/mp4file.c:695: track->filetype = > g_strdup("Protected AAC audio file"); > ./plugins/filetype_mp4/mp4file.c:697: track->filetype = g_strdup("AAC > audio book file"); > ./plugins/filetype_mp4/mp4file.c:699: track->filetype = g_strdup("MP4 > video file"); > ./plugins/filetype_m4a/mp4file.c:693: track->filetype = g_strdup("AAC > audio file"); > ./plugins/filetype_m4a/mp4file.c:695: track->filetype = > g_strdup("Protected AAC audio file"); > ./plugins/filetype_m4a/mp4file.c:697: track->filetype = g_strdup("AAC > audio book file"); > ./plugins/filetype_m4a/mp4file.c:699: track->filetype = g_strdup("MP4 > video file"); > > ./plugins/cover_display/fetchcover.c:150: fetch_cover->err_msg = > g_strdup("Only jpg images are currently supported at this time\n"); > ./plugins/cover_display/fetchcover.c:173: fetch_cover->err_msg = > g_strdup("fetchcover curl data memory is null so failed to download > anything!\n"); > ./plugins/cover_display/fetchcover.c:180: fetch_cover->err_msg = > g_strdup("fetchcover memory contains<html> tag so not a valid jpg > image\n"); > ./plugins/cover_display/fetchcover.c:200: fetch_cover->err_msg = > g_strdup ("Failed to create a file with the filename\n"); > ./plugins/cover_display/fetchcover.c:214: fetch_cover->err_msg = > g_strdup("fetchcover failed to write the data to the new file\n"); > ./plugins/cover_display/fetchcover.c:225: fetch_cover->err_msg = > g_strdup("fetchcover downloaded file is not a valid image file\n"); > ./plugins/cover_display/fetchcover.c:261: fetch_cover->err_msg = > g_strdup("fetchcover object's tracks list either NULL or no tracks > were selected\n"); > ./plugins/cover_display/fetchcover.c:302: fetch_cover->err_msg = > g_strdup("operation cancelled\n"); > > ./plugins/details_editor/fetchcover.c:149: fetch_cover->err_msg = > g_strdup("Only jpg images are currently supported at this time\n"); > ./plugins/details_editor/fetchcover.c:172: fetch_cover->err_msg = > g_strdup("fetchcover curl data memory is null so failed to download > anything!\n"); > ./plugins/details_editor/fetchcover.c:179: fetch_cover->err_msg = > g_strdup("fetchcover memory contains<html> tag so not a valid jpg > image\n"); > ./plugins/details_editor/fetchcover.c:199: fetch_cover->err_msg = > g_strdup ("Failed to create a file with the filename\n"); > ./plugins/details_editor/fetchcover.c:213: fetch_cover->err_msg = > g_strdup("fetchcover failed to write the data to the new file\n"); > ./plugins/details_editor/fetchcover.c:224: fetch_cover->err_msg = > g_strdup("fetchcover downloaded file is not a valid image file\n"); > ./plugins/details_editor/fetchcover.c:260: fetch_cover->err_msg = > g_strdup("fetchcover object's tracks list either NULL or no tracks > were selected\n"); > ./plugins/details_editor/fetchcover.c:301: fetch_cover->err_msg = > g_strdup("operation cancelled\n"); > > ./plugins/sorttab_display/display_sorttabs.c:2990: = > g_strdup_printf("%02d/%02d/%04d %d:%02d", tm->tm_mday, tm->tm_mon + 1, > 1900 + tm->tm_year, tm->tm_hour, tm->tm_min); > ./plugins/sorttab_display/display_sorttabs.c:3024: str = > g_strdup_printf("> %s", str1); > ./plugins/sorttab_display/display_sorttabs.c:3026: str = > g_strdup_printf("< %s", str2); > ./plugins/sorttab_display/display_sorttabs.c:3028: str = > g_strdup_printf("%s< < %s", str1, str2); > > ./plugins/repository_editor/repository_init.c:72: = > g_strdup_printf("%2.0f GB %s (x%s)", info->capacity, > itdb_info_get_ipod_model_name_string(info->ipod_model), > info->model_number); > ./plugins/repository_editor/repository_init.c:76: = > g_strdup_printf("%3.0f MB %s (x%s)", info->capacity * 1024, > itdb_info_get_ipod_model_name_string(info->ipod_model), > info->model_number); > ./plugins/repository_editor/repository_init.c:80: = > g_strdup_printf("%s (x%s)", > itdb_info_get_ipod_model_name_string(info->ipod_model), > info->model_number); > > ./libgtkpod/misc_playlist.c:191: category = g_strdup_printf("[%s %s]", > qualifier, track_cat); > ./libgtkpod/misc_playlist.c:254: pl_name = g_strdup_printf("[%s]", pl_name1); > ./libgtkpod/misc_playlist.c:408: gchar *pl_name = g_strdup_printf("[%s]", str); > > ./libgtkpod/misc_conversion.c:379: return g_strdup ("--"); > > ./libgtkpod/tools.c:398: gchar *label_buf = g_strdup_printf ("%d/%d", count, n); > > ./libgtkpod/misc_track.c:1105: return g_strdup_printf("%d:%06.3f", > length / 60000, ((float) (length % 60000)) / 1000); > ./libgtkpod/misc_track.c:1195: text = g_strdup_printf("%d/%d", > track->track_nr, track->tracks); > ./libgtkpod/misc_track.c:1201: text = g_strdup_printf("%d/%d", > track->cd_nr, track->cds); > ./libgtkpod/misc_track.c:1207: text = g_strdup("--"); > ./libgtkpod/misc_track.c:1249: text = g_strdup_printf("%dk", track->bitrate); > ./libgtkpod/misc_track.c:1914: return g_strdup_printf("iPod ID: %d", track->id); > > Will look into these further over the next couple of days. Cheers PGR |
From: Daniele F. <df...@gm...> - 2011-01-04 18:01:45
|
2011/1/3 phantomjinx: > Yeah. Its because the fetchcover service is used in the two separate > plugins, ie. cover_display and details editor. The fetchcover service > operates by dragging n dropping an image onto the relevant canvas, which > them downloads and copies the image. In both plugins, it is possible to do > this thus both plugins need the service. However, I didnt want it in the > core library since it is an optional service. Unfortunately, it is > impossible for plugins to depend on each other so I am left with replicating > it since both plugins are completely independant on one another. ok the following line can be removed? I builds without warnings. $ diff -u ./plugins/cover_display/fetchcover.c ./plugins/details_editor/fetchcover.c --- ./plugins/cover_display/fetchcover.c 2010-12-15 16:50:25.000000000 +0100 +++ ./plugins/details_editor/fetchcover.c 2010-12-15 16:50:25.000000000 +0100 @@ -37,7 +37,6 @@ #include "libgtkpod/misc.h" #include "plugin.h" #include "fetchcover.h" -#include "display_coverart.h" #undef FETCHCOVER_DEBUG -- Daniele Forsi |
From: phantomjinx <p.g...@ph...> - 2011-01-04 21:08:28
|
On 04/01/11 18:01, Daniele Forsi wrote: > 2011/1/3 phantomjinx: > > >> Yeah. Its because the fetchcover service is used in the two separate >> plugins, ie. cover_display and details editor. The fetchcover service >> operates by dragging n dropping an image onto the relevant canvas, which >> them downloads and copies the image. In both plugins, it is possible to do >> this thus both plugins need the service. However, I didnt want it in the >> core library since it is an optional service. Unfortunately, it is >> impossible for plugins to depend on each other so I am left with replicating >> it since both plugins are completely independant on one another. >> > ok > the following line can be removed? I builds without warnings. > > $ diff -u ./plugins/cover_display/fetchcover.c > ./plugins/details_editor/fetchcover.c > --- ./plugins/cover_display/fetchcover.c 2010-12-15 16:50:25.000000000 +0100 > +++ ./plugins/details_editor/fetchcover.c 2010-12-15 16:50:25.000000000 +0100 > @@ -37,7 +37,6 @@ > #include "libgtkpod/misc.h" > #include "plugin.h" > #include "fetchcover.h" > -#include "display_coverart.h" > > #undef FETCHCOVER_DEBUG > > > Yeah, seems ok. Will commit later on. Cheers PGR |
From: phantomjinx <p.g...@ph...> - 2011-01-03 00:19:32
|
On 29/12/10 22:39, Daniele Forsi wrote: > More remarks: > > 1. the "Info View" and "Repository Information" menu items toggle > visibility of the same dock, but I would expect only the checkbox menu > item for it, like all other docks. > To reproduce, when first running gtkpod open the view menu, those two > items aren't visible; > go to Preferences / Plugins, the Info Display Plugin is disabled, enable it; > open the View menu and see that an "Info View" item with an icon has > appeared, select it; > reopen the View menu and see that a "Repository Information" item with > a checkbox has appeared; > I have updated the label of the "Info View" menu item but realistically they both need to be there. The "Info View" opens the widget initially while the "Repo Info" appears as a consequence of the gdl docking system. > 2. the View Toolbar menu item isn't needed but I can't find how to > remove it; also the callback isn't needed: > anjuta-app.c: At top level: > anjuta-app.c:115: warning: ‘on_toolbar_style_changed’ defined but not used > > Fixed. > 3. in Preferences/Settings > under "On the fly conversion" heading you can choose between MP3 and AAC > while in the dialog opened with the "Conversion settings" button you > can choose between OGG and FLAC; I don't understand if they are > related > MP3 and AAC represent target conversion formats, ie. those formats that the ipod understands and you would want to convert to. The OGG and Flac represent formats to convert from, ie. you may have some oggs on your computer. I have removed the latters preferences since the installation of the relevant file type plugins should be enough of a reason to want to convert them. > 4. in Preferences/Plugins every time a plugin is enabled or disabled > another Display Playlist icon appears > Cannot repeat that. > 5. in some dialogs there is a "Browse" GtkButton plus a GtkEntry > (Initialize iPod, Create Repository), while in others there is a > GtkFileChooserButton (Conversion preferences, mserv settings) > > Fixed in the repository plugin to make more sense. > 6. the encoding preferences dialog can be opened from 2 places > Preferences/Settings/Encoding and Preferences/Metadata/Encoding > True. Not quite sure what to do about them. Both places kinda make sense but not sure whether the dialog should be separated. Cheers PGR |
From: Christophe F. <cfe...@gm...> - 2010-12-21 16:24:36
|
2010/12/21 Daniele Forsi <df...@gm...>: > > Also in this Initialize dialog I see 3 empty submenus at the bottom of > the list of iPod models, inside them I see iPhone 16GB xC603, iPod > Touch xC540, 8 GB Nano xC525 and so on, is it a problem with my > version of libgpod? If it's in libgpod, can gtkpod replace the empty > string with something generic? Like "Other devices 1", "Other devices > 2", ... I released libgpod 0.7.95 with a similar bug, 0.8.0 should be fine. Which version of libgpod are you using? Christophe |
From: Daniele F. <df...@gm...> - 2010-12-21 17:09:08
|
Replying to all and with more details this time. 2010/12/21 Christophe Fergeau: > I released libgpod 0.7.95 with a similar bug, 0.8.0 should be fine. > Which version of libgpod are you using? 0.7.3SVN gtkpod's configure checks for libgpod-1.0 >= 0.7.0 Christophe pointed out that it's old (January 2009 in fact, so the requirement can be bumped to 0.8.0 I guess) BTW gtkpod 1 showed libgpod's version in the about box -- Daniele Forsi |
From: Christophe F. <cfe...@gm...> - 2010-12-21 17:33:23
|
2010/12/21 Daniele Forsi <df...@gm...>: > BTW gtkpod 1 showed libgpod's version in the about box This was misleading though, the version number there was the one gtkpod was compiled against, not necessarily the shared library that is actually being used by gtkpod. Christophe |