From: Andrew H. <as...@hu...> - 2004-02-26 04:38:33
Attachments:
nullpl.diff
showgui.diff
|
add_new_playlist(NULL,-1) is bad for a couple reasons, but that's exactly what the menu item edit->create playlist->empty playlist does. From other parts of callbacks.c, it seems that add_new_playlist_user_name is the way to avoid this, and that's what nullpl.diff does. also, i added an assertion that plname != NULL so that the ipod db doesn't get corrupted somehow. btw, the first place having playlist->name == NULL is bad is in display_playlist.c line 594. You can't g_utf8_collate a NULL string. for archival purposes, i also attached a patch i sent jorg last night that brings up the gui before importing the itunes db so that startup doesn't take so long with large db's and especially large db's with out-of-date iTunesDB.ext. |
From: Jorg S. <Jor...@gm...> - 2004-02-26 14:35:50
|
Hi Andrew, thanks for the patches. I have added them to the source. I'm looking forward to more contributions ;-) Cheers, JCS. On Wed, Feb 25, 2004 at 09:36:44PM -0700, Andrew Huntwork wrote: > add_new_playlist(NULL,-1) is bad for a couple reasons, but that's > exactly what the menu item edit->create playlist->empty playlist does. > From other parts of callbacks.c, it seems that > add_new_playlist_user_name is the way to avoid this, and that's what > nullpl.diff does. also, i added an assertion that plname != NULL so > that the ipod db doesn't get corrupted somehow. > > btw, the first place having playlist->name == NULL is bad is in > display_playlist.c line 594. You can't g_utf8_collate a NULL string. > > for archival purposes, i also attached a patch i sent jorg last night > that brings up the gui before importing the itunes db so that startup > doesn't take so long with large db's and especially large db's with > out-of-date iTunesDB.ext. |