On Sat, Mar 14, 2009 at 16:56, Christophe Fergeau <email@example.com>
2009/3/14 Jorg Schuler <Jorg.Schuler@gmx.de>:
> Looks fine to me as well, but I would suggest the attached addition. Let meThis looks fine to me (preprend => prepend in the comment), but for
> know if I should submit it.
the pos_comp changes, I'd rather have Javier opinion first since we
had a similar function which was buggy because of some overflow or bad
arith. I think your change is fine because we are dealing with gint
values, but maybe I'm missing something.
Yes, it looks good to me because these are a) signed int, b) track positions, which technically won't be as large as to overflow the variable (or are they?)