On Mon, Feb 23, 2009 at 14:34, Jorg Schuler <Jorg.Schuler@gmx.de> wrote:
That's why I liked the way doubly linked lists on the Amiga were done. _prepend and _append were equally effective.

The patch looks fine to me as well.

I think it's safe to remove the g_list_reverse in this one. However, since it's a doubly-linked list, I wouldn't worry too much.

On the other hand, I've seen a few places where singly-linked lists would be as useful, and 1/3 cheaper memory- and cache-wise. I didn't want to change the API yet, though.



Javier Kohen wrote:
As mentioned earlier, I only addressed the major bottlenecks.

Where it seemed that the order would matter, I added a g_list_reverse. If you are sure that the order is irrelevant (gtkpod seems to sort most things at display time), then please remove the extra calls.


Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD

Gtkpod-devel mailing list