Menu

Libgpod code Merge Request #2: Make int arguments explicit (open)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Peter Levine wants to merge 1 commit from /u/plevine457/gtkpod/ to master, 2022-12-11

Building using clang with the same default strictness as upcoming clang-16 fails with:

generic-callout.c:667:49: error: parameter 'usb_device_number' was not declared, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
static char *get_info_from_usb (usb_bus_number, usb_device_number)
                                                ^
generic-callout.c:667:33: error: parameter 'usb_bus_number' was not declared, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
static char *get_info_from_usb (usb_bus_number, usb_device_number)

Making the offending arguments explicitly gint (aka int) fixes the build.

Commit Date  
[7fbc4a] (HEADmaster) by Peter Levine Peter Levine

Don't pass implicit ints as arguments

Implicit int argument dedution is not supported in C99 and will cause
build failure with upcoming clang-16.

2022-12-11 00:17:46 Tree

Discussion


Log in to post a comment.