From: Hamish M. <ham...@gm...> - 2013-02-02 02:19:06
|
Hi, I want to do a release of Leksah to Hackage that uses Gtk3 and WebKit (preferably in the next week or two). This will need the following patches: https://patch-tag.com/r/hamish/gtk2hs http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) https://patch-tag.com/r/hamish/webkit Although these packages default to gtk3 you can still use them with gtk2 (cabal install -f-gtk3) I think we have three options: 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a regular release (perhaps 0.13.0). 2) Create a new repo for them and release it as gtk on Hackage (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. Please can we start the ball rolling on option 1 or can you let me know which of the other two options you would prefer? Thanks, Hamish |
From: <wag...@se...> - 2013-02-09 05:08:20
|
I am attempting (and failing) to build gtk3hs. Have you seen these errors? There are several of them, but they are all very similar, so I've only included the first one. Graphics/UI/Gtk/Printing/PrintOperation.chs:409:6: Couldn't match expected type `Ptr ()' with actual type `Window' In the return type of a call of `toWindow' In the third argument of `\ (PrintOperation arg1) arg2 arg3 arg4 -> withForeignPtr arg1 $ \ argPtr1 -> gtk_print_operation_run argPtr1 arg2 arg3 arg4', namely `(toWindow parent)' In the expression: (\ (PrintOperation arg1) arg2 arg3 arg4 -> withForeignPtr arg1 $ \ argPtr1 -> gtk_print_operation_run argPtr1 arg2 arg3 arg4) (toPrintOperation self) ((fromIntegral . fromEnum) action) (toWindow parent) errorPtr This is especially puzzling because diff tells me that PrintOperation.chs hasn't changed in these patches, and as far as I can tell from the GTK documentation, the printing API hasn't changed between gtk-2 and gtk-3, either. Still exploring. ~d Quoting Hamish Mackenzie <ham...@gm...>: > Hi, > > I want to do a release of Leksah to Hackage that uses Gtk3 and > WebKit (preferably in the next week or two). > > This will need the following patches: > https://patch-tag.com/r/hamish/gtk2hs > http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) > https://patch-tag.com/r/hamish/webkit > > Although these packages default to gtk3 you can still use them with > gtk2 (cabal install -f-gtk3) > > I think we have three options: > 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a > regular release (perhaps 0.13.0). > 2) Create a new repo for them and release it as gtk on Hackage > (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. > 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. > > Please can we start the ball rolling on option 1 or can you let me > know which of the other two options you would prefer? > > Thanks, > Hamish > > > |
From: Axel S. <Axe...@in...> - 2013-02-09 16:57:16
|
Hi Daniel, On 09.02.2013, at 06:08, wag...@se... wrote: > I am attempting (and failing) to build gtk3hs. Have you seen these errors? There are several of them, but they are all very similar, so I've only included the first one. > > Graphics/UI/Gtk/Printing/PrintOperation.chs:409:6: > Couldn't match expected type `Ptr ()' with actual type `Window' > In the return type of a call of `toWindow' > In the third argument of `\ (PrintOperation arg1) arg2 arg3 arg4 > -> withForeignPtr arg1 > $ \ argPtr1 > -> gtk_print_operation_run argPtr1 arg2 arg3 arg4', namely > `(toWindow parent)' > In the expression: > (\ (PrintOperation arg1) arg2 arg3 arg4 > -> withForeignPtr arg1 > $ \ argPtr1 -> gtk_print_operation_run argPtr1 arg2 arg3 arg4) > (toPrintOperation self) > ((fromIntegral . fromEnum) action) > (toWindow parent) > errorPtr > > This is especially puzzling because diff tells me that PrintOperation.chs hasn't changed in these patches, and as far as I can tell from the GTK documentation, the printing API hasn't changed between gtk-2 and gtk-3, either. > > Still exploring. > I can tell you what is happening, if that helps. I suspect that c2hs translates gtk_print_operation_run such that it expects a Ptr () instead of a GtkWindow. The reason is that c2hs has not seen the typedef of GtkWindow, probably due to not finding it in the big header file it parses or, more likely, it doesn't read in the .chi file that holds this mapping. So maybe there is a reason why the .chi file isn't generated or not read. I can't actually remember how it all works. I think .chs files are sorted topologically by their dependency and the first one will create the cache file that holds the parsed result of the big header file that is afterwards read by all other invocations of c2hs. Maybe there is a cycle in the dependencies? I hope I'm helping more than I'm confusing. But it is likely a problem with c2hs and not with C files being incompatible. Many widgets used to incorrectly return a Widget* rather than a, say, PrintOption* . So there are a lot of casts in the Haskell code. These should be harmless though. Cheers, Axel > ~d > > Quoting Hamish Mackenzie <ham...@gm...>: > >> Hi, >> >> I want to do a release of Leksah to Hackage that uses Gtk3 and WebKit (preferably in the next week or two). >> >> This will need the following patches: >> https://patch-tag.com/r/hamish/gtk2hs >> http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) >> https://patch-tag.com/r/hamish/webkit >> >> Although these packages default to gtk3 you can still use them with gtk2 (cabal install -f-gtk3) >> >> I think we have three options: >> 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a regular release (perhaps 0.13.0). >> 2) Create a new repo for them and release it as gtk on Hackage (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. >> 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. >> >> Please can we start the ball rolling on option 1 or can you let me know which of the other two options you would prefer? >> >> Thanks, >> Hamish >> >> >> > > |
From: <wag...@se...> - 2013-02-15 01:38:34
|
Quoting Hamish Mackenzie <ham...@gm...>: > Hi, > > I want to do a release of Leksah to Hackage that uses Gtk3 and > WebKit (preferably in the next week or two). > > This will need the following patches: > https://patch-tag.com/r/hamish/gtk2hs > http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) > https://patch-tag.com/r/hamish/webkit > > Although these packages default to gtk3 you can still use them with > gtk2 (cabal install -f-gtk3) > > I think we have three options: > 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a > regular release (perhaps 0.13.0). > 2) Create a new repo for them and release it as gtk on Hackage > (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. > 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. > > Please can we start the ball rolling on option 1 or can you let me > know which of the other two options you would prefer? Hey Hamish. Patches to gtk are in -- let's see what breaks! Looking at patches to gtksourceview and webkit next. Thanks again for all your (and Peter's) hard work. ~d |
From: <wag...@se...> - 2013-02-16 02:21:58
|
Hi Hamish -- I'm taking a look at the webkit patches. I understand the gtk3 flag is pretty unavoidable, but the webkit1-8 flag is a bit unfortunate. Do you have a feeling for how difficult it would be to do as in the gtk package and use CPP to choose code based on which version of webkit is available? I guess the main piece of interest is how to expose the G.U.G.W.DOM hierarchy or not; I wonder how painful it would be for those modules to just be empty if the version of webkit is too low (i.e. always exposed). ~d Quoting Hamish Mackenzie <ham...@gm...>: > Hi, > > I want to do a release of Leksah to Hackage that uses Gtk3 and > WebKit (preferably in the next week or two). > > This will need the following patches: > https://patch-tag.com/r/hamish/gtk2hs > http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) > https://patch-tag.com/r/hamish/webkit > > Although these packages default to gtk3 you can still use them with > gtk2 (cabal install -f-gtk3) > > I think we have three options: > 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a > regular release (perhaps 0.13.0). > 2) Create a new repo for them and release it as gtk on Hackage > (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. > 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. > > Please can we start the ball rolling on option 1 or can you let me > know which of the other two options you would prefer? > > Thanks, > Hamish > > > |
From: Hamish M. <ham...@gm...> - 2013-02-21 00:45:00
|
I would like to keep the 1.8 support (that is what is available on travis-ci). I'll try to have a look at it this weekend. If the changes are not to great I will try to #ifdefs to the main source directory (and just leave out anything that is out of date or missing in 1.8). On 16 Feb 2013, at 15:21, wag...@se... wrote: > Hi Hamish -- > > I'm taking a look at the webkit patches. I understand the gtk3 flag is pretty unavoidable, but the webkit1-8 flag is a bit unfortunate. Do you have a feeling for how difficult it would be to do as in the gtk package and use CPP to choose code based on which version of webkit is available? > > I guess the main piece of interest is how to expose the G.U.G.W.DOM hierarchy or not; I wonder how painful it would be for those modules to just be empty if the version of webkit is too low (i.e. always exposed). > > ~d > > Quoting Hamish Mackenzie <ham...@gm...>: > >> Hi, >> >> I want to do a release of Leksah to Hackage that uses Gtk3 and WebKit (preferably in the next week or two). >> >> This will need the following patches: >> https://patch-tag.com/r/hamish/gtk2hs >> http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) >> https://patch-tag.com/r/hamish/webkit >> >> Although these packages default to gtk3 you can still use them with gtk2 (cabal install -f-gtk3) >> >> I think we have three options: >> 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a regular release (perhaps 0.13.0). >> 2) Create a new repo for them and release it as gtk on Hackage (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. >> 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. >> >> Please can we start the ball rolling on option 1 or can you let me know which of the other two options you would prefer? >> >> Thanks, >> Hamish >> >> >> > > |
From: <wag...@se...> - 2013-02-21 13:42:17
|
Quoting Hamish Mackenzie <ham...@gm...>: > I would like to keep the 1.8 support (that is what is available on > travis-ci). Oh, absolutely. I just mean the *flag* is unfortunate, not that the support is unfortunate. > I'll try to have a look at it this weekend. If the changes are not > to great I will try to #ifdefs to the main source directory (and > just leave out anything that is out of date or missing in 1.8). > > On 16 Feb 2013, at 15:21, wag...@se... wrote: > >> Hi Hamish -- >> >> I'm taking a look at the webkit patches. I understand the gtk3 flag >> is pretty unavoidable, but the webkit1-8 flag is a bit unfortunate. >> Do you have a feeling for how difficult it would be to do as in the >> gtk package and use CPP to choose code based on which version of >> webkit is available? >> >> I guess the main piece of interest is how to expose the G.U.G.W.DOM >> hierarchy or not; I wonder how painful it would be for those >> modules to just be empty if the version of webkit is too low (i.e. >> always exposed). >> >> ~d >> >> Quoting Hamish Mackenzie <ham...@gm...>: >> >>> Hi, >>> >>> I want to do a release of Leksah to Hackage that uses Gtk3 and >>> WebKit (preferably in the next week or two). >>> >>> This will need the following patches: >>> https://patch-tag.com/r/hamish/gtk2hs >>> http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) >>> https://patch-tag.com/r/hamish/webkit >>> >>> Although these packages default to gtk3 you can still use them >>> with gtk2 (cabal install -f-gtk3) >>> >>> I think we have three options: >>> 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a >>> regular release (perhaps 0.13.0). >>> 2) Create a new repo for them and release it as gtk on Hackage >>> (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. >>> 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. >>> >>> Please can we start the ball rolling on option 1 or can you let me >>> know which of the other two options you would prefer? >>> >>> Thanks, >>> Hamish >>> >>> >>> >> >> > > > |
From: Hamish M. <ham...@gm...> - 2013-03-02 04:02:40
|
Sorry I did not get to this last weekend. Luite and I both caught a nasty cold at mloc-js and I spent the whole of last weekend in bed. I have pushed a patch that removes the webkit1.8 flag and uses the CPP instead... https://patch-tag.com/r/hamish/webkit/home Here is in action... https://travis-ci.org/leksah/leksah Hamish On 22 Feb 2013, at 02:42, wag...@se... wrote: > Quoting Hamish Mackenzie <ham...@gm...>: > >> I would like to keep the 1.8 support (that is what is available on travis-ci). > > Oh, absolutely. I just mean the *flag* is unfortunate, not that the support is unfortunate. > >> I'll try to have a look at it this weekend. If the changes are not to great I will try to #ifdefs to the main source directory (and just leave out anything that is out of date or missing in 1.8). >> >> On 16 Feb 2013, at 15:21, wag...@se... wrote: >> >>> Hi Hamish -- >>> >>> I'm taking a look at the webkit patches. I understand the gtk3 flag is pretty unavoidable, but the webkit1-8 flag is a bit unfortunate. Do you have a feeling for how difficult it would be to do as in the gtk package and use CPP to choose code based on which version of webkit is available? >>> >>> I guess the main piece of interest is how to expose the G.U.G.W.DOM hierarchy or not; I wonder how painful it would be for those modules to just be empty if the version of webkit is too low (i.e. always exposed). >>> >>> ~d >>> >>> Quoting Hamish Mackenzie <ham...@gm...>: >>> >>>> Hi, >>>> >>>> I want to do a release of Leksah to Hackage that uses Gtk3 and WebKit (preferably in the next week or two). >>>> >>>> This will need the following patches: >>>> https://patch-tag.com/r/hamish/gtk2hs >>>> http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) >>>> https://patch-tag.com/r/hamish/webkit >>>> >>>> Although these packages default to gtk3 you can still use them with gtk2 (cabal install -f-gtk3) >>>> >>>> I think we have three options: >>>> 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for a regular release (perhaps 0.13.0). >>>> 2) Create a new repo for them and release it as gtk on Hackage (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes in. >>>> 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. >>>> >>>> Please can we start the ball rolling on option 1 or can you let me know which of the other two options you would prefer? >>>> >>>> Thanks, >>>> Hamish >>>> >>>> >>>> >>> >>> >> >> >> > > |
From: <wag...@se...> - 2013-03-02 12:25:02
|
I'm at a go tournament this weekend, but will take a look Monday or Tuesday. Thanks! ~d Quoting Hamish Mackenzie <ham...@gm...>: > Sorry I did not get to this last weekend. Luite and I both caught a > nasty cold at mloc-js and I spent the whole of last weekend in bed. > > I have pushed a patch that removes the webkit1.8 flag and uses the > CPP instead... > https://patch-tag.com/r/hamish/webkit/home > > Here is in action... > https://travis-ci.org/leksah/leksah > > Hamish > > On 22 Feb 2013, at 02:42, wag...@se... wrote: > >> Quoting Hamish Mackenzie <ham...@gm...>: >> >>> I would like to keep the 1.8 support (that is what is available on >>> travis-ci). >> >> Oh, absolutely. I just mean the *flag* is unfortunate, not that the >> support is unfortunate. >> >>> I'll try to have a look at it this weekend. If the changes are >>> not to great I will try to #ifdefs to the main source directory >>> (and just leave out anything that is out of date or missing in 1.8). >>> >>> On 16 Feb 2013, at 15:21, wag...@se... wrote: >>> >>>> Hi Hamish -- >>>> >>>> I'm taking a look at the webkit patches. I understand the gtk3 >>>> flag is pretty unavoidable, but the webkit1-8 flag is a bit >>>> unfortunate. Do you have a feeling for how difficult it would be >>>> to do as in the gtk package and use CPP to choose code based on >>>> which version of webkit is available? >>>> >>>> I guess the main piece of interest is how to expose the >>>> G.U.G.W.DOM hierarchy or not; I wonder how painful it would be >>>> for those modules to just be empty if the version of webkit is >>>> too low (i.e. always exposed). >>>> >>>> ~d >>>> >>>> Quoting Hamish Mackenzie <ham...@gm...>: >>>> >>>>> Hi, >>>>> >>>>> I want to do a release of Leksah to Hackage that uses Gtk3 and >>>>> WebKit (preferably in the next week or two). >>>>> >>>>> This will need the following patches: >>>>> https://patch-tag.com/r/hamish/gtk2hs >>>>> http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) >>>>> https://patch-tag.com/r/hamish/webkit >>>>> >>>>> Although these packages default to gtk3 you can still use them >>>>> with gtk2 (cabal install -f-gtk3) >>>>> >>>>> I think we have three options: >>>>> 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for >>>>> a regular release (perhaps 0.13.0). >>>>> 2) Create a new repo for them and release it as gtk on Hackage >>>>> (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes >>>>> in. >>>>> 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. >>>>> >>>>> Please can we start the ball rolling on option 1 or can you let >>>>> me know which of the other two options you would prefer? >>>>> >>>>> Thanks, >>>>> Hamish >>>>> >>>>> >>>>> >>>> >>>> >>> >>> >>> >> >> > > > |
From: <wag...@se...> - 2013-03-05 23:05:31
|
Pushed. I guess it's a bit fragile (you have to make sure to build gtk and webkit either both with -fgtk3 or both with -f-gtk3) but I don't really see a way around that. Thanks for your hard work! ~d Quoting Hamish Mackenzie <ham...@gm...>: > Sorry I did not get to this last weekend. Luite and I both caught a > nasty cold at mloc-js and I spent the whole of last weekend in bed. > > I have pushed a patch that removes the webkit1.8 flag and uses the > CPP instead... > https://patch-tag.com/r/hamish/webkit/home > > Here is in action... > https://travis-ci.org/leksah/leksah > > Hamish > > On 22 Feb 2013, at 02:42, wag...@se... wrote: > >> Quoting Hamish Mackenzie <ham...@gm...>: >> >>> I would like to keep the 1.8 support (that is what is available on >>> travis-ci). >> >> Oh, absolutely. I just mean the *flag* is unfortunate, not that the >> support is unfortunate. >> >>> I'll try to have a look at it this weekend. If the changes are >>> not to great I will try to #ifdefs to the main source directory >>> (and just leave out anything that is out of date or missing in 1.8). >>> >>> On 16 Feb 2013, at 15:21, wag...@se... wrote: >>> >>>> Hi Hamish -- >>>> >>>> I'm taking a look at the webkit patches. I understand the gtk3 >>>> flag is pretty unavoidable, but the webkit1-8 flag is a bit >>>> unfortunate. Do you have a feeling for how difficult it would be >>>> to do as in the gtk package and use CPP to choose code based on >>>> which version of webkit is available? >>>> >>>> I guess the main piece of interest is how to expose the >>>> G.U.G.W.DOM hierarchy or not; I wonder how painful it would be >>>> for those modules to just be empty if the version of webkit is >>>> too low (i.e. always exposed). >>>> >>>> ~d >>>> >>>> Quoting Hamish Mackenzie <ham...@gm...>: >>>> >>>>> Hi, >>>>> >>>>> I want to do a release of Leksah to Hackage that uses Gtk3 and >>>>> WebKit (preferably in the next week or two). >>>>> >>>>> This will need the following patches: >>>>> https://patch-tag.com/r/hamish/gtk2hs >>>>> http://leksah.org/gtksourceview3.patches (repo still seems to be darcs1) >>>>> https://patch-tag.com/r/hamish/webkit >>>>> >>>>> Although these packages default to gtk3 you can still use them >>>>> with gtk2 (cabal install -f-gtk3) >>>>> >>>>> I think we have three options: >>>>> 1) Push the Gtk3 patches into the Gtk2Hs repo in preparation for >>>>> a regular release (perhaps 0.13.0). >>>>> 2) Create a new repo for them and release it as gtk on Hackage >>>>> (version 1.0.0 or 0.13.0) and continue merging 0.12 repo changes >>>>> in. >>>>> 3) Add gtk-gtk3, gtksourceview-gtk3 and webkit-gtk3 to Hackage. >>>>> >>>>> Please can we start the ball rolling on option 1 or can you let >>>>> me know which of the other two options you would prefer? >>>>> >>>>> Thanks, >>>>> Hamish >>>>> >>>>> >>>>> >>>> >>>> >>> >>> >>> >> >> > > > |