From: Duncan C. <du...@co...> - 2002-11-10 14:01:43
|
Hi, ghc 5.04 complained, this fixes it. Index: ListTest.hs =================================================================== RCS file: /cvsroot/gtk2hs/gtk2hs/demo/treeList/ListTest.hs,v retrieving revision 1.3 diff -C2 -r1.3 ListTest.hs *** ListTest.hs 18 Jul 2002 18:14:30 -0000 1.3 --- ListTest.hs 10 Nov 2002 13:57:22 -0000 *************** *** 2,6 **** module Main(Main.main) where ! import Mogul main = do --- 2,7 ---- module Main(Main.main) where ! import Mogul hiding (main) ! import qualified Mogul (main) main = do |
From: Duncan C. <du...@co...> - 2002-11-10 14:12:57
|
Hi, ghc 5.04 complained, this fixes it. BTW sorry about the random subscription confirm email that turned up on the list, my mailer ignored the reply-to header. Duncan Index: ListTest.hs =================================================================== RCS file: /cvsroot/gtk2hs/gtk2hs/demo/treeList/ListTest.hs,v retrieving revision 1.3 diff -C2 -r1.3 ListTest.hs *** ListTest.hs 18 Jul 2002 18:14:30 -0000 1.3 --- ListTest.hs 10 Nov 2002 13:57:22 -0000 *************** *** 2,6 **** module Main(Main.main) where ! import Mogul main = do --- 2,7 ---- module Main(Main.main) where ! import Mogul hiding (main) ! import qualified Mogul (main) main = do |
From: Axel S. <A....@uk...> - 2002-11-11 19:43:04
|
On Sun, Nov 10, 2002 at 02:04:21PM +0000, Duncan Coutts wrote: Committed. Thanks, Axel > Index: ListTest.hs > =================================================================== > RCS file: /cvsroot/gtk2hs/gtk2hs/demo/treeList/ListTest.hs,v > retrieving revision 1.3 > diff -C2 -r1.3 ListTest.hs > *** ListTest.hs 18 Jul 2002 18:14:30 -0000 1.3 > --- ListTest.hs 10 Nov 2002 13:57:22 -0000 > *************** > *** 2,6 **** > module Main(Main.main) where > > ! import Mogul > > main = do > --- 2,7 ---- > module Main(Main.main) where > > ! import Mogul hiding (main) > ! import qualified Mogul (main) > > main = do > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Gtk2hs-users mailing list > Gtk...@li... > https://lists.sourceforge.net/lists/listinfo/gtk2hs-users |
From: Axel S. <A....@uk...> - 2002-11-11 21:37:40
|
On Sun, Nov 10, 2002 at 02:04:21PM +0000, Duncan Coutts wrote: > module Main(Main.main) where > > ! import Mogul hiding (main) > ! import qualified Mogul (main) I consider this as very annoying. I propose the following change which breaks existing code: Replace init, main, mainLevel, mainIteration with withGUI, runLoop, loopLevel, loopQuit, loopIteration, loopIterationDo . The type of withGUI has now changed and is a wrapper like withSockets from the networks package. In case anyone is unhappy with these changes or has better ideas for names, let me know. Otherwise I'll commit tomorrow evening. Axel. |
From: Jens P. <pet...@re...> - 2002-11-14 12:52:32
|
Axel Simon <A....@uk...> writes: > On Sun, Nov 10, 2002 at 02:04:21PM +0000, Duncan Coutts wrote: > > module Main(Main.main) where > > > > ! import Mogul hiding (main) > > ! import qualified Mogul (main) > > I consider this as very annoying. I propose the following change which > breaks existing code: Replace > init, > main, > mainLevel, mailQuit > mainIteration mainIterationDo > > with > > withGUI, > runLoop, > loopLevel, > loopQuit, > loopIteration, > loopIterationDo > > . The type of withGUI has now changed and is a wrapper like withSockets > from the networks package. In case anyone is unhappy with these changes or > has better ideas for names, let me know. Otherwise I'll commit tomorrow > evening. Hrmm, is this change proposed just for Mogul or also for Gtk? I'm not very fond of withSockets, and withGUI doesn't strike me as being particularly attractive, unless there is a compelling reason for changing the semantics. If all the names must be changed, gtkInit, gtkMain, gtkMainLevel, gtkMainIteration etc would at least be closer to the original naming. Though it seems to me just renaming `init' and `main' is sufficient. Just my 2 yens worth, Jens |
From: Axel S. <A....@uk...> - 2002-11-14 15:23:04
|
On Thu, Nov 14, 2002 at 09:52:42PM +0900, Jens Petersen wrote: > Hrmm, is this change proposed just for Mogul or also for > Gtk? These are definitions in the Gtk package: gtk/general/General.chs I'm not very fond of withSockets, and withGUI doesn't > strike me as being particularly attractive, unless there is > a compelling reason for changing the semantics. Instead of a wrapper I could define an initilization function as we had. Let's call it initGUI :: IO [String] which returns the argument list. (I'd like to change the the values getArgs returns directly, but there is no setArgs function in the current GHC anymore) > If all the names must be changed, > > gtkInit, > gtkMain, > gtkMainLevel, > gtkMainIteration > would at least be closer to the original naming. Yes, but there is no gtk prefix throughout the library, so this would be inconsistent. Perhaps we could just rename main to runMain or mainRun but that does not really convey what the function does. That's why I suggested loopRun (or just loop?). > Though it seems to me just renaming `init' and `main' is > sufficient. Yes, but I think the other functions should have similar names since they talk about the same logical object. Opinions? Axel. |
From: Jens P. <pet...@re...> - 2002-11-17 05:52:34
|
Axel Simon <A....@uk...> writes: > On Thu, Nov 14, 2002 at 09:52:42PM +0900, Jens Petersen wrote: > > Hrmm, is this change proposed just for Mogul or also for > > Gtk? > These are definitions in the Gtk package: gtk/general/General.chs > Instead of a wrapper I could define an initilization function as we had. > Let's call it > initGUI :: IO [String] > which returns the argument list. Ok, that seems to make sense. > Perhaps we could just rename main to runMain or mainRun > but that does not really convey what the function > does. That's why I suggested loopRun (or just loop?). In following with initGUI, how about mainGUI then? Though perhaps initGTK, mainGTK would be better? But the question also arises, how will this renaming fit into a future hierarchial module naming scheme? > > Though it seems to me just renaming `init' and `main' is > > sufficient. > Yes, but I think the other functions should have similar names since they > talk about the same logical object. True. Jens |
From: Axel S. <A....@uk...> - 2002-11-20 08:45:36
|
On Sun, Nov 17, 2002 at 02:53:09PM +0900, Jens Petersen wrote: > > Let's call it > > initGUI :: IO [String] > > which returns the argument list. > > Ok, that seems to make sense. > > > Perhaps we could just rename main to runMain or mainRun > > but that does not really convey what the function > > does. That's why I suggested loopRun (or just loop?). > > In following with initGUI, how about mainGUI then? Though > perhaps initGTK, mainGTK would be better? Since there is no mentioning of GTK anywhere else I'd rather conceal the fact that is GTK: If anyone uses Mogul, functions named ...GTK seem to be confusing. > But the question also arises, how will this renaming fit > into a future hierarchial module naming scheme? I think the problems will stay the same. You usually import all entities and become more qualified when you use names ambiguously (e.g. main always clashes unless you don't use it in the main module). Since these functions are always used, it seems to be justified to rename them so they don't clash. > > > Though it seems to me just renaming `init' and `main' is > > > sufficient. > > Yes, but I think the other functions should have similar names since they > > talk about the same logical object. > > True. So shall we go for mainGUI, initGUI, ....? Axel. |
From: Axel S. <A....@uk...> - 2002-12-01 16:00:54
|
On Wed, Nov 20, 2002 at 08:44:05AM +0000, Axel Simon wrote: > > So shall we go for mainGUI, initGUI, ....? Due to lack of replies, I changed it. It's in the CVS. Please complain or update your applications. Axel. |