From: Peter G. <pg...@gm...> - 2007-05-29 06:11:04
Attachments:
gtk2hs-pgavin-20070529.darcs-patch.bz2
|
Hello everyone, I'm going to be pretty busy for the next 2 or 3 weeks, so I figured I'd send an updated patch of my changes. I'd say about 70% of the GnomeVFS API is covered. I'm not sure if the remaining 30% is worth wrapping. If it turns out I need it, I might complete more of it. Please let me know if there's anything you'd like me to change or fix :) Pete |
From: Peter G. <pg...@gm...> - 2007-06-20 15:39:46
Attachments:
gtk2hs.gnomevfs.diff.bz2
|
I made a new branch off the main gtk2hs repo, and copied from my repo just the gnomevfs package, and not any of the other miscellaneous changes I've made. So this patch is much cleaner than the previous one. All that remains to be done is more documentation. Pete |
From: Axel S. <A....@ke...> - 2007-06-21 13:01:01
|
Hi Pete, On Wed, 2007-06-20 at 11:39 -0400, Peter Gavin wrote: > I made a new branch off the main gtk2hs repo, and copied from my repo > just the gnomevfs package, and not any of the other miscellaneous > changes I've made. So this patch is much cleaner than the previous > one. All that remains to be done is more documentation. That looks very good to me indeed. I'm sure we will incorporate that sooon, depending on how and if Duncan does a patch-level release. Two minor issues: - you've used OPTIONS -fglasgow-exts inside a file, could you remove that and specify has extra HC flags for that file in Makefile.am (for examples, see the gtk package). - you have your own marshalling module containing toBool and fromBool. These are also available in System.Glib.FFI. I guess it's not worth changing. Maybe we should incorporated your variants for flags and enums into FFI.hs We can do these changes. We'll let you know once it's in darcs. Thanks a lot for your *big* contribution! Axel. > Pete > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ Gtk2hs-devel mailing list Gtk...@li... https://lists.sourceforge.net/lists/listinfo/gtk2hs-devel |
From: Peter G. <pg...@gm...> - 2007-06-21 13:26:44
|
On 6/21/07, Axel Simon <A....@ke...> wrote: > Two minor issues: > - you've used OPTIONS -fglasgow-exts inside a file, could you remove > that and specify has extra HC flags for that file in Makefile.am (for > examples, see the gtk package). Ok, sure. > - you have your own marshalling module containing toBool and fromBool. > These are also available in System.Glib.FFI. I guess it's not worth > changing. Maybe we should incorporated your variants for flags and enums > into FFI.hs I guess I didn't realize those were there. I'll change my code to use them. > > We can do these changes. We'll let you know once it's in darcs. > > Thanks a lot for your *big* contribution! You're welcome :) I've actually already fixed a few things and added more documentation, so if you want, I can send those changes before you import the patch. Pete |
From: Peter G. <pg...@gm...> - 2007-06-21 18:56:54
Attachments:
gtk2hs.gnomevfs.diff.bz2
|
On 6/21/07, Axel Simon <A....@ke...> wrote: > On Thu, 2007-06-21 at 09:26 -0400, Peter Gavin wrote: > > > I've actually already fixed a few things and added more documentation, > > so if you want, I can send those changes before you import the patch. > > Yes, please! Ok, I've attached my most recent diff. It includes the patch I sent earlier. Is there a way I can just send the changes since the last diff? Pete |
From: Duncan C. <dun...@wo...> - 2007-05-30 20:47:56
|
On Tue, 2007-05-29 at 02:11 -0400, Peter Gavin wrote: > Hello everyone, > > I'm going to be pretty busy for the next 2 or 3 weeks, so I figured > I'd send an updated patch of my changes. I'd say about 70% of the > GnomeVFS API is covered. I'm not sure if the remaining 30% is worth > wrapping. If it turns out I need it, I might complete more of it. > > Please let me know if there's anything you'd like me to change or fix :) Great, I'll take a look. Duncan |