From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2013-12-08 17:31:12
|
https://bugzilla.gnome.org/show_bug.cgi?id=711839 gnome-perl | Glib | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaf...@gm... --- Comment #2 from Torsten Schoenfeld <kaf...@gm...> 2013-12-08 17:31:00 UTC --- The patch looks good to me (apart from some minor spaces-vs-tabs issues), but it needs some unit tests. Also, as far as I can see, this would suffer from the same kinds of problems that the Glib::Idle approach has when used by Perl code running in different threads: If you call $context->invoke() from some thread on a context not attached to that thread, then gperl_main_context_invoke_callback() will access SV* pointers from the calling thread in the context's thread, i.e. it will try to use SV* pointers belonging to one Perl interpreter instance with another Perl interpreter instance. This is unreliable. This is not an argument against the patch, however. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |