From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2011-08-16 20:43:33
|
https://bugzilla.gnome.org/show_bug.cgi?id=593289 gnome-perl | general | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141852|none |needs-work status| | --- Comment #1 from Torsten Schoenfeld <kaf...@gm...> 2011-08-16 20:10:28 UTC --- Review of attachment 141852: --> (https://bugzilla.gnome.org/review?bug=593289&attachment=141852) Sorry for the late response. Initially, I was hesitant to apply this because it just begs the question: what about Gtk2? I don't think anyone would want to tackle adding whatis entries for all of Gtk2. I changed my mind though, and wanted to apply this. But there are one or two small problems with the patch as it stands: ::: xs/PangoAttributes.xs @@ +981,3 @@ MODULE = Pango::Attributes PACKAGE = Pango::AttrList PREFIX = pango_attr_list_ + Needless whitespace change. @@ -23,3 @@ -=for object Pango::FontDescription -=cut Removing this causes the following methods to end up in a Pango.pod file, overriding the main Pango POD/man page. @@ +16,3 @@ # Don't doc these in Pango, or we'll clobber the main POD page! +=for object Pango layout and render international text This, too, has the potential for overriding the main Pango POD/man page. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |