[Gtk2-perl-bugs] [Bug 638138] GenPod show property default values

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=638138
  gnome-perl | Glib | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177107|none                        |reviewed
             status|                            |

--- Comment #1 from Torsten Schoenfeld <kaf...@gm...> 2011-08-16 19:20:29 UTC ---
Review of attachment 177107:
 --> (https://bugzilla.gnome.org/review?bug=638138&attachment=177107)

Fantastic patch!  Only one minor quibble...

::: lib/Glib/GenPod.pm
@@ +545,3 @@
+  my $type = $pspec->get_value_type;
+
+  if ($type->isa('Glib::Boolean')) {

... it seems like this needs to "$type eq 'Glib::Boolean'", right?  Because
Glib::Boolean->isa('Glib::Boolean') is actually false.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.