[Gtk2-perl-bugs] [Bug 639558] Pixbuf new_from_data() vs overload

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=639558
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kaf...@gm...

--- Comment #1 from Torsten Schoenfeld <kaf...@gm...> 2011-08-08 16:02:40 UTC ---
(In reply to comment #0)
> Is there a reason Gtk2::Gdk::Pixbuf->new_from_data() demands SvPOK of its data
> input?  I thought it might SvPV to stringize in the usual way.  Doing so would
> allow overloads and magic to work there the same way as they do elsewhere.

Sounds good to me.

> Possible simplification below, copying out the SvPV data into a malloced block
> for the pixbuf data area rather than an newSVsv.

Also good.  But any particular reason you use perl's memory-handling macros? 
Nearly all the other code in Glib and Gtk2 uses glib's things (g_new,
g_memdup).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.