[Gtk2-perl-bugs] [Bug 639559] GdkWindow pod on subclassing

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=639559
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178350|none                        |needs-work
             status|                            |

--- Comment #1 from Torsten Schoenfeld <kaf...@gm...> 2011-08-08 15:42:19 UTC ---
Review of attachment 178350:
 --> (https://bugzilla.gnome.org/review?bug=639559&attachment=178350)

::: xs/GdkWindow.xs
@@ +201,3 @@
+these is created when a widget is "realized".
+
+As of Gtk 2.22 a window can only be created by

It should be 'gtk+ 2.22' to avoid confusion.

@@ +208,3 @@
+window creation, and that function always makes a C<GdkWindow> (the
+class name argument to the Perl-Gtk C<< Gtk2::Gdk::Window->new >>
+wrapper is unused).

While it's true that you cannot subclass Gtk2::Gdk::Window from the GType
perspective, you can still simply call Gtk2::Gdk::Window->new in your
constructor and then re-bless the result.  So maybe something like this: "And
it's not possible to subclass C<Gtk2::Gdk::Window> using
L<Glib::Object::Subclass>, [...]"?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.