From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-05 17:51:53
|
https://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | unspecified --- Comment #2 from Torsten Schoenfeld <kaf...@gm...> 2010-12-05 17:51:43 UTC --- Review of attachment 132736: --> (https://bugzilla.gnome.org/review?bug=579103&attachment=132736) Sorry for the huge delay. One question below, otherwise the patch looks great. ::: GLog.xs @@ +207,3 @@ + default_handler_coderef = newRV_inc ((SV*) cv); + } +#endif Is the risk of someone overwriting Glib::Log::default_handler really worth having a global pointer and executing this code on startup for each and every program? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |