[Gtk2-perl-bugs] [Bug 613973] Menu popup() protect against die

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=613973
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #157125|accepted-commit_now         |needs-work
             status|                            |

--- Comment #3 from Torsten Schoenfeld <kaf...@gm...> 2010-03-31 17:27:26 UTC ---
Review of attachment 157125:
 --> (https://bugzilla.gnome.org/review?bug=613973&attachment=157125)

Looks good to me in general.  Two minor things:

::: t/GtkMenu.t
@@ +142,3 @@
+      'popup positioning die() is not fatal');
+}
+

What's with $popup_runs here?  Looks like dead code.

::: xs/GtkMenu.xs
@@ +88,1 @@


Here and in the previous chunk above, you use spaces for indentation, but we
use tabs in XS code.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.