From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-07 04:15:11
|
https://bugzilla.gnome.org/show_bug.cgi?id=591070 gnome-perl | Glib | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaf...@gm... --- Comment #2 from Torsten Schoenfeld <kaf...@gm...> 2010-03-06 14:57:45 UTC --- muppet created a similar patch many moons ago, and I recently committed it (without remembering this bug entry): <http://git.gnome.org/browse/perl-Glib/commit/?id=2b1a35b9d>. This old patch called the is_a_type accessor simply is_a_type(), which is inconsistent, so I just fixed that: <http://git.gnome.org/browse/perl-Glib/commit/?id=78696b6f8>. As far as I can see, the only remaining substantial difference between your patch and the committed version is this: --- a/GType.xs +++ b/GType.xs @@ -2018,6 +2018,7 @@ BOOT: gperl_register_fundamental (G_TYPE_FLOAT, "Glib::Float"); gperl_register_fundamental (G_TYPE_DOUBLE, "Glib::Double"); gperl_register_fundamental (G_TYPE_BOOLEAN, "Glib::Boolean"); + gperl_register_fundamental (G_TYPE_GTYPE, "Glib::GType"); gperl_register_boxed (GPERL_TYPE_SV, "Glib::Scalar", NULL); /* i love nasty ugly hacks for backwards compat... Glib::UInt used I'm not entirely sure what this achieves. Does it allow me to have, say, Glib::TreeView columns of type "Glib::GType"? If so, do we want to allow that? (We used to completely hide the existence of GType from the Perl programmer.) What else does this do? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |