From: <bug...@bu...> - 2005-04-19 12:23:57
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From muppet 2005-04-19 08:23 ------- In get_keys() and get_groups(), you return a list of strings, or undef if= the C function returns no strings. =20 in perl that means that whether the function returned anything or not, @= return > 0. to check if there=20 are keys, i have to explicitly check defined($ret[0]). it would be easie= r to use (and code) if it returned an=20 empty list instead of undef. in the set_boolean case of set_boolean, you want SvTRUE rather than SvIV = -- this will allow you to=20 handle undef without warnings at runtime. similarly, get_boolean should = use boolSV for the new=20 boolean output value instead of newSViv. (yeah, 0 is false, but that's n= ot perl's boolean false -- that's=20 ''.) the same goes for the [sg]et_boolean_list ones. ------- You are receiving this mail because: ------- You are the assignee for the bug. |