gtk2-perl-bugs

[Gtk2-perl-bugs] [Bug 570793] New: Make Gtk2::Orientable implementable by Perl subclasses

[gnome-perl (bugzilla.gnome.org) <bug...@bu...>]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=570793

  gnome-perl | Gtk2 | Ver: unspecified
           Summary: Make Gtk2::Orientable implementable by Perl subclasses
           Product: gnome-perl
           Version: unspecified
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: Gtk2
        AssignedTo: gtk...@li...
        ReportedBy: kaf...@gm...
         QAContact: gtk...@li...
 BugsThisDependsOn: 570792
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Once support for interface properties has landed in Glib, we can make
Gtk2::Orientable implementable.  (I'm starting to feel like I'm talking Java
with all those "-able"s.)

Emmanuel already wrote the _ADD_INTERFACE xsub:

=for apidoc __hide__
=cut
void
_ADD_INTERFACE (class, const char * target_class)
    CODE:
    {
        static const GInterfaceInfo iface_info = {
                (GInterfaceInitFunc) NULL,
                (GInterfaceFinalizeFunc) NULL,
                (gpointer) NULL
        };
        GType gtype = gperl_object_type_from_package (target_class);
        g_type_add_interface_static (gtype, GTK_TYPE_ORIENTABLE, &iface_info);
    }


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=570793.

[Gtk2-perl-bugs] [Bug 570793] Make Gtk2::Orientable implementable by Perl subclasses

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=570793
  gnome-perl | Gtk2 | unspecified

Kevin Ryde <user42> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |us...@zi...

--- Comment #1 from Kevin Ryde <us...@zi...> 2010-11-08 20:00:54 UTC ---
Adding this could make it implementable now, if a class also made its own

    properties=>[Glib::ParamSpec->boolean('orientation')]

Not sure that's to be recommended though, if the glib interface stuff is going
to automatically create the interface properties later on.

Depends perhaps what the glib stuff is going to do if it finds the property in
question already exists.  You'd be inclined to make it an
error/warning/log/whatever, but I suppose it could quietly assume the subclass
knew what it was doing and omit interface properties already in the subclass
(and not in a superclass).  Would that be a bit painful?  One thing it might
allow though is the pspec=>,get=>,set=> style property creation dispatching to
individual handler funcs instead of GET_PROPERTY/SET_PROPERTY.

    properties => [ { pspec => Glib::ParamSpec->override
                               ('orientation',
                                
Gtk2::Orientable->find_property('orientation')),
                      get => \&_my_orient_get,
                      set => \&_my_orient_set,
                    } ]

Bit tedious to write as well as to implement maybe :-).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 570793] Make Gtk2::Orientable implementable by Perl subclasses

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=570793
  gnome-perl | Gtk2 | unspecified

--- Comment #2 from Kevin Ryde <us...@zi...> 2010-12-27 22:37:56 UTC ---
Another thing that allowing a subclass to add the property itself could do is
allow a different default value in the ParamSpec, if you made an "orientation"
property which was the same as in Orientable except for the default_value
field.

Can you claim to be "Orientable" if your default is not the interface pspec
default?  You'd like to think so, though I expect prefering the "horizontal"
per the interface would be clearest most of the time.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.