Menu
▾
▴
gtk2-perl-bugs
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-04-15 23:55:36
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | Ver: unspecified Summary: GLog default handler Product: gnome-perl Version: unspecified Platform: Other OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: Normal Component: Glib AssignedTo: gtk...@li... ReportedBy: us...@zi... QAContact: gtk...@li... GNOME version: Unspecified GNOME milestone: Unspecified The additions below is where I got to for a g_log_set_default_handler at the perl level, and also making g_log_default_handler available if you want to call to it from your handler (either a default handler or a specific set_handler one). The way set_default_handler returns \&Glib::Log::default_handler is meant to correspond to the C code where the default handler must always be some particular function pointer, not NULL. -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=579103. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-04-15 23:56:35
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | Ver: unspecified ------- Comment #1 from Kevin Ryde 2009-04-15 23:56 UTC ------- Created an attachment (id=132736) --> (http://bugzilla.gnome.org/attachment.cgi?id=132736&action=view) wrapping g_log_set_default_handler and g_log_default_handler -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=579103. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-05 17:51:53
|
https://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | unspecified --- Comment #2 from Torsten Schoenfeld <kaf...@gm...> 2010-12-05 17:51:43 UTC --- Review of attachment 132736: --> (https://bugzilla.gnome.org/review?bug=579103&attachment=132736) Sorry for the huge delay. One question below, otherwise the patch looks great. ::: GLog.xs @@ +207,3 @@ + default_handler_coderef = newRV_inc ((SV*) cv); + } +#endif Is the risk of someone overwriting Glib::Log::default_handler really worth having a global pointer and executing this code on startup for each and every program? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-06 22:06:41
|
https://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | unspecified --- Comment #3 from Kevin Ryde <us...@zi...> 2010-12-06 22:06:27 UTC --- Hmm. Yes, that looks a bit unnecessary in retrospect. The current \&Glib::Log::default_handler should be good enough, and may even be desirable if someone has changed it with wrapper code or something. But what do we think of \&Glib::Log::default_handler at the perl level anyway? It seems tempting to forget that and let undef mean the default handler, even if at the C level NULL doesn't mean that (and is not allowed). -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-12 15:02:12
|
https://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132736|none |committed status| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-12 15:26:54
|
https://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from Torsten Schoenfeld <kaf...@gm...> 2010-12-12 15:01:58 UTC --- Committed with the mentioned changes. I think that it does make sense to have Glib::Log::default_handler because it allows you to have a custom log handler which just "applies advice" to Glib::Log::default_handler, i.e. it does something but then still calls Glib::Log::default_handler. I added a test case for this. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-12-13 21:30:46
|
https://bugzilla.gnome.org/show_bug.cgi?id=579103 gnome-perl | Glib | unspecified --- Comment #5 from Kevin Ryde <us...@zi...> 2010-12-13 21:30:32 UTC --- Oh, I meant whether Glib->set_default_handler should accept and return \&Glib::Log::default_handler to mean the default handler. Perhaps it would be easier if undef meant the default handler, even though the C g_log_set_default_handler() doesn't work that way (doesn't take NULL). -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X