gtk2-perl-bugs

[Gtk2-perl-bugs] [Bug 635120] New: Region spans multiple-of-3

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=635120
  gnome-perl | Gtk2 | unspecified

           Summary: Region spans multiple-of-3
    Classification: Bindings
           Product: gnome-perl
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: Gtk2
        AssignedTo: gtk...@li...
        ReportedBy: us...@zi...
         QAContact: gtk...@li...
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=174725)
 View: https://bugzilla.gnome.org/attachment.cgi?id=174725
 Review: https://bugzilla.gnome.org/review?bug=635120&attachment=174725

patch and test cases

The croak message in gdk_region_spans_intersect_foreach() refers to GdkPoints,
but I think the spans are triples not pairs.  The need for triples might be
enforced too, ie demand a multiple of 3.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 635120] Region spans multiple-of-3

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=635120
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kaf...@gm...

--- Comment #1 from Torsten Schoenfeld <kaf...@gm...> 2010-11-24 20:46:32 UTC ---
I hit "assertion `spans != NULL'" for the zero test.  So we should probably
disallow that case, but at least we shouldn't be using it in the test suite.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 635120] Region spans multiple-of-3

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=635120
  gnome-perl | Gtk2 | unspecified

--- Comment #2 from Kevin Ryde <us...@zi...> 2010-11-24 22:22:19 UTC ---
Oh, I don't know why I missed that spans==NULL.  I might have had a skip zero
length patch in progress at the same time.  If constructing an array it's
extremely annoying to have to check if it's non-empty before calling that sort
of func, or the draw_points() of the other bug.  Much friendlier to quietly do
nothing on an empty input.  But I'll take that out of the tests to start with.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 635120] Region spans multiple-of-3

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=635120
  gnome-perl | Gtk2 | unspecified

Kevin Ryde <user42> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174725|0                           |1
        is obsolete|                            |

--- Comment #3 from Kevin Ryde <us...@zi...> 2010-11-24 22:26:49 UTC ---
Created an attachment (id=175208)
 View: https://bugzilla.gnome.org/attachment.cgi?id=175208
 Review: https://bugzilla.gnome.org/review?bug=635120&attachment=175208

patch and test cases

Without the empty array test case.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 635120] Region spans multiple-of-3

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=635120
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Torsten Schoenfeld <kaf...@gm...> 2010-11-27 14:16:05 UTC ---
Looks great, committed.  Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 635120] Region spans multiple-of-3

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=635120
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175208|none                        |committed
             status|                            |

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.