gtk2-perl-bugs

[Gtk2-perl-bugs] [Bug 622774] New: gdk_draw_lines() and gdk_draw_points() allow npoints==0

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=622774
  gnome-perl | Gtk2 | unspecified

           Summary: gdk_draw_lines() and gdk_draw_points() allow
                    npoints==0
    Classification: Bindings
           Product: gnome-perl
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: Gtk2
        AssignedTo: gtk...@li...
        ReportedBy: us...@zi...
         QAContact: gtk...@li...
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=164660)
 View: https://bugzilla.gnome.org/attachment.cgi?id=164660
 Review: https://bugzilla.gnome.org/review?bug=622774&attachment=164660

patch

I believe gdk_draw_lines() and gdk_draw_points() allow npoints==0, and doing
nothing on no points it handy if constructing the args from a map or an array.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 622774] gdk_draw_lines() and gdk_draw_points() allow npoints==0

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=622774
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kaf...@gm...

--- Comment #1 from Torsten Schoenfeld <kaf...@gm...> 2010-11-23 21:49:11 UTC ---
Looks good to me in general, only one small problem: G_LIKELY wasn't available
in glib 2.0.  So, can you wrap it in version guards or maybe just remove it?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 622774] gdk_draw_lines() and gdk_draw_points() allow npoints==0

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=622774
  gnome-perl | Gtk2 | unspecified

Kevin Ryde <user42> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164660|0                           |1
        is obsolete|                            |

--- Comment #2 from Kevin Ryde <us...@zi...> 2010-11-27 23:42:06 UTC ---
Created an attachment (id=175392)
 View: https://bugzilla.gnome.org/attachment.cgi?id=175392
 Review: https://bugzilla.gnome.org/review?bug=622774&attachment=175392

patch and test cases

Ah, G_LIKELY, yep.  Tempting to drop it, but I think I like it well enough to
just have a fallback.  I suppose a fallback could go in gperl-private.h or
something if it was to be sprayed around a lot of places.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 622774] gdk_draw_lines() and gdk_draw_points() allow npoints==0

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=622774
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Torsten Schoenfeld <kaf...@gm...> 2010-12-12 13:47:32 UTC ---
Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 622774] gdk_draw_lines() and gdk_draw_points() allow npoints==0

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=622774
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175392|none                        |committed
             status|                            |

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.