gtk2-perl-bugs

[Gtk2-perl-bugs] [Bug 621710] New: Drawable get_image() ref leak

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=621710
  gnome-perl | Gtk2 | unspecified

           Summary: Drawable get_image() ref leak
    Classification: Bindings
           Product: gnome-perl
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: Gtk2
        AssignedTo: gtk...@li...
        ReportedBy: us...@zi...
         QAContact: gtk...@li...
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=163752)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=163752)
leaking program

I think gdk_drawable_get_image() should have _noinc on its return, per attached
diff.  Attached leak.pl otherwise grows apparently forever.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 621710] Drawable get_image() ref leak

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=621710
  gnome-perl | Gtk2 | unspecified

--- Comment #1 from Kevin Ryde <us...@zi...> 2010-06-16 00:11:53 UTC ---
Created an attachment (id=163753)
 View: https://bugzilla.gnome.org/attachment.cgi?id=163753
 Review: https://bugzilla.gnome.org/review?bug=621710&attachment=163753

patch

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 621710] Drawable get_image() ref leak

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=621710
  gnome-perl | Gtk2 | unspecified

Kevin Ryde <user42> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163753|0                           |1
        is obsolete|                            |

--- Comment #2 from Kevin Ryde <us...@zi...> 2010-11-17 00:24:43 UTC ---
Created an attachment (id=174639)
 View: https://bugzilla.gnome.org/attachment.cgi?id=174639
 Review: https://bugzilla.gnome.org/review?bug=621710&attachment=174639

patch and test case

This diff with a test case exercising the problem.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 621710] Drawable get_image() ref leak

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=621710
  gnome-perl | Gtk2 | unspecified

--- Comment #3 from Kevin Ryde <us...@zi...> 2010-11-17 20:47:58 UTC ---
Created an attachment (id=174715)
 View: https://bugzilla.gnome.org/attachment.cgi?id=174715
 Review: https://bugzilla.gnome.org/review?bug=621710&attachment=174715

tests

A couple of test cases for copy_to_image() along the same lines.  Its
refcounting is already right, but just to exercise it.  This diff goes on top
of the get_image() one.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 621710] Drawable get_image() ref leak

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=621710
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174715|none                        |committed
             status|                            |

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 621710] Drawable get_image() ref leak

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=621710
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Torsten Schoenfeld <kaf...@gm...> 2010-11-21 19:30:10 UTC ---
Looks good, committed.  Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 621710] Drawable get_image() ref leak

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=621710
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174639|none                        |committed
             status|                            |

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.